From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9AD8C433DB for ; Mon, 25 Jan 2021 15:57:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0692A21707 for ; Mon, 25 Jan 2021 15:57:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0692A21707 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 707DE8D000C; Mon, 25 Jan 2021 10:57:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B91E8D0001; Mon, 25 Jan 2021 10:57:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CEC28D000C; Mon, 25 Jan 2021 10:57:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0060.hostedemail.com [216.40.44.60]) by kanga.kvack.org (Postfix) with ESMTP id 43A9A8D0001 for ; Mon, 25 Jan 2021 10:57:02 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BF7EE180ACF1F for ; Mon, 25 Jan 2021 15:57:01 +0000 (UTC) X-FDA: 77744751042.25.badge52_6105aab27587 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 8ACFF1804E3A1 for ; Mon, 25 Jan 2021 15:57:01 +0000 (UTC) X-HE-Tag: badge52_6105aab27587 X-Filterd-Recvd-Size: 6170 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 15:57:00 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4AA98AD6B; Mon, 25 Jan 2021 15:56:59 +0000 (UTC) Subject: Re: [PATCH V3] mm/compaction: correct deferral logic for proactive compaction To: Charan Teja Reddy , akpm@linux-foundation.org, mhocko@suse.com, khalid.aziz@oracle.com, ngupta@nitingupta.dev, vinmenon@codeaurora.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1610989938-31374-1-git-send-email-charante@codeaurora.org> From: Vlastimil Babka Message-ID: Date: Mon, 25 Jan 2021 16:56:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <1610989938-31374-1-git-send-email-charante@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/18/21 6:12 PM, Charan Teja Reddy wrote: > should_proactive_compact_node() returns true when sum of the > weighted fragmentation score of all the zones in the node is greater > than the wmark_high of compaction, which then triggers the proactive > compaction that operates on the individual zones of the node. But > proactive compaction runs on the zone only when its weighted > fragmentation score is greater than wmark_low(=wmark_high - 10). > > This means that the sum of the weighted fragmentation scores of all the > zones can exceed the wmark_high but individual weighted fragmentation > zone scores can still be less than wmark_low which makes the unnecessary > trigger of the proactive compaction only to return doing nothing. > > Issue with the return of proactive compaction with out even trying is > its deferral. It is simply deferred for 1 << COMPACT_MAX_DEFER_SHIFT if > the scores across the proactive compaction is same, thinking that > compaction didn't make any progress but in reality it didn't even try. > With the delay between successive retries for proactive compaction is > 500msec, it can result into the deferral for ~30sec with out even trying > the proactive compaction. > > Test scenario is that: compaction_proactiveness=50 thus the wmark_low = > 50 and wmark_high = 60. System have 2 zones(Normal and Movable) with > sizes 5GB and 6GB respectively. After opening some apps on the android, > the weighted fragmentation scores of these zones are 47 and 49 > respectively. Since the sum of these fragmentation scores are above the > wmark_high which triggers the proactive compaction and there since the > individual zones weighted fragmentation scores are below wmark_low, it > returns without trying the proactive compaction. As a result the > weighted fragmentation scores of the zones are still 47 and 49 which > makes the existing logic to defer the compaction thinking that > noprogress is made across the compaction. > > Fix this by checking just zone fragmentation score, not the weighted, in > __compact_finished() and use the zones weighted fragmentation score in > fragmentation_score_node(). In the test case above, If the weighted > average of is above wmark_high, then individual score (not adjusted) of > atleast one zone has to be above wmark_high. Thus it avoids the > unnecessary trigger and deferrals of the proactive compaction. > > Fix-suggested-by: Vlastimil Babka > Signed-off-by: Charan Teja Reddy > --- > > Changes in V3: Addressed suggestions from Vlastimil > > Changes in V2: https://lore.kernel.org/patchwork/patch/1366862/ > > Changes in V1: https://lore.kernel.org/patchwork/patch/1364646/ Andrew, I've noticed that v1 is still in mmotm [1] together with v3, which doesn't make sense together, please drop [1]. Thanks [1] https://www.ozlabs.org/~akpm/mmots/broken-out/mm-compaction-return-proper-state-in-should_proactive_compact_node.patch > mm/compaction.c | 20 ++++++++++++++------ > 1 file changed, 14 insertions(+), 6 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index e5acb97..ccddb3a 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1925,20 +1925,28 @@ static bool kswapd_is_running(pg_data_t *pgdat) > > /* > * A zone's fragmentation score is the external fragmentation wrt to the > - * COMPACTION_HPAGE_ORDER scaled by the zone's size. It returns a value > - * in the range [0, 100]. > + * COMPACTION_HPAGE_ORDER. It returns a value in the range [0, 100]. > + */ > +static unsigned int fragmentation_score_zone(struct zone *zone) > +{ > + return extfrag_for_order(zone, COMPACTION_HPAGE_ORDER); > +} > + > +/* > + * A weighted zone's fragmentation score is the external fragmentation > + * wrt to the COMPACTION_HPAGE_ORDER scaled by the zone's size. It > + * returns a value in the range [0, 100]. > * > * The scaling factor ensures that proactive compaction focuses on larger > * zones like ZONE_NORMAL, rather than smaller, specialized zones like > * ZONE_DMA32. For smaller zones, the score value remains close to zero, > * and thus never exceeds the high threshold for proactive compaction. > */ > -static unsigned int fragmentation_score_zone(struct zone *zone) > +static unsigned int fragmentation_score_zone_weighted(struct zone *zone) > { > unsigned long score; > > - score = zone->present_pages * > - extfrag_for_order(zone, COMPACTION_HPAGE_ORDER); > + score = zone->present_pages * fragmentation_score_zone(zone); > return div64_ul(score, zone->zone_pgdat->node_present_pages + 1); > } > > @@ -1958,7 +1966,7 @@ static unsigned int fragmentation_score_node(pg_data_t *pgdat) > struct zone *zone; > > zone = &pgdat->node_zones[zoneid]; > - score += fragmentation_score_zone(zone); > + score += fragmentation_score_zone_weighted(zone); > } > > return score; >