Re: [RFC PATCH] MAINTAINERS: add mm ksm section

[David Hildenbrand <david@redhat.com>]

On 13.05.25 20:17, Lorenzo Stoakes wrote:
> On Tue, May 13, 2025 at 06:52:27PM +0200, David Hildenbrand wrote:
>> On 13.05.25 18:17, Lorenzo Stoakes wrote:
>>> As part of the ongoing efforts to sub-divide memory management
>>> maintainership and reviewership, establish a section for Kernel Samepage
>>> Merging (KSM) and add appropriate maintainers and reviewers.
>>>
>>> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>>> ---
>>>
>>> REVIEWERS NOTES:
>>>
>>> I took a look through git blame, past commits, etc. and came up with what
>>> seems to be a reasonable list of people here, if you don't feel you ought
>>> to be here, or if you feel anybody is missing (including yourself!) let me
>>> know :)
>>>
>>> David has kindly already agreed to be co-maintainer for this section.
>>>
>>>    MAINTAINERS | 15 +++++++++++++++
>>>    1 file changed, 15 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index 80aa09f2e735..5ea2020acf84 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -15567,6 +15567,21 @@ W:	http://www.linux-mm.org
>>>    T:	git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
>>>    F:	mm/gup.c
>>>
>>> +MEMORY MANAGEMENT - KSM (Kernel Samepage Merging)
>>> +M:	Andrew Morton <akpm@linux-foundation.org>
>>> +M:	David Hildenbrand <david@redhat.com>
>>> +R:	xu xin <xu.xin16@zte.com.cn>
>>> +R:	Chengming Zhou <chengming.zhou@linux.dev>
>>
>> I don't see a single RB from Chengming Zhou, and a single one from xu xin
>> ... :)
> 
> Yeah sorry this is fuzzy but git blame mm/ksm.c for 2025 gives you _very little_
> activity in general, a series fro Xu and a series from yourself :) Xu's series
> was... acked by you :P

Yes, 2025 so far had little activity (fortunately).

> 
> Equally with Chengming based on other files listed here, I went and checked to
> see if there were substantive series as a sort of 'fuzzy matcher' which might
> imply a review interest here, and see there did seem to be some.
> 
> But obviously if anybody feels any entry here is inappropriate, or on the other
> hand anybody was missed off, more than happy to rectify on the un-RFC!

I guess my point is, as a submitter you expect that people that are 
listed under R: that you are supposed to CC would actually ... review? :D

In that case, I would prefer to have actual reviewers there. If there 
are none, then there should be none listed.

Of course, If Xu and Chengming do *want* to actively review KSM code 
changes, I would be more than happy to list them.

-- 
Cheers,

David / dhildenb