linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Bixuan Cui <cuibixuan@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mm/mmap_lock: fix warning when CONFIG_TRACING is not defined
Date: Mon, 31 May 2021 11:34:19 +0800	[thread overview]
Message-ID: <ae21b203-0f31-7535-ef1b-9c5edd06fbc8@huawei.com> (raw)
In-Reply-To: <YLRDtBCPAYajOSqa@casper.infradead.org>



On 2021/5/31 10:02, Matthew Wilcox wrote:
>> Fix the warning: [-Wunused-function]
>> mm/mmap_lock.c:157:20: warning: ‘get_mm_memcg_path’ defined but not used
>>  static const char *get_mm_memcg_path(struct mm_struct *mm)
>>                     ^~~~~~~~~~~~~~~~~
> That seems like the wrong way to fix the warning.  Why not put it
> under an appropriate ifdef?
It's better than me, I will send a new patch.

Thanks
Bixuan Cui

> 


      reply	other threads:[~2021-05-31  3:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31  1:55 Bixuan Cui
2021-05-31  2:02 ` Matthew Wilcox
2021-05-31  3:34   ` Bixuan Cui [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae21b203-0f31-7535-ef1b-9c5edd06fbc8@huawei.com \
    --to=cuibixuan@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox