From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3806ED68BDA for ; Fri, 15 Nov 2024 21:34:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9E7C8D0017; Fri, 15 Nov 2024 16:34:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B24E86B00D3; Fri, 15 Nov 2024 16:34:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 978F88D0017; Fri, 15 Nov 2024 16:34:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 755666B00D2 for ; Fri, 15 Nov 2024 16:34:52 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 347D11A03D1 for ; Fri, 15 Nov 2024 21:34:52 +0000 (UTC) X-FDA: 82789632660.06.89CE81D Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf15.hostedemail.com (Postfix) with ESMTP id 979ACA000E for ; Fri, 15 Nov 2024 21:34:03 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b="Xurk/K9N"; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf15.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731706426; a=rsa-sha256; cv=none; b=fHQOhlWBwZtyas519cMMK6DVhYuzduMtz8W4muLgjkj7GgzT8x4j1e4qRlhhklk11JZ/bP n0v+egPL14aiZYlpgH2oF/9blsXqSccR2AVjRfjCiYWfPwOYRLvtyrQbOHx1MoohnDmYTY 50VvKTaQAMFmAToM+FUIZSevEGfcimI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b="Xurk/K9N"; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf15.hostedemail.com: domain of eahariha@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=eahariha@linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731706426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OEAxYqndmV97fB2t7JocLL7u1S4ql6E8JdtDlfM98mA=; b=assmcAVkCdlOLD98J6I35iUpyowxbp8IT9NWooxJIw9/+ZpZ0oRJwg6ATFfTVR1ziwrHu2 RHREuM5En2p59exlq6neoVtcrwtNhtDcrKlCHTt3N5tfrPpTMAp6hcuRTfyokXeybvGOsN 1wSjVflOo/uF2stFgdZ+6YCteoA6ZWM= Received: from [192.168.35.166] (c-73-118-245-227.hsd1.wa.comcast.net [73.118.245.227]) by linux.microsoft.com (Postfix) with ESMTPSA id 684CD2064AE8; Fri, 15 Nov 2024 13:34:46 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 684CD2064AE8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1731706489; bh=OEAxYqndmV97fB2t7JocLL7u1S4ql6E8JdtDlfM98mA=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Xurk/K9NZ4Pt7R0qwaS9VSYSKCTMSaNp/aapEsQZCtIT74ft5tvctXWuFivs3Zswx hrelPOn+ppZ3FOsJiI+79MeaWo7lX97CMgyLO8+gyOebFfO+/iJc5GjxBT3U1ILKzl NFamFr9+2AnMiAp4lQnkRWbNDRlCI9FqXsyeg14c= Message-ID: Date: Fri, 15 Nov 2024 13:34:46 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: eahariha@linux.microsoft.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen , Michael Kelley , Thomas Gleixner , Luiz Augusto von Dentz Subject: Re: [PATCH 22/22] jiffies: Define secs_to_jiffies() To: Jeff Johnson , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan References: <20241115-converge-secs-to-jiffies-v1-0-19aadc34941b@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v1-22-19aadc34941b@linux.microsoft.com> Content-Language: en-US From: Easwar Hariharan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 979ACA000E X-Rspamd-Server: rspam11 X-Stat-Signature: 4749ao3zz3onkk4w3pwjpjgc3paduea7 X-HE-Tag: 1731706443-216834 X-HE-Meta: U2FsdGVkX18xbzOIquj8EPJf28VdCD2jf14si4VQGIK2Ko/nhHxan3A+TssZjCBty4LZSmXgXyeRbyQ5s/r+obV9d/d7fLORETlu3GDMJK0a6zXxp97dYgdv2N0b4ugQx6dHtXZwa5xWWU6UhipBaeLn7wOMqiNgmdSH9eZEOhkBX6NHrF320SPm8sm41D7Zywbe1AjYvX+Q6XLwy694ttzv/Nlx1BKGriOwf+hyQsm7yjKDIEB2C0DMbxI8qHiNbQJU9bgi27/8hxaF2y6O12cxZkzcWoCD8Q6PgQMlu9TyRN5vsxA4L3B9Wk+4nb7uZ5RMoxGW0PyD582w3AOaSsNfDXl/I+JtDgkR0j2yOBZjsrkGlgtaVnDuD/5/56cd5QaLJ6yi7upCU3nDorCCf1V2IKIGny7hbFSHR+v7JJKNGua4P5gCaKdiWW75FFNOTnfqrpkfjODj0CBdz87UZ8bDwJgrYAoFppvg9rs1P4fQpNi2GxRJTr+wpfF3pJKKVhyzICbllUE6oTobwUaRMIMjuuJkB/BY0IteXjivF2L5TUrkLTBPP3DBg3QXIhcSQCyBCVMoE0F9DXJg7lqtjOIg1bFwDbnDxQqErNs8SI8ke5njusGYwqVxE6/5bfzuDvgeB5OwPjvPpnwooJYBhAftzWVKTAyAHUq48QHJDRKN4uEf60sIaGqKwTxv9lc/3eO5oYStv5YEBt437AjbZz0X61Bh2Pr16fVT+9YavAfrTJRrtc6Sr5kkcfKvV2gQPwCq41f8fUusWPCnk060Du586xzzWwkThMyF58SsUeuccPG7/wRLPacwLXrnpWEgBjzqEdKP6QjqFx1BhsrLJf9PB4Ah1LBUtv/pVcklLquW5J//QzbIYQjkFObSBmcZyroq1ya/cA2O5ShWuSw7u3tWfBNor9U0uzaFqXzYgzm2u3nN+EE8f8FIloLJGIN13v96uDevx/ihbKFHhfE Y8FJgpZV LmNT5FPoC53GPf7LF+YtwICklMhMFGWr5NyUnru6TIT6Ew5Sqiv2FpELJprngm5D91l/jngTisAIy+oLgM4daCLbQmMpCiidiIffZ0Q8iJQV49wt2CogAJAYR80bgatT64Q0MhkoggHXrcELiWnKXLdJbcOjjHcJRYhBNVSvKF3j9D1TC9U5t7EGvau4pnLfwj+ZYO6EQ5iserjkyOtoHiSx823hImcx1SxKC/9fLl4Ygkm/d865F2TM3voD5jYnhDJ5c9hyZUwr17X9sBrlR9ECvcqliolCrcjCUivRa7yUbkVlszvnsCYxJgD+3n+YYzEz5aIwpsatu/H0TaQE4iqftjHbFhLII/irDzVUyCsf9+wAqwsxO5Net2iwDuBfczL6y3ipEyXasA7ilJrxT3v21Sv2Vki7nUkuKDIv3CFONJVy6fScLFHSOqglVXwYHwnFygIGEF6xeIQguZHNo2Q+MUCHA+0WCL2wGWcmpQpwpuaLusTvowE9cDE7UCQ1ZSuXL3oX6tygxAeMR6GQm4sbZoalctFRLUweFzdC5RwIrMRk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/2024 1:30 PM, Jeff Johnson wrote: > On 11/15/2024 1:22 PM, Easwar Hariharan wrote: >> secs_to_jiffies() is defined in hci_event.c and cannot be reused by >> other call sites. Hoist it into the core code to allow conversion of the >> ~1150 usages of msecs_to_jiffies() that either: >> >> - use a multiplier value of 1000 or equivalently MSEC_PER_SEC, or >> - have timeouts that are denominated in seconds (i.e. end in 000) >> >> It's implemented as a macro to allow usage in static initializers. >> >> This will also allow conversion of yet more sites that use (sec * HZ) >> directly, and improve their readability. >> >> Suggested-by: Michael Kelley >> Signed-off-by: Easwar Hariharan >> Signed-off-by: Thomas Gleixner >> Reviewed-by: Luiz Augusto von Dentz >> Link: https://lore.kernel.org/all/20241030-open-coded-timeouts-v3-1-9ba123facf88@linux.microsoft.com > > your signed-off-by should be last. > > and you have a patch ordering problem since this patch must come before all > the patches that use secs_to_jiffies(), otherwise this series cannot be bisected Thanks for the quick response, indeed this patch is already in tip[1], I pulled it in for testing the series but missed out on removing it before sending. Please review v2 that excludes this: https://lore.kernel.org/all/20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com/ [1]: https://git.kernel.org/tip/b35108a51cf7bab58d7eace1267d7965978bcdb8 Thanks, Easwar