From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E53AE74AC3 for ; Tue, 3 Dec 2024 19:07:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81CAC6B0083; Tue, 3 Dec 2024 14:07:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CCAE6B0085; Tue, 3 Dec 2024 14:07:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 61ED46B0088; Tue, 3 Dec 2024 14:07:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3D9F16B0083 for ; Tue, 3 Dec 2024 14:07:50 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 89941160C45 for ; Tue, 3 Dec 2024 19:07:49 +0000 (UTC) X-FDA: 82854581460.09.9D766D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 4327CC001E for ; Tue, 3 Dec 2024 19:07:41 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sk44vNLN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733252861; a=rsa-sha256; cv=none; b=WnJVJEbIeYT41Qz48Hp4b8vyjKCC0ccX7xgvAjQ66lBo4dmKd48cddYJDGUcct09N1v0fg 5QavdSHx/86q9IzHmr6ibrsz+g42MDWWVys2w2UVNycNoDhW/fPmno8LpiZhCx9QJLbhAw f3sjZ/ofa5vbCEetpf3HWqLs1/M/uio= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sk44vNLN; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733252861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qp8qIC8+SbNjtJ/vD3Mc/pgGXMGuySIroHQBH4DmWNM=; b=zhoQReIK0MsnCMYrcKLuLDTiU7O6k+0GEWe8ZmA8nuqeqW6mnGnt+ozMhq8WEuop4Zjr4s uBCB8ZukPjskgKosBgj3HNZ5xyokkZoBDSWIycZRKeVD8CQ8KEjoDAwgsMP0f9XzLFm2l+ YTTOL+PcAwcQKPClnCAyESME69Auduo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733252866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qp8qIC8+SbNjtJ/vD3Mc/pgGXMGuySIroHQBH4DmWNM=; b=Sk44vNLNlYJDHTbnJMOqLt+Aq8pVdu9JVrNsfwSnzEW5swbCYBWTAFcnbGw7Qj8Bstjreg x3G6A65NC4lDOHT7e4kqmIZwaLNvHnkaUvgSpWkk/7twRJTSWHcovrnyiSoSDtJIq99vRe 1Ymt03/H88JfCpJPXvKgW7lQe4TDMmQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-BVn10JPAOt-KK6OuisohpQ-1; Tue, 03 Dec 2024 14:07:42 -0500 X-MC-Unique: BVn10JPAOt-KK6OuisohpQ-1 X-Mimecast-MFC-AGG-ID: BVn10JPAOt-KK6OuisohpQ Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-385dcae001fso2438192f8f.1 for ; Tue, 03 Dec 2024 11:07:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733252860; x=1733857660; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qp8qIC8+SbNjtJ/vD3Mc/pgGXMGuySIroHQBH4DmWNM=; b=NNTidfswVQSqCEiP9HRexba29QH1vrxQpzXLUKIAFX4jRzacYxV6detl6xbzJ0THte ilJMdg6fehSvgJqkfIGx9nRoJSWdT2foUjpb86/PNomExlwHCOQ5RF4/GYPWaojLkrZS GW9oXXQUn+tBDlDFk0GxS5dgORUAP9X0h2Jq7Q2x6mz0H3jClRGt1s9hFWBuNmz9z6v0 fbwh0shH67c3sKRN7XneN7K3CexUvkafKI3+IQDn7iXfVWtCtI5+2P7dRThA6XKiEXEs CIRugCauzuEtuqWqWFdvv5yIhK5T/SVMr1Ohp7/WYx9w/Wk5rWSfHMp4cc53/KzasxbG yDCA== X-Forwarded-Encrypted: i=1; AJvYcCU5QBpngzuXlzgGmFsrOPzv4XVXgmwrnbm/byAxMq90mH7xEO2Af3xvzqa2NgQRv9nATdevj62FYQ==@kvack.org X-Gm-Message-State: AOJu0Yxxdbqjxd1qufD6ECxrh6pLh33+jFv1AqIH+oWv8ad7klqUxsG8 aOeVN/ZyDo35vcYqYTGx3pfuDoAzgumd/n3Y4SbKDNq+Dwp1vzEP9ivYKbEmS95dfp2I6RQj4LM xAO8uGF7IRWzSqZRzKUYE5qSj1txdc5xzx07b1Bu3BSiH/zCt X-Gm-Gg: ASbGncvRVehOtIxNG8x3vb7f1KfPu1yHwX6dLIJgtcmauYFesGYSLZ1oLxBPcRb9Qnk Y78hTPg9vrs2dbSdc6GqyVWiwv+hhZssFgW71K72laaj8VpNwZMXf/ldG6stoX2bIfFPzeCUqPa jNZ0wztPgNaE7Z3g1lMZn6qxXqbKxrc/iKp5NJuQctPnd/GDefJup+1xgRifo5KQn0lkzxZE2Pg jJXb9jWWGGmvzowTK/QXVKShtoW3aXMKJTf6i1zbQFTRwEd0bnUyQ3jshpSGzjBXKQJBeimssgn ulDte6gfHsGLHTRy0+5KOpK3Qa9b7Pyai2Q+l8hCnquQQcCcZpMhJouFCi9W0zyJzUXyljnRo95 zaA== X-Received: by 2002:a05:600c:1c1d:b0:434:932b:a44c with SMTP id 5b1f17b1804b1-434d3fe339emr12878635e9.27.1733252860304; Tue, 03 Dec 2024 11:07:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEzqV5rcPa1XB7yoDaMRtuRh1kpD7s5D32r4FS5ciVaVbd7QdQZuGmrecP2reRzXahF4Ztg4g== X-Received: by 2002:a05:600c:1c1d:b0:434:932b:a44c with SMTP id 5b1f17b1804b1-434d3fe339emr12878455e9.27.1733252859940; Tue, 03 Dec 2024 11:07:39 -0800 (PST) Received: from ?IPV6:2003:cb:c746:1b00:fd9e:c26c:c552:1de7? (p200300cbc7461b00fd9ec26cc5521de7.dip0.t-ipconnect.de. [2003:cb:c746:1b00:fd9e:c26c:c552:1de7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385e13e8eadsm12068257f8f.28.2024.12.03.11.07.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 11:07:38 -0800 (PST) Message-ID: Date: Tue, 3 Dec 2024 20:07:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v2 4/6] mm/page_alloc: sort out the alloc_contig_range() gfp flags mess To: Zi Yan , Vlastimil Babka Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Oscar Salvador , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-5-david@redhat.com> <96c92857-4850-4f85-9474-ac193c5ea48c@redhat.com> <04c1d28e-bbea-4499-9a6d-770f9ca53ba9@suse.cz> <498871B1-D26C-4934-8E89-C6C8ECE8872A@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <498871B1-D26C-4934-8E89-C6C8ECE8872A@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ndmjFEejwZ4djrJsSd3_E0y1jmC-DVx3cFty9iIRkBU_1733252860 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4327CC001E X-Stat-Signature: qdfkmhpowc33uz7gckwt5orr9tbfscko X-HE-Tag: 1733252861-664537 X-HE-Meta: U2FsdGVkX19yaeVIhwnOoSXKH50GzopJlmFv2NA1Prdqc2IG92GRwv2ytU75+Hljnrk/WAQNo+OpI/d3/igzIyKi8bZxyBnl6FBCLsGe5dPtzLP8IpXcOvSa0H/s6YY0gSHGy2GwFP79prcQlpgRIQC8vuhoa00ccfXJ+7u824xw4oYatGaFB8mXbvJYOoA3W2dGbPppuNG4xCr4Ba4bW56aX+AXes2+SiQt8fIxMoqqkoE4GFBKQckfB30Ddbb7cex6VoPt/E8QEXPwhXoe3pwgp690v73tzNpAg+XQFhhycNA2fzQbQFyK243zbOVFDwH99BoccYHgXI0nolL7WWlvfxvH6+BPWl3qcJwFHYeJH76ynnuePIg3zkwbPvZNtYvtbDEQkjLrI8MoskmqlZWjAq5+QHl4PgITf8ZVzNFR15CmjuKnV2zjn+RoQPeKoFUXGFNElbvLQ7hel5tJ76yN3pm94aMG4awTQcQ4brUqLeCUY2d3HYFwI6V33H2KhkQuL93w/6ZWZ8eGBPJLzqdyrfFyvJKsTvaHEHyBYAoaaFVkYiXsMPhvoDNhfU0Q64y46FmfcznL0MJzQQcVN4IymMGwwvG2J2DQkDa4OW7OYEKkUeqQVWHv8fcCqqhRCnipLFindcKKNwuQTkJsC5VUkj0vJexE5CaNZTjoUSjdv91r45hSg5Zh6wAVm4mqBVuBK6PsG5I3LB8Sqzj3QB6qFTvwM/+LXnXUOHu9OnDyAIyJhojQU5H0kz0pCrZ4GyzUsHd8bRyaYNwMqYDvPP6vSBVFGziDpi4UnGr2gHzNTOh6OS84aDX7WHooboXCWlRR6KZE8n8CwN4nUcuKV5lHMCYr2Z9UZclEhWtaO8rhctyvRIUho7Go0G9IhsjUfYNyvDmUyWsJfXYjxZ1nCdLyVSiH4l/i2/JoyCIywp/Lf/VmEez5gksQcdn2RC4xl7QGbg0dZdIK3+n/4O3 pTH38S2f MDn9uiQAfoLNj2RcbaACe9RX6nyYxjE5I6KXpYay6784YBO2K7PkHLMfTdMac7kSLEvvA3iPONtip/3TEZIZavz+ak7OGS0xqcRi3Xe4aAqUsBvyvvla9C7wXbhg98Omxt6IJo881chSVcqRxC7MYewsbnfdsGpMBMq96K7NrQ5yvEcHo41PhoeceORif6vKIRZqcOqRrDfL2XfW4NekiNwKHUlH61AwLolrJ91mW+bDkTeFp1V+Tr02CgGZoZX8pka3ffOe/VqCd0I9OrxmF1OZHqvUEkdqkVVvJvZk/SIDbRZ7fsobz7txpsTpXPehZAhpwU2UQon+JWfWDvBPlM3CwMkH148CZjySZTG5lFwsQ1W1ppuLeCRy3qmKGH/2T1ah6rxxW2X/4G/Sa8g9UE+9iBinzOy+19emC7rA0nBYlVPiuNSbuxpw8bYrOIpK0Emgwczj1E1eHpsMdQquwASt12ONS57mj5rl7OFO2QECrHFacCFMXIifbhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.12.24 16:49, Zi Yan wrote: > On 3 Dec 2024, at 9:24, Vlastimil Babka wrote: > >> On 12/3/24 15:12, David Hildenbrand wrote: >>> On 03.12.24 14:55, Vlastimil Babka wrote: >>>> On 12/3/24 10:47, David Hildenbrand wrote: >>>>> It's all a bit complicated for alloc_contig_range(). For example, we don't >>>>> support many flags, so let's start bailing out on unsupported >>>>> ones -- ignoring the placement hints, as we are already given the range >>>>> to allocate. >>>>> >>>>> While we currently set cc.gfp_mask, in __alloc_contig_migrate_range() we >>>>> simply create yet another GFP mask whereby we ignore the reclaim flags >>>>> specify by the caller. That looks very inconsistent. >>>>> >>>>> Let's clean it up, constructing the gfp flags used for >>>>> compaction/migration exactly once. Update the documentation of the >>>>> gfp_mask parameter for alloc_contig_range() and alloc_contig_pages(). >>>>> >>>>> Acked-by: Zi Yan >>>>> Signed-off-by: David Hildenbrand >>>> >>>> Reviewed-by: Vlastimil Babka >>>> >>>>> + /* >>>>> + * Flags to control page compaction/migration/reclaim, to free up our >>>>> + * page range. Migratable pages are movable, __GFP_MOVABLE is implied >>>>> + * for them. >>>>> + * >>>>> + * Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set, >>>>> + * keep doing that to not degrade callers. >>>>> + */ >>>> >>>> Wonder if we could revisit that eventually. Why limit migration targets by >>>> cpuset via __GFP_HARDWALL if we were not called with __GFP_HARDWALL? And why >>>> weaken the attempts with __GFP_RETRY_MAYFAIL if we didn't specify it? >>> >>> See below. >>> >>>> >>>> Unless I'm missing something, cc->gfp is only checked for __GFP_FS and >>>> __GFP_NOWARN in few places, so it's mostly migration_target_control the >>>> callers could meaningfully influence. >>> >>> Note the fist change in the file, where we now use the mask instead of coming up >>> with another one out of the blue. :) >> >> I know. What I wanted to say - cc->gfp is on its own only checked in few >> places, but now since we also translate it to migration_target_control's >> gfp_mask, it's mostly that part the caller might influence with the passed >> flags. But we still impose own additions to it, limiting that influence. >> >>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>> index ce7589a4ec01..54594cc4f650 100644 >>> --- a/mm/page_alloc.c >>> +++ b/mm/page_alloc.c >>> @@ -6294,7 +6294,7 @@ static int __alloc_contig_migrate_range(struct compact_control *cc, >>> int ret = 0; >>> struct migration_target_control mtc = { >>> .nid = zone_to_nid(cc->zone), >>> - .gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL, >>> + .gfp_mask = cc->gfp_mask, >>> .reason = MR_CONTIG_RANGE, >>> }; >>> >>> GFP_USER contains __GFP_HARDWALL. I am not sure if that matters here, but >> >> Yeah wonder if GFP_USER was used specifically for that part, or just randomly :) >> >>> likely the thing we are assuming here is that we are migrating a page, and >>> usually, these are user allocation (except maybe balloon and some other non-lru >>> movable things). >> >> Yeah and user allocations obey cpuset and mempolicies etc. But these are >> likely somebody elses allocations that were done according to their >> policies. With our migration we might be actually violating those, which >> probably can't be helped (is at least migration within the same node >> preferred? hmm). But it doesn't seem to me that our caller's restrictions >> (if those exist, would be enforced by __GFP_HARDWALL) are that relevant for >> somebody else's pages? > > Yeah, I was wondering why current_gfp_context() is used to adjust gfp_mask, > since current context might not be relevant. But I see it is used in > the original code, so I did not ask. If current context is irrelevant w.r.t > the to-be-migrated pages, should current_gfp_context() part be removed? Please see how current_gfp_context() is only concerned (excluding the __GFP_MOVABLE thing we unconditionally set ...) about reclaim flags. This part make absolute sense to respect here. So that is something different than __GFP_HARDWALL that *we so far unconditionally set* and is not a "reclaim" flag. -- Cheers, David / dhildenb