From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45135CD128A for ; Thu, 11 Apr 2024 11:45:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B682D6B0089; Thu, 11 Apr 2024 07:45:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF06B6B008A; Thu, 11 Apr 2024 07:45:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9906D6B008C; Thu, 11 Apr 2024 07:45:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 791FF6B0089 for ; Thu, 11 Apr 2024 07:45:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0950CA15FA for ; Thu, 11 Apr 2024 11:45:21 +0000 (UTC) X-FDA: 81997070442.15.B1F37D7 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf29.hostedemail.com (Postfix) with ESMTP id 22C4512001E for ; Thu, 11 Apr 2024 11:45:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h5OqEYQa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712835919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aHrjvGOl5lMV3nAUz9GjM2jU/th5hsop1Os5mXlVWog=; b=OwPLBqhdPJ3AU/uDTwIl5fDY4RknOvv7F0z7Of/1ep8YOElnq8UiS05M8OKKzAjdddqHnZ ip2Q67GjBzmtUb2y2SxPlePUDCJmZxQrNvELCJWfZmhcsN9FN63wE7R98aye+Ayt0La9qm ywRQLo5uF+BEywHS0GDhTlvkyPtkomg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h5OqEYQa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712835919; a=rsa-sha256; cv=none; b=Q4dIBIhSjwfd/6FIjY/iEW9JiUicni4wFq0HjJnN0DKlQCLYfjY6h0eRCfWJ5sTitWVIbs +WTZmET+5BN/CZwzrmSoh3XlB2Gs7Ot/WFM/z+h2AOQmDd/TxWpNJDPC2FyvwvzmGeR7pi Ve5unsDW+X2gjCenZepZFF988PLRy/I= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6ece8991654so6932940b3a.3 for ; Thu, 11 Apr 2024 04:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712835918; x=1713440718; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=aHrjvGOl5lMV3nAUz9GjM2jU/th5hsop1Os5mXlVWog=; b=h5OqEYQaRAkme0wjVnvQvnXwDX9SzSQQyfnGBNqaXwktcoDC5Ov4qLUEjUPXs5iRkM WJWGEyyTIIRoG54988ewcorW0K0BnwE/sD8LQ26NUZ/TLuCKeWJ4hPKZf5JZHiBDcoDz YXGs5X6o7tBwgJ9Bu870NSpk/KM98yDYY52vtUPeA4v5y4W4mixZCYuCGzcGyZxw807h f0zzlT0tbvDCtg3IWX8JEPCf11iPzgyUhtwjfnZvuvxtT9F2efZ02rTk/RGhbDcuyepR 669LJ4Bh7qFUTZlLbko+vXrbCmuYyzni4TxawIQSIE/4P+F0UAGDWlYQDsB78+lXhYtK 1c4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712835918; x=1713440718; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aHrjvGOl5lMV3nAUz9GjM2jU/th5hsop1Os5mXlVWog=; b=R/lWcnL5A4emhw10aJesO70+yPj4Cw4FIJwCWPfXiVaIAj9qpN7Z0/lGPw7IgdKpUW kYb6TeW0AJmewg4cTvrgjsyLCOQo2HJ9Kv5+D+LgqGxoE1NxLGaGps6xj8eM+m8vO3pY KLJmaa6lYPm0WD55hZx6+JcBp52yShFVnAc3UJjU6yeLvsfIdVXPwiDBvZtKM+qeHcy7 QSfxZSXg3NuC98nzB5sf+RPiTeXYm/2ewbUgvmi3J32ICk4hMJFJTl/xWFOQnGY2ubfi rQgGv9AmceInTvAjzCtd0bPho5BBHKP2Jz5M6hzYQijWvtnU7/ymz/vqbFk07zVKKA4d c9lA== X-Forwarded-Encrypted: i=1; AJvYcCVmMW5XnDMDS3JTbpzv7mX4PY473/GigYRlF8O5MHFNsxY7Ly8Fz4A/JHyWLk1eGHxW5MLwXaW96pSTZwMEUkmsZXg= X-Gm-Message-State: AOJu0YyHeqYHSpxoc++ZeEvj9Tw5mCRilAM2se6x+343m6EJnIwwFnaK x6yegEYW+Z56A3p5fCBuk1nWkQTRSkU2FJwSNbEHMSfDSlKHm/tl X-Google-Smtp-Source: AGHT+IGqtlCT5h6Fb4Ji6MnmrIGfQLghE3ZiR7z51UNRjrRBmS90R3cXYfUsPRotYq+rh4nihj1pTw== X-Received: by 2002:a05:6a00:244f:b0:6ea:8b0c:584 with SMTP id d15-20020a056a00244f00b006ea8b0c0584mr6028779pfj.9.1712835917996; Thu, 11 Apr 2024 04:45:17 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id hq6-20020a056a00680600b006ed14fed3a5sm1019760pfb.154.2024.04.11.04.45.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 04:45:17 -0700 (PDT) Message-ID: Date: Thu, 11 Apr 2024 19:45:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/10] transfer page to folio in KSM To: David Hildenbrand , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, zik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, hughd@google.com, chrisw@sous-sol.org References: <20240411061713.1847574-1-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 22C4512001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nftz9brozoqw9f34zwsogf1cq4zjzhdw X-HE-Tag: 1712835918-515672 X-HE-Meta: U2FsdGVkX1/APFsvSykfkk0tw2OZ+oUVMRopvfhLteIn4l8/Omi/8NpcnDui+e1hqL7etChJnUQlFMUaejpve5iNTeS2Te3+tX2fnHcn8/WTYYkZBCJdju6CGZ8C46Qt/kyUmK5HKs227YtG4wcbnZd0SFcVSOVd7C8ea2Rm55DJ9LW6REkGOnnCQvM9P73anP7ZKNfQ0S/q5hA/Fm/7ycxcwefIQcUb3meSwbQDjE8Nj1usXnjjTIwbpuNACTM9lBHmNtOxPfWSyaQM19mZiFKUOcJG283OKbd7TY3XBbypp/RysBzvGeIev93Y4ht9cHZ71rq5mQdZYQPgL5B4lKj3Fo+6RTcUZ6C47NycfCpeGkuukpmweLvIixHzDku/q9zFX79DeIlN8LQlfldSU9Yz8RU8WMbq/li8CAUxFdE289DqDasDAa2hy+ccni6K8i+PonJPitwNYafmjdae6qrbXAfEC5heDZ5t2VL6OMRF9GPWCX9uI6MrbG7qQxdVZ/lc609Q4QT8mSz9cg5AGtbR6R3AkQ4c0Ye3Uay0S4jH4UXMRCu2X/8AaIx2Of2+LPEIB6VEmBRf36qrWF99B0EcZjIdsh5uKBR3nPo5rAYNPNpszme2HMgn7x+A1Yx6yYG2C4y0CjwFNYFkbwwkdwvZL9kIJPxb7IdRRIl1erML2sJ0Kqfd4fxbuNkkTgv5myg4+lMV1QfQPHhs42ZYs5xLGTOJlGfO6LX5r9ax/eWDsEX9hEnbMKcX4dfJoRtZ1OIjp4Xoq4JxW3RvVfjghqiGOcrcYdaD2kEbtUShK8vtZCw6D7A53I5tsO8RIyKahpDhxFhTntqRepwuiMkWaLlC6lp1PJAKnnlOlYUSzcbOXz223S7M4vu1pi1LkmPeUfXwe6KbDwcw5JMQa6LB+X8ZX5AgQy9Ak9Qx8cvHcNGaqjM4w0h5N4V2MRxOgKlKqPsIi+C0B8MZ1LzRECw +lB+Ayy2 v+y9Vx3M9r7+jlSMx6bMNPH/8psK3/Rv/AIrYAwsRiyTQjkpIrZJkxRWVlH3dklvIMLMNRUmYVYQiaC+uVpptt5TpqbmDan4awhYOUyV/4Y3V9ncAC7dRMI0QPhWXc9N5k6j/23j9LqklEbD6nO1UkSw/o4xMoZvRy6TUGR431mN6x8oA0Xo3mEfloAlu34c6kjoTOIQ8XHcUDj9cBnrtTrstO0xER1R9h27dYFBJrPoAB7TxLhYk5BtufsdjnBq3UZVOvhi7YX4WuoCv9MoQXXCn2Pg+pgpCy+q6hmrAIdKCb4yqbWW5MB02BvzN4Nb9/B++e17aDoaW0x9w78pFSwprhRXzl6BGsWEpS73ffA7VfDaYRhUVWijv3Yem6kTuJYN1VVIz/bp4RBlrkwJRbe3T9c/i3RBDUCIO760ABhSRc24R77Czym398uHlgBgVlR+Mbr95rnDd+W2wU6szPwYDZQ+RrS9SQp5bmnG7iX9XmCSqotsw0ZvZ0RReGoJeL4dCRQ4fHNFTppcL+fPygFTRHkGkEsgTw5kVeBgg82uwv4U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000518, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/11/24 3:55 PM, David Hildenbrand wrote: > On 11.04.24 08:17, alexs@kernel.org wrote: >> From: "Alex Shi (tencent)" >> >> This is the first part of page to folio transfer on KSM. Since only >> single page could be stored in KSM, we could safely transfer stable tree >> pages to folios. >> This patchset could reduce ksm.o 57kbytes from 2541776 bytes on latest >> akpm/mm-stable branch with CONFIG_DEBUG_VM enabled. It pass the KSM testing >> in LTP and kernel selftest. > > Just a nit (no need to address for this patch set): "transfer page to folio" sounds very misleading to me. I'm not a native speaker, but I'd have called this patch set > > "mm/ksm: convert some KSM code to use folios" > > It's rather code conversion/transformation, not a transfer. > > But again, I'm not a native speaker ... > Uh, me neither. but sounds you're right. I will take care this next time. Thanks Alex