From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 344BAC433DF for ; Mon, 18 May 2020 02:29:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C07BD20758 for ; Mon, 18 May 2020 02:29:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C07BD20758 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2231E900003; Sun, 17 May 2020 22:29:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AD14900002; Sun, 17 May 2020 22:29:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0742E900003; Sun, 17 May 2020 22:29:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id DEB65900002 for ; Sun, 17 May 2020 22:29:05 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 91A8140D7 for ; Mon, 18 May 2020 02:29:05 +0000 (UTC) X-FDA: 76828257450.21.talk07_898a3d92a3839 X-HE-Tag: talk07_898a3d92a3839 X-Filterd-Recvd-Size: 1711 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 18 May 2020 02:29:05 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0EC6631B; Sun, 17 May 2020 19:29:04 -0700 (PDT) Received: from [10.163.74.67] (unknown [10.163.74.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7C7523F305; Sun, 17 May 2020 19:29:02 -0700 (PDT) Subject: Re: [PATCH] mm: Simplify calling a compound page destructor To: Matthew Wilcox , linux-mm@kvack.org, "Kirill A . Shutemov" , Andrew Morton References: <20200517105051.9352-1-willy@infradead.org> From: Anshuman Khandual Message-ID: Date: Mon, 18 May 2020 07:58:29 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200517105051.9352-1-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05/17/2020 04:20 PM, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > None of the three callers of get_compound_page_dtor() want to know > the value; they just want to call the function. Replace it with > destroy_compound_page() which calls the dtor for them. > > Signed-off-by: Matthew Wilcox (Oracle) Makes it simple and clean. Reviewed-by: Anshuman Khandual