From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87BECC433FE for ; Fri, 30 Sep 2022 08:47:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2488F8D0003; Fri, 30 Sep 2022 04:47:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F88F8D0001; Fri, 30 Sep 2022 04:47:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C1548D0003; Fri, 30 Sep 2022 04:47:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F17458D0001 for ; Fri, 30 Sep 2022 04:46:59 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BE24CABD45 for ; Fri, 30 Sep 2022 08:46:59 +0000 (UTC) X-FDA: 79968121758.22.9AA2530 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf04.hostedemail.com (Postfix) with ESMTP id 50E3940006 for ; Fri, 30 Sep 2022 08:46:59 +0000 (UTC) Received: by mail-pg1-f176.google.com with SMTP id e129so3600679pgc.9 for ; Fri, 30 Sep 2022 01:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=8hK7dYqCKStIL8sNiRk1FpqChl0J32g8Nhctqg2nLuU=; b=0tjV8GrNIcboxZN4wrH7rM15rjMbLej1jbDVZn20VtYLNd94oVs8Ee8H7+Ja75Egbn eTGagY4VmQjDZUY1at7dEC4QKmyxPYV883Lfw3mFEN6+0nfwAJHn+hyF4AL/jiHU8aVQ wM46ngsECs1F+RXc/M4v48VjBLAqpoAWeRjuBQFJ9F/2F8Lcw/fHYHpXuzEIAzrv0c/B E0vbYefd+CZ47jSUtCMnP0adCr3cz+qQxbdkbV9AhMtTI2QtnVNByShqp9PQjwIfi2nr 794otsl6AIoTr5szIeDhsdumZtzEtHjLmVUDSGNuOZ/BTc9467/MYPRdne+owNmq+11r pXxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=8hK7dYqCKStIL8sNiRk1FpqChl0J32g8Nhctqg2nLuU=; b=Y9Rt8LxhBSU4ebkbPU7BJ0FdbcHk64371tLOAZSNd8DmTruqHu3n1dXv9Xb6QZBRQG 3+1DxMV2os6S8wuNnyQ7zTclu/SYx2+qcOrsZpqGDCYr/NEZrqOHXHyN4KmLNKn/knSA hSCH/zyFG+BTcGbov1s3POYheEit4LoEaqVumIpeJJDLzPonJuyGz+O/cs9PClHN/LAG OxT/i9WlAjaZzXfiukVaMvhYtg3+vNjKHbFEMlhewaZ9FuI8B2D4xOU/t+pc4Dvk0iPR wisRet/yRx1zeifCw+uNnkL10S15jxZ/wqC+RwnZ5F0PTEjJETsmIFFurppoR2CRfyGh JhLg== X-Gm-Message-State: ACrzQf10tfCXg+dIYt5uB7uN6GiTgwMWn6MlwIaFJr0bCxFmZyEq0mfo TcZa4/iqWwmDBGvN7KIH9D61Gg== X-Google-Smtp-Source: AMsMyM5MsO7lJsf7zGV/70Gzqt+lyeK5x5cmUlNE18x3/SJYJwP6ccURIbPeCdRwNciVnzOezHod6g== X-Received: by 2002:a63:df18:0:b0:43c:dbdb:2f24 with SMTP id u24-20020a63df18000000b0043cdbdb2f24mr6512793pgg.226.1664527617903; Fri, 30 Sep 2022 01:46:57 -0700 (PDT) Received: from [10.4.189.225] ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id q12-20020a170902eb8c00b0016bf5557690sm1338450plg.4.2022.09.30.01.46.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 01:46:56 -0700 (PDT) Message-ID: Date: Fri, 30 Sep 2022 16:46:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v3 1/2] mm: use update_mmu_tlb() on the second thread Content-Language: en-US To: David Hildenbrand , akpm@linux-foundation.org, maobibo@loongson.cn, chenhuacai@loongson.cn, songmuchun@bytedance.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, chris@zankel.net, jcmvbkbc@gmail.com References: <20220929112318.32393-1-zhengqi.arch@bytedance.com> <20220929112318.32393-2-zhengqi.arch@bytedance.com> <0fecbcdc-7324-2d76-8452-b60b4638d074@redhat.com> <32a53a8f-f6f8-6efc-a5f6-a004ffab8c99@bytedance.com> <673e494c-eb91-470a-026b-59e414d0916e@redhat.com> From: Qi Zheng In-Reply-To: <673e494c-eb91-470a-026b-59e414d0916e@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664527619; a=rsa-sha256; cv=none; b=7Qvo6K+ZimwQ4TPEOfeWFF2vSwQNBHTe2xuiXjwKWw2T+qldg7A4EMv2q+tvH19LUV1Qax FaD+mSy3eN+aN6r94ZWnqXej86iPqT17CIcbK2D4j+KjXrCOssTHgtIY0Kz9+vxCymJFQy YCfQYJEMd5Y0gDtfRFL/F0QIWz3VykE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=0tjV8GrN; spf=pass (imf04.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664527619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8hK7dYqCKStIL8sNiRk1FpqChl0J32g8Nhctqg2nLuU=; b=XmMj+bzWszJfMMXlFanj4NUFRgJ3MJCZOobIoXYSEIZf+LhhbkyXG8iypa1ZZT0my7/P5x b6AOzMoXUKutSgKCiuu0pshh06YSnNpz/lVxpeBJlzun8wGX5uz9Wdyu9daLPfvaEjtIdl w8QU8s56YGvPs71dDpN1d0acXzLTpcc= X-Stat-Signature: 3u4mc554ys9ehnos1ami8rcg7jufd4no X-Rspamd-Queue-Id: 50E3940006 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=0tjV8GrN; spf=pass (imf04.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam01 X-HE-Tag: 1664527619-954223 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/30 16:44, David Hildenbrand wrote: > On 30.09.22 10:43, Qi Zheng wrote: >> >> >> On 2022/9/30 16:30, David Hildenbrand wrote: >>> On 29.09.22 13:23, Qi Zheng wrote: >>>> As message in commit 7df676974359 ("mm/memory.c: Update local TLB >>>> if PTE entry exists") said, we should update local TLB only on the >>>> second thread. So in the do_anonymous_page() here, we should use >>>> update_mmu_tlb() instead of update_mmu_cache() on the second thread. >>>> >>> >>> Maybe mention here "This only affects performance, but not correctness." >> >> Oh, this is better. Hi Andrew, do I need to resend the v4? >> > > I assume he can squash it, most probably no need to resend. :) Got it. Both are fine for me. :) > -- Thanks, Qi