From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0832AD0BB79 for ; Thu, 24 Oct 2024 09:05:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EDA36B0085; Thu, 24 Oct 2024 05:05:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69E496B0088; Thu, 24 Oct 2024 05:05:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5667B6B0089; Thu, 24 Oct 2024 05:05:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3774B6B0085 for ; Thu, 24 Oct 2024 05:05:44 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3EAF612112F for ; Thu, 24 Oct 2024 09:05:27 +0000 (UTC) X-FDA: 82707912294.06.AC733DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id CD7C11A0022 for ; Thu, 24 Oct 2024 09:05:18 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BCUu+1mm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of pabeni@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729760702; a=rsa-sha256; cv=none; b=H8PG865/1C7GbIIMzHanBfDfS3nRtMM0x1tUbq0/164GotwGack+f1VieccPTLNc5daZOl OAsOagUrtox0+9z0uDouMVMSOlGqKbymTRuIowauBXfapq4yjLXjiTLLjLFAM/JCmvCscz kVFNDdDyF15byKp0oIQMMVMom4vLovo= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BCUu+1mm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf19.hostedemail.com: domain of pabeni@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pabeni@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729760702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u70sIwyFm0suH4CDe5A/iIejFVl9J+uk9rhnPzF4Ntc=; b=rhuNzw6omkfdjPrIrRWkJaZGwm8lemKxX1qHVUh4Rl5UUk/QbqCJ0/isyvSiYLPVzhq9BL i13w5hsL0tjruIiI9t36VZo4CYXmLQaVoLc6JcAIaf9/a7oWM0hljyBNrBUZlH3pvwhAPm 4XA/5XZC4WMBtjgJqe8YKiS6KQi2fjU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729760740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u70sIwyFm0suH4CDe5A/iIejFVl9J+uk9rhnPzF4Ntc=; b=BCUu+1mmXCbiZChgVCkhFAOrsPrMPOhlIGcbm6m+NsIlhZ1GGp3lnffGMPTI1qyV3Wudpo 5lQ1JnrojjxC0g/30/Bzjab7P6uZVUfz1P/+yKhtJbblNUfuVnuaO8mimiZHnJV9pvruqX vAauG2ATHeb+CiUzv3w2Ew9Vug+1zhA= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-O66bYaWCMF2XtSfBXL3VjQ-1; Thu, 24 Oct 2024 05:05:37 -0400 X-MC-Unique: O66bYaWCMF2XtSfBXL3VjQ-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-539f7abe2e6so520524e87.1 for ; Thu, 24 Oct 2024 02:05:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729760736; x=1730365536; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u70sIwyFm0suH4CDe5A/iIejFVl9J+uk9rhnPzF4Ntc=; b=AeS5t4tO9cQNYXUXo44um4puEJ6MtyYkVJQuWGn2UuGzHS5TTov14t2mLKeG0VF3VZ qX5e9bn0u279uEVgiU4Zbc1ZsAM+nKZ6nezF13rdvSYapU6IGlqTPJc6P6LnFxPqi0YP q5TDMeie20ZdnrAiShlBbKh9pOVVrLiI1tm1f5KQiaG7rea7oOaegXEaUOdGl7BH02lG BPnlKwEE0gJ4ziwRdkA6Jcctc7z4OuRMrM+2xqiKgezaW1wT4EPmLmyWzgb7Yxpo3oTw lZ7tcG9LYdiXGZsVI34lZh9t3lk4/WgvncAtzZTx0A++0aSdzRoCLsNakUNkXVVA95h1 shCQ== X-Forwarded-Encrypted: i=1; AJvYcCVATdxh/CLfH09JPWHwI5sMluUxhfxntVI2nOPR9Wgwo0ltmz11wmx0QeQJ/mKt1pEzPAxxmqiT1Q==@kvack.org X-Gm-Message-State: AOJu0YwtnlNVAkBotbaWYyR5Kqh4yugwNrZ5knQOHssxtoauiizQlZAp ToO0fdLYCaxEm96szhcZF3spvmVSJU0AEA63tHz4mUb7ufFAYhFDbkSSx83aCkhonG1z2PbLTcd GMNYkArcR9P0r81OQoKgLtEydWbV357C2pDIczbclG0M/U27i X-Received: by 2002:a05:6512:2392:b0:539:f8cb:f5e3 with SMTP id 2adb3069b0e04-53b1a375b33mr2937454e87.48.1729760735840; Thu, 24 Oct 2024 02:05:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExoOpe615O7V0Vd9OGAHQxabxJ1jZDno5UnaeKOorq+8MwKq3jNe31QuxTpcKXM4fOXZjb5g== X-Received: by 2002:a05:6512:2392:b0:539:f8cb:f5e3 with SMTP id 2adb3069b0e04-53b1a375b33mr2937433e87.48.1729760735411; Thu, 24 Oct 2024 02:05:35 -0700 (PDT) Received: from ?IPV6:2a0d:3344:1b73:a910::f71? ([2a0d:3344:1b73:a910::f71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a4b26dsm10814443f8f.45.2024.10.24.02.05.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2024 02:05:34 -0700 (PDT) Message-ID: Date: Thu, 24 Oct 2024 11:05:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v22 00/14] Replace page_frag with page_frag_cache for sk_page_frag() To: Yunsheng Lin , Andrew Morton Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Eric Dumazet , Alexander Duyck , davem@davemloft.net, Yunsheng Lin , kuba@kernel.org, linux-mm@kvack.org References: <20241018105351.1960345-1-linyunsheng@huawei.com> <02d4971c-a906-44e8-b694-bd54a89cf671@gmail.com> From: Paolo Abeni In-Reply-To: <02d4971c-a906-44e8-b694-bd54a89cf671@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: per1xawhe6n5ayogb9qtmtkou8gwms39 X-Rspamd-Queue-Id: CD7C11A0022 X-Rspamd-Server: rspam02 X-HE-Tag: 1729760718-279816 X-HE-Meta: U2FsdGVkX18aeaIUvNk5SM3QvwHSxZChqxahq3sqCKvTsp9FWTlOO7fPU/XZoYQVco6Q20oaFQYIx7sOJr0qSArowzr57bmiXJnWVzrdOmwi/VdkPVsP0sXTANLZb1yo5pmWJ9hVTGDXvfQIaI9TacG273aQnp55eVIXHQ3mBjO4Pyv3gCi3DQBImtqEiFL+pUDzBlRI44PQQ+2qV6wXkTrmok0x5n+XJlZBIXI8VTFDpiKzL9l/eHAKMenXTfa85h6nvYYFz9uPA8v/9GHwEw12tB1OcqfOQt6m4mTQKF3V/mJ3mE+ezWm8tkIXwaMtcTI9TLI7Dx1UK7gbxbXDHLtlioqGQT/OMTWCHOsTRSfGnUchViYcuai8ntnYBahvu8f6UL/ISm/vTKzIM/jnOvcdt9hgZj2LYgU5N4ANnwUFfC4sdBf+/XKVT9126WWLl55fz/0F+YeNuBW9WwbPkwhg19g133LzQddo4O1nmiiWzQobR584eqVdm6bNsNiijayrvc3znWXIutEx8n76rJV5hlMCHaJ36Cbb1ktPGev6i7cFYkKf6W4oCrcLxiJNOp50az72TWuWlk94yfrkliKMa+nCh+NmqUuJLLUVPBOwnktYuEZAny0Ower4en7cVm6guTWCdg3qYZ5cHOrkqn3Ljy4tZiT1zAY4cA9fs+88HmAHT1+6UzeWJpXUANPXI0h59iH7tmXI7OFvs+zA06xY40Z0GK7whC0u6n7tysmyldYfuAblYrl6tn8VI5iLtKptiGDSwUjuQFPiRIJNKE6pt1oW8JYogFR/Gzo4FrP+EWNgtuPbaWSQt88BLYxG7rg4jBH7eTCvS8NjJKko8zWCZ4WxzJi8r+FoLb1X1gMjqem0Lki9YdyEZLqSADtWj2HdeCmldvmvDULM9Yp4/WOWO0P55Gig0D6osLp7vSSYRCx5beBSo2QxZ4aXBRvczsvyRshOkjtSgyFZwB/ ZCeSdg68 TyECVWbGfkosEonxzI/qnV/xH5e7ike81M+shBEQ590i0BCF32c4KW8Wy3+ogVwRnkd79NAl4cjUvxA2COfYwHtaYVVQfsE1POrYNPOhtTb2Y325twme648WVDwBTe1z3UM5wW8DDz6QLh7CopNyANqacooL74vUMkYcfLityAkKvG8r9ii1inNjHp+pmJvV0AEmJ6eXaS1XopAMh/iFbagM5P6f9aOl1i7LN5Np4grDHcYB32cjLD5021Bojbgbq7HXeL/iCiUDy3HhZIZudqdbhWn/iytkBvZA4rZrwYbAkppS1vVKU/AzYr2ovTFDLUCIDHnCZAAbnzCZ47mcSJPGxRlWXJlDrZgcqgj0FTr1wkHLIf0e16/BU4G3TVyLs6Cbkxu5B0WMP8tlo8VztNsYt5T79YU03Dk6S6zDMwjE8fMl9G85Yzb4nFPpGrSDsXTRTQ73zCtEhKrSSyBAPFLs/m/U5xYXj4cBDZc7FXDgMf8/3Wfhxj2sBJu8vcLekaxnZOihVzLG3MHSAJcsnyj6KNM6uBQaATjng X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, I just noted MM maintainer and ML was not CC on the cover-letter (but they were on the relevant patches), adding them now. On 10/19/24 10:27, Yunsheng Lin wrote: > On 10/19/2024 1:39 AM, Alexander Duyck wrote: >> So I still think this set should be split in half in order to make >> this easier to review. The ones I have provided a review-by for so far >> seem fine to me. I really think if you just submitted that batch first >> we can get that landed and let them stew in the kernel for a bit to >> make sure we didn't miss anything there. > > It makes sense to me too that it might be better to get those submitted > to get more testing if there is no more comment about it. > > I am guessing they should be targetting net-next tree to get more > testing as all the callers of page_frag API seem to be in the > networking, right? > > Hi, David, Jakub & Paolo > It would be good if those patches are just cherry-picked from this > patchset as those patches with 'Reviewed-by' tag seem to be applying > cleanly. Or any better suggestion here? We can cherry pick the patches from the posted series, applying the review tags as needed, but we need an explicit ack from the mm maintainer, given the mentioned patches touch mostly such code. I would like to avoid repeating a recent incident of unintentionally stepping on other subsystem toes. @Andrew: are you ok with the above plan? Thank you, Paolo