From: Paolo Abeni <pabeni@redhat.com>
To: Yunsheng Lin <yunshenglin0825@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>,
Eric Dumazet <edumazet@google.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
davem@davemloft.net, Yunsheng Lin <linyunsheng@huawei.com>,
kuba@kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH net-next v22 00/14] Replace page_frag with page_frag_cache for sk_page_frag()
Date: Thu, 24 Oct 2024 11:05:33 +0200 [thread overview]
Message-ID: <add10dd4-7f5d-4aa1-aa04-767590f944e0@redhat.com> (raw)
In-Reply-To: <02d4971c-a906-44e8-b694-bd54a89cf671@gmail.com>
Hi,
I just noted MM maintainer and ML was not CC on the cover-letter (but
they were on the relevant patches), adding them now.
On 10/19/24 10:27, Yunsheng Lin wrote:
> On 10/19/2024 1:39 AM, Alexander Duyck wrote:
>> So I still think this set should be split in half in order to make
>> this easier to review. The ones I have provided a review-by for so far
>> seem fine to me. I really think if you just submitted that batch first
>> we can get that landed and let them stew in the kernel for a bit to
>> make sure we didn't miss anything there.
>
> It makes sense to me too that it might be better to get those submitted
> to get more testing if there is no more comment about it.
>
> I am guessing they should be targetting net-next tree to get more
> testing as all the callers of page_frag API seem to be in the
> networking, right?
>
> Hi, David, Jakub & Paolo
> It would be good if those patches are just cherry-picked from this
> patchset as those patches with 'Reviewed-by' tag seem to be applying
> cleanly. Or any better suggestion here?
We can cherry pick the patches from the posted series, applying the
review tags as needed, but we need an explicit ack from the mm
maintainer, given the mentioned patches touch mostly such code.
I would like to avoid repeating a recent incident of unintentionally
stepping on other subsystem toes.
@Andrew: are you ok with the above plan?
Thank you,
Paolo
next prev parent reply other threads:[~2024-10-24 9:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241018105351.1960345-1-linyunsheng@huawei.com>
2024-10-18 10:53 ` [PATCH net-next v22 01/14] mm: page_frag: add a test module for page_frag Yunsheng Lin
2024-10-18 10:53 ` [PATCH net-next v22 02/14] mm: move the page fragment allocator from page_alloc into its own file Yunsheng Lin
2024-10-18 10:53 ` [PATCH net-next v22 03/14] mm: page_frag: use initial zero offset for page_frag_alloc_align() Yunsheng Lin
2024-10-18 10:53 ` [PATCH net-next v22 04/14] mm: page_frag: avoid caller accessing 'page_frag_cache' directly Yunsheng Lin
2024-10-18 10:53 ` [PATCH net-next v22 06/14] mm: page_frag: reuse existing space for 'size' and 'pfmemalloc' Yunsheng Lin
2024-10-18 16:43 ` Alexander Duyck
2024-10-18 10:53 ` [PATCH net-next v22 07/14] mm: page_frag: some minor refactoring before adding new API Yunsheng Lin
2024-10-18 17:26 ` Alexander Duyck
2024-10-19 8:29 ` Yunsheng Lin
2024-10-20 15:45 ` Alexander Duyck
2024-10-21 9:34 ` Yunsheng Lin
2024-10-18 10:53 ` [PATCH net-next v22 08/14] mm: page_frag: use __alloc_pages() to replace alloc_pages_node() Yunsheng Lin
2024-10-18 10:53 ` [PATCH net-next v22 10/14] mm: page_frag: introduce prepare/probe/commit API Yunsheng Lin
2024-10-18 18:03 ` Alexander Duyck
2024-10-19 8:33 ` Yunsheng Lin
2024-10-20 16:04 ` Alexander Duyck
2024-10-21 9:36 ` Yunsheng Lin
2024-10-18 10:53 ` [PATCH net-next v22 11/14] mm: page_frag: add testing for the newly added prepare API Yunsheng Lin
2024-10-18 10:53 ` [PATCH net-next v22 13/14] mm: page_frag: update documentation for page_frag Yunsheng Lin
2024-10-20 10:02 ` Bagas Sanjaya
2024-10-21 9:32 ` Yunsheng Lin
[not found] ` <CAKgT0Uft5Ga0ub_Fj6nonV6E0hRYcej8x_axmGBBX_Nm_wZ_8w@mail.gmail.com>
[not found] ` <02d4971c-a906-44e8-b694-bd54a89cf671@gmail.com>
2024-10-24 9:05 ` Paolo Abeni [this message]
2024-10-24 11:39 ` [PATCH net-next v22 00/14] Replace page_frag with page_frag_cache for sk_page_frag() Yunsheng Lin
2024-10-27 3:42 ` Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=add10dd4-7f5d-4aa1-aa04-767590f944e0@redhat.com \
--to=pabeni@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=yunshenglin0825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox