From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D7FC2D0CD for ; Thu, 15 May 2025 19:15:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCDAD6B00A4; Thu, 15 May 2025 15:15:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B7C5B6B00A5; Thu, 15 May 2025 15:15:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A43A36B00A6; Thu, 15 May 2025 15:15:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 87A2B6B00A4 for ; Thu, 15 May 2025 15:15:15 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 34CC216036C for ; Thu, 15 May 2025 19:15:16 +0000 (UTC) X-FDA: 83446095432.20.91454A4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf04.hostedemail.com (Postfix) with ESMTP id EE85440009 for ; Thu, 15 May 2025 19:15:13 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vz6Ms9X9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QIacIgLX; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vz6Ms9X9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QIacIgLX; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf04.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747336514; a=rsa-sha256; cv=none; b=G+1SuusQ3STRqrVnPThQjuS1K4lOzmobnOfkpit9i6vUXfvc08CoNMxYl0JGtFeMfVUC65 /95nhjxVIm1eBjLNfZ9Mw/k1cQOPhp2uIoqaZcG2hXZ/mLkeNss20tD+F35aHR+z6fHFPz 9NgRCtcvHc8iNxFl/oL7Oqhay6MM1kY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vz6Ms9X9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QIacIgLX; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vz6Ms9X9; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=QIacIgLX; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf04.hostedemail.com: domain of pfalcato@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=pfalcato@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747336514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=USAwlxUrycqtlNrtbES6qx9HlJFBmLCkrwuwugca7Uw=; b=vYDadyTelp67Q98DTubFIcTQ9SpetYWJv0jLlLpnTf4VmUBCyp3++YB8mWSWUDruBjpIFY XG9+wcdZbNhvO3Yo75r/HtcEfo2NVG4mv89wGNs4uon7tmyFLn2NIwY+BqpDn1tSSzHUEA Q7H4ZWXKuOCbkl+GAiV0GSw6M4Q1kcw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4BD8521286; Thu, 15 May 2025 19:15:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747336512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=USAwlxUrycqtlNrtbES6qx9HlJFBmLCkrwuwugca7Uw=; b=vz6Ms9X9pIedd0kA6jgbZJ9BqenivFiKJ1LhkVZolGzDavlwnKkf0Yllv+Rb5OqbmJOZYk 8TJ4QG9F/ddbkhq5SIbREZk/pttN8c0armiGyJez4bP0geQDf35n6Iz+6BE6+UJ6vZLK0R q5uAbJPnA4gudY7d8sd+67PH7PAKJHk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747336512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=USAwlxUrycqtlNrtbES6qx9HlJFBmLCkrwuwugca7Uw=; b=QIacIgLXZUjg2T9J+HVOPJr+5b+UX7JlPpygzXMrmGhSFOcrbtZT3JS0XUsvY7rdpS7VHG UZgJeGT2QTnIY+DQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1747336512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=USAwlxUrycqtlNrtbES6qx9HlJFBmLCkrwuwugca7Uw=; b=vz6Ms9X9pIedd0kA6jgbZJ9BqenivFiKJ1LhkVZolGzDavlwnKkf0Yllv+Rb5OqbmJOZYk 8TJ4QG9F/ddbkhq5SIbREZk/pttN8c0armiGyJez4bP0geQDf35n6Iz+6BE6+UJ6vZLK0R q5uAbJPnA4gudY7d8sd+67PH7PAKJHk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1747336512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=USAwlxUrycqtlNrtbES6qx9HlJFBmLCkrwuwugca7Uw=; b=QIacIgLXZUjg2T9J+HVOPJr+5b+UX7JlPpygzXMrmGhSFOcrbtZT3JS0XUsvY7rdpS7VHG UZgJeGT2QTnIY+DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C1653139D0; Thu, 15 May 2025 19:15:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id puzKKz89JmhjBQAAD6G6ig (envelope-from ); Thu, 15 May 2025 19:15:11 +0000 Date: Thu, 15 May 2025 20:15:10 +0100 From: Pedro Falcato To: Lorenzo Stoakes Cc: Zi Yan , Adam Sindelar , linux-mm@kvack.org, Andrew Morton , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] selftests/mm: skip hugevm test if kernel config file is not present. Message-ID: References: <20250515182333.346587-1-ziy@nvidia.com> <20250515182333.346587-2-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Stat-Signature: dubpdasqowm9iqk5swdh8339djodww5a X-Rspam-User: X-Rspamd-Queue-Id: EE85440009 X-Rspamd-Server: rspam06 X-HE-Tag: 1747336513-224716 X-HE-Meta: U2FsdGVkX1/R5nt3eI1gnRvsHV/+AY5OH1Yp24d9qFQ88UqXrOWOAVcr+0/K0d471Bn3X01NzqMOeHH+U03foEsm2qfnN+jXPjf+d7tVlPvLGVZgn61s0wU4BFrrMWz8DeVyTg6FyCE/mG+jrsLqFHZcCRian8fyb8l4mkObGwWab+xypJZj9xO0VRrTljE93xM+u5p+lP/8Pa2RniI24tyFzFQbZ1Ant6Q81Iex7Zqvot91Igxbn6y1itOJHeM0ZUIlK8Sbh+RHvn8duMQzgDvDupK2mKaP6PB6mKeSrnIHx/IdbkkLiBJos9WfEZNPGjpH93D9Ga6AXX98lQfwy/XbI2y4ZLNSLPnTo28Mcjd4QX1z4yovBm5kyCK2bY3qiUVOZewdnmc1OzJA/RfImWOF5kZjTKlu0oTvf6vc1EPXwxyRlJzC2FO4nIvcDCH8q5hl/jE7C1URYd2tzzje6zFI+BXHJevNyacbq6AltVWUH3S4V0JPn7Obgjvn6L4qzm4/owki1JZJWkvF9lX25u7Zcd6agfQu7uh1/SGBhV8hWGuGqClewn9IPv56IhWlpH/5iRxufXdpB+ax/+N6YYIfHdvMhQvZ145b0qLfj2f/YWqP++owROYYghtIezHq6OBhRetooVx+QzgQiABVekMuDVO5Dx390/hDRgCep0p4RqMOtfK5tkWRBIJsTxcKddeQTTtKaCyKIG5xCqHvF6fTFRoM+q9VnpWJeQwutP3jHiTW+nh+jyKRMM9FGL4qB8ZMGQw7L+xjqLdKPLIXtRnFvZiJBa8/Q7ftO+fAzQrTB0a9LMUyTZP6BZQc9Pdwzu3OHT33iHPVjXlDHynWXKwle+mjCkEyv6+Bny5hCZ2Y/Q95zRmoHNQtp/6c0yHlei085fN1XmBquTImiNAvy7eTmuDNaSpsz8jpKUkzEdUz8/vCWhjPMZfMAl53Pmk6zcd+NvCA4Jy/M3d8BfF D3CjejCu vt2oqj/cCKdLkrbK0EbJWotxIkjPD0WLBQWfgd/7y4JacoHFuJmm/9gOYY3ueloqAv51jRM4HvqpnCQcW5aWgzgvpL81QIfxqcrMm6LzmndXndB5aRRNbZqJvTCg2bZh95EE7oyYuj+I73zTMAKcAm2OHPTuKcdTOKhRIZijkoy4vEAD77iMsAiphX/2fiEq5mKhLpT8KmtxEa1M9qhFXXOpoApgsbh56SjASQKZqRmV3nM/Ja/EmLQgOoosP8l/MxBUoXWmdU/oOnxn64RDUfJxC8I8a/Nqahn4iOkVEomHyqAkAwXXt8408+mCfaa7xC3IYOcm5IAQJ6vFUj6RIj0Sx+R6IFh43LC5C X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 07:43:40PM +0100, Lorenzo Stoakes wrote: > On Thu, May 15, 2025 at 02:23:33PM -0400, Zi Yan wrote: > > When running hugevm tests in a machine without kernel config present, e.g., > > a VM running a kernel without CONFIG_IKCONFIG_PROC nor /boot/config-*, > > skip hugevm tests, which reads kernel config to get page table level > > information. > > > > Signed-off-by: Zi Yan > > Looks generally reasonable to me, but I'm not so familiar with this so, > > Acked-by: Lorenzo Stoakes Acked-by: Pedro Falcato Same here. Although, despite this being worth patching, I do think we should document somewhere what the expectations are for mm selftests (in terms of kernel config, environment, libc, possibly even utilities present). -- Pedro