From: Pedro Falcato <pfalcato@suse.de>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Zi Yan <ziy@nvidia.com>, Adam Sindelar <adam@wowsignal.io>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests/mm: skip hugevm test if kernel config file is not present.
Date: Thu, 15 May 2025 20:15:10 +0100 [thread overview]
Message-ID: <adcz3xx524ragyywd3uitstcsojpcxe5sqio7ln4rjsgiv2zo2@dcycsbnorcoo> (raw)
In-Reply-To: <a81d06c8-11b5-4599-a749-5c288f2a9772@lucifer.local>
On Thu, May 15, 2025 at 07:43:40PM +0100, Lorenzo Stoakes wrote:
> On Thu, May 15, 2025 at 02:23:33PM -0400, Zi Yan wrote:
> > When running hugevm tests in a machine without kernel config present, e.g.,
> > a VM running a kernel without CONFIG_IKCONFIG_PROC nor /boot/config-*,
> > skip hugevm tests, which reads kernel config to get page table level
> > information.
> >
> > Signed-off-by: Zi Yan <ziy@nvidia.com>
>
> Looks generally reasonable to me, but I'm not so familiar with this so,
>
> Acked-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Acked-by: Pedro Falcato <pfalcato@suse.de>
Same here. Although, despite this being worth patching, I do think we should
document somewhere what the expectations are for mm selftests (in terms of
kernel config, environment, libc, possibly even utilities present).
--
Pedro
next prev parent reply other threads:[~2025-05-15 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 18:23 [PATCH 1/2] selftests/mm: skip uffd tests in madv_guard if uffd " Zi Yan
2025-05-15 18:23 ` [PATCH 2/2] selftests/mm: skip hugevm test if kernel config file " Zi Yan
2025-05-15 18:43 ` Lorenzo Stoakes
2025-05-15 19:15 ` Pedro Falcato [this message]
2025-05-15 18:41 ` [PATCH 1/2] selftests/mm: skip uffd tests in madv_guard if uffd " Lorenzo Stoakes
2025-05-15 18:46 ` Zi Yan
2025-05-15 18:49 ` Lorenzo Stoakes
2025-05-15 18:53 ` Zi Yan
2025-05-15 19:11 ` Pedro Falcato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adcz3xx524ragyywd3uitstcsojpcxe5sqio7ln4rjsgiv2zo2@dcycsbnorcoo \
--to=pfalcato@suse.de \
--cc=adam@wowsignal.io \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox