From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4520EC71136 for ; Thu, 12 Jun 2025 08:28:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DBA0D6B009C; Thu, 12 Jun 2025 04:28:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D91166B009D; Thu, 12 Jun 2025 04:28:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCECB6B009E; Thu, 12 Jun 2025 04:28:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AB8846B009C for ; Thu, 12 Jun 2025 04:28:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 64AB4120D34 for ; Thu, 12 Jun 2025 08:28:32 +0000 (UTC) X-FDA: 83546072064.25.9A06792 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf05.hostedemail.com (Postfix) with ESMTP id B9E74100005 for ; Thu, 12 Jun 2025 08:28:30 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="K/ia8tsa"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=hao.ge@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749716910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FK5GViGeaS0eKXb1CGklOs8Lcazv9ig1sTbfs/WnUDs=; b=pSyCMcxtSBPuft8YXUxvpZxxqOcf8Ho0EBaCsgGZo/EdSnVO6XbYE0cNikkNt2MMngLKI0 3Fb3FQvgLDjLlvsOVBa0lueOdUOm9w7cUoW4IiuwJGktAJ1mFZqRGmKLCVvUVTiYuZK80L xAkatF/A/cw0+do20ZDKK8NHy4ubEOA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749716910; a=rsa-sha256; cv=none; b=o10RVFFlxy7mGiJdqyBVbc6JB3HwPRLKBlciH0oC8vNKADDSWflknsh7EhpCnx4aCPR4NK qjLcLKppR766k25MTP3MBZKxgjrfW8NguRJPPpdzHyn7IUf22bi6MBW9rY8JjmyAO5C6Z5 yIt9aM1n0ssv6BQeOrXHO47dUbsRbik= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="K/ia8tsa"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf05.hostedemail.com: domain of hao.ge@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=hao.ge@linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749716909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FK5GViGeaS0eKXb1CGklOs8Lcazv9ig1sTbfs/WnUDs=; b=K/ia8tsaN5YSVwzcZ7cSw6MtYYEdAZL9pCWwtEBdCG53ZTxJTtSEirziliq4lO65RcDcXH cWaXE6uKdHS0P0oc/dpDtfPnvsIIDISGN9MtmFylu+E8VSo1FfDvr5PMJUe8vnBkAhTP9c WNWZV4ihnhgxf5TOOu61Q2VzdSWRVoE= From: Hao Ge To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Mike Rapoport , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Kent Overstreet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge , Hao Ge Subject: [PATCH 5/5] mm/alloc_tag: add the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro when statically defining the percpu variable _shared_alloc_tag Date: Thu, 12 Jun 2025 16:27:30 +0800 Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 979carizbg6xdn8j5idobr4b3gfznfbd X-Rspamd-Queue-Id: B9E74100005 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1749716910-912618 X-HE-Meta: U2FsdGVkX18gxjdT5kGmCNBfh7D9cmfe0RGSobxVcRW+r0vtuOykIuKp+c1hu2Wmib1udJ/Yc2uZwDeFSbkCEdBilKnHoJzHXZmflYpPmlHQfKzLxG04mlEUbUpDIvE8W/0VW4iA5QyBoxr3KK+UOWe0SW5pTnYOYlukoZhqkO6RYGsu4D+ReFYKBIa3b839pctY/xqVn6afS2Lws1PP9cfh2l7YniG7Ed6tmDwNeoGtxmcMOzdepzn9ll63NSw/qbFmVONhLNgy16xWlwzpWaG1kvQTt/WIOUzsQB9pTXmee2/kUbkagwGFpW7/xU0c7mmQaw3tA1Qphplfcr9faLRLYfKX48ZrlJ8tSGFmebWSDNG1V76zkW/Fcu8WocuhkvH4Z9mMMfYoKZ2/eBR0IAnUSCvAWMH8H8NeTXbpLQpDwKatwvCK/aWxuYnSMKAQH94uQMuM+IVBiXhx4Ua3Jylxk9ckUn9/CqQ5j2Jet+A36kBDt91yTm3TUaXsKrp8icA4Qdzsw1U+eWSXyoNq6LlVbkIECmFjf0KmPh7fNgdkKSz/5n4jSNhB+/u2okbFcg+pO9R9g9hJc7HHitz0CoIk2U9xgXI5Xh+IdLUFZjfmkEjMIwlEEVbKFB16NjotF5F42QaQ36geqYQkB7HxMGwcVSHoyTTkEb0WjHcJJACc+XCdV79q6ZcY5SdvR9sdsLeH7NFn0cmeYVNn4HhBdlZiYNYFMNuARPxDyqb4j88qGludwH/CBDzayVJ+EdGLv+4j6w3f/KrQfl9GvfNnwgB1lxwUI44zeet4yR4nxzlMp5pD9OZSfL+w0GoRvW8wC+nZ9PGyfVp/MDE9yKSc1hkoTBZ+DSr2fOpUHH7leQd+11VrF/AIFvrSYlGs0QEMJqquKumBnt4IG9ifcleCWnM7Aya6LmcfUo3F1xWbZoPlYdZ5mCbR6xfRjhrrvkkH4xPqr4XJKY7l9vAX1wm /vvzmiDT Wwm9k0IRuEjnghoa1vGHEub7bkjfcxTMy4IoVdSXqYh/e8Sg+4ddT2hCFdwVzXgTeM+NaKu5lbTQsJjBbSuys8gL6iIMOBleiXC9zoJYFq+TU3vtl8KUBBjeL6PzKnlUjuKUr8vqmNqTn0hAZDEk3yIqVf3rPk2sfwriXC6YcQBlYhHaNf3IHIsk39/tlWojMetKFzvy/WjTlHsQ1bSJx3/xxJkJ7z6EyD/JOIaWMlYcLbEQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hao Ge Recently discovered this entry while checking kallsyms on ARM64: ffff800083e509c0 D _shared_alloc_tag If CONFIG_ARCH_NEEDS_WEAK_PER_CPU is not defined(it is only defined for s390 and alpha architectures),there's no need to statically define the percpu variable _shared_alloc_tag. As the number of CPUs increases,the wasted memory will grow correspondingly. Enclose the definition of _shared_alloc_tag within the CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition. Suggested-by: Suren Baghdasaryan Signed-off-by: Hao Ge --- lib/alloc_tag.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c index c7f602fa7b23..14fd66f26e42 100644 --- a/lib/alloc_tag.c +++ b/lib/alloc_tag.c @@ -24,8 +24,10 @@ static bool mem_profiling_support; static struct codetag_type *alloc_tag_cttype; +#ifdef CONFIG_ARCH_NEEDS_WEAK_PER_CPU DEFINE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag); EXPORT_SYMBOL(_shared_alloc_tag); +#endif DEFINE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT, mem_alloc_profiling_key); -- 2.25.1