From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64AAFC47083 for ; Wed, 2 Jun 2021 09:01:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 146E061182 for ; Wed, 2 Jun 2021 09:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 146E061182 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 599BD6B006C; Wed, 2 Jun 2021 05:01:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 548FA6B006E; Wed, 2 Jun 2021 05:01:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39BC06B0070; Wed, 2 Jun 2021 05:01:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id 03BBD6B006C for ; Wed, 2 Jun 2021 05:01:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9C0495DDA for ; Wed, 2 Jun 2021 09:01:55 +0000 (UTC) X-FDA: 78208191390.08.62FDF3C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id BBD1F8019361 for ; Wed, 2 Jun 2021 09:01:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622624514; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=njnWJTDlbIZm6prQ7E30GXwheWyUoE2xiy3Ax+zybeA=; b=TSWnAGbomiZ9c1X3d469bQoEhQU5ankyzJwAHPDDIV1ulrZvOQvS3p7lahDkxxvAZQJnzp 4ayeErus5DLAVMeJ6yVFrxvPL6HEwR1ocYMBXyVhaJur4xyvkZA6jTG6wGlIp05F5AA00N GScwWB0yCoznww/BxOyuL7eEWcPWsjA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-228-UuZXF75pM7CfGGg2LbEAfg-1; Wed, 02 Jun 2021 05:01:51 -0400 X-MC-Unique: UuZXF75pM7CfGGg2LbEAfg-1 Received: by mail-wr1-f71.google.com with SMTP id t14-20020adfe44e0000b029011851efa802so728096wrm.11 for ; Wed, 02 Jun 2021 02:01:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=njnWJTDlbIZm6prQ7E30GXwheWyUoE2xiy3Ax+zybeA=; b=TkJSsjGzxHMvy+M0dLYTy0e9ZXrh+Lone6GDaryxLGonlwBtsC/3DBLJuvOr+N6wtE RoxRXtjjTRxrGwmtjDNt3Whqa1CsnHUwHTABAyvg5OldnsWuE/44fjRrB3+xpDbRNwj+ O35KPf/2s3OoxTCJfrCt9wfWlOG+2THe2kzN40FN/3t8h54QSaB6EklY8gal4hPvDsO/ kapDgWx4AApXvrND4l3eGWnltYE2SgFRpCoouFssgGSBTNr5z2sfCPqtuI6EE/26bO5C 8JRJqk+luDcbLBqtcvc02/sYD7ATOCCUcHcY4mrNHo62SVGNEEn7c1UsCfu4FExqoPhZ havQ== X-Gm-Message-State: AOAM5326GgqwIJkI5DrMLE4D1YNKRhqZ4R1aBd/cmuZQ02Pqr/mF10az qTXocr55PIbk2uBGJda6aJlImUPFwWK0qDV1Q/XLXRzreQHPXvmdbP1eth7x6NO0TbQw8V817hp gx5smZxH5HF0= X-Received: by 2002:adf:ce90:: with SMTP id r16mr25980515wrn.146.1622624510126; Wed, 02 Jun 2021 02:01:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNVBmXAyq37FqDobGkcDp4OJuhWbvV0DTLa/PhMfqGvVUJbx2BhUaiURI8cN1Anujmf0Glyw== X-Received: by 2002:adf:ce90:: with SMTP id r16mr25980499wrn.146.1622624509984; Wed, 02 Jun 2021 02:01:49 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6b6d.dip0.t-ipconnect.de. [91.12.107.109]) by smtp.gmail.com with ESMTPSA id s8sm7204322wrr.36.2021.06.02.02.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jun 2021 02:01:49 -0700 (PDT) Subject: Re: [PATCH 2/2] mm,memory_hotplug: print the min alignment in check_pfn_span To: Max Gurtovoy , akpm@linux-foundation.org, linux-mm@kvack.org Cc: pasha.tatashin@soleen.com, linux-kernel@vger.kernel.org, logang@deltatee.com References: <20210602084752.3534-1-mgurtovoy@nvidia.com> <20210602084752.3534-2-mgurtovoy@nvidia.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 2 Jun 2021 11:01:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210602084752.3534-2-mgurtovoy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BBD1F8019361 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TSWnAGbo; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Stat-Signature: rjs51q8ntrtjxx58ygdt579oeoy74nzq X-HE-Tag: 1622624502-500276 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.06.21 10:47, Max Gurtovoy wrote: > The warning only prints the start and end pfns. Add min_align to the > warning print to add more info regarding the failure. > > Signed-off-by: Max Gurtovoy > --- > mm/memory_hotplug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 8c3b423c1141..9e86e9ee0a10 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -289,8 +289,8 @@ static int check_pfn_span(unsigned long pfn, unsigned long nr_pages, > else > min_align = PAGES_PER_SECTION; > if (!IS_ALIGNED(pfn, min_align) || !IS_ALIGNED(nr_pages, min_align)) { > - WARN(1, "Misaligned __%s_pages start: %#lx end: %#lx\n", > - reason, pfn, pfn + nr_pages - 1); > + WARN(1, "Misaligned __%s_pages min_align: %#lx start: %#lx end: %#lx\n", > + reason, min_align, pfn, pfn + nr_pages - 1); > return -EINVAL; > } > return 0; > Not sure if we really care. I expect only developers will run into that hacking on something new, and they will have to dig deeper either way. While at it, I'd suggest converting this to pr_warn(), as WARN() is frowned upon as it can crash the kernel with panic_on_warn as set by some distros. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb