From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C911C25B4F for ; Tue, 7 May 2024 11:42:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6BCA6B00AC; Tue, 7 May 2024 07:42:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C24146B00AD; Tue, 7 May 2024 07:42:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A94C76B00AE; Tue, 7 May 2024 07:42:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8994B6B00AC for ; Tue, 7 May 2024 07:42:46 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 50CC0A1E49 for ; Tue, 7 May 2024 11:42:46 +0000 (UTC) X-FDA: 82091412732.12.2D10840 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 0C06C14000B for ; Tue, 7 May 2024 11:42:43 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NyrbP9HJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715082164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jPRYoMgnpo20fT3iCSoSZIvouquMcyBtOuWF7MTQKrM=; b=DFCu3BAfseBiTyZsHGz+bMgjPGby9NbCYqLwGblV0r9LDGAZOmh89lmcftFGT8wFf8lisV 0gNBmlAsU0LQIc6aepCVtgQ9Q21TuBChT7SRhIVX5Rikolivk6d/YLL5jyDP7K9bqaPDQM 6Sisx5JGGQQZZv46qn44lYZCtEeqtcA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NyrbP9HJ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715082164; a=rsa-sha256; cv=none; b=of7DJr8TcmtumRyyjMZ2093dQnlF1ZHjIzy7GyCHBC2P4D/gd3B/LjjFlY7Ol5c93Z0sO0 S0csyP5DYCNk6O49G0cpoSgcbJ6BhNtOd8X0Kxzvm4pW7bu4+973j5ME5AO78e51HPAjHY hYZA49kVwxE6oLqZOqv0U2tBgaz28Ts= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715082163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jPRYoMgnpo20fT3iCSoSZIvouquMcyBtOuWF7MTQKrM=; b=NyrbP9HJ7XJoPcfQ13GGBZBMwbMwTn/YdyvGZ+gtDZSXTyxuUztoJb/BQyCmPWOMFFkMQE TohloMe2E/ip4lhYFuxaIa37dMIJaZH7G83wtUJ2Q6ogeJobMgpxkdVyvBRiyvgdt4cJEQ lI+/g3VjHtZetk2XaghdUJJrjfssOQw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-BcC3CJEONjGw_j8dMha73w-1; Tue, 07 May 2024 07:42:41 -0400 X-MC-Unique: BcC3CJEONjGw_j8dMha73w-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-34dab4b61d8so1780502f8f.0 for ; Tue, 07 May 2024 04:42:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715082160; x=1715686960; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jPRYoMgnpo20fT3iCSoSZIvouquMcyBtOuWF7MTQKrM=; b=KwXMTZzrhofJJHXIhCLvDRsCq5NldBVgwDr/QcGoeFtwodFuM0R7CnebVZbMNMrhn4 Q1sEwPNTcEHUr+BYkk8WJU1neIelV3CRRxtiSCrl52PoKGgxFP11DHt0/uucJ41uvsC9 CPEtmh7ScatSilDijgz4SRQYpAvxOModMtgcBcljHvt2abWONJTS/bxUx136iVMFQQgz DPquUHtRjlDH/Q5aJlnQWVuNiE/L12vNWtJP1h6nWo3re8L3sZ1xtiJGZoPD63TpKfC/ xe13io2ENwAzbdjblTCMK9XCME/88itkTVuTnkeJ7zQtQxMLfKJA+LJ0Kb3nO23vPfpN cocg== X-Forwarded-Encrypted: i=1; AJvYcCXOLAF+Wjs6rkjxFYCwGpalOOahEN58oiRjrhE2w+7e38brShNUyem0icpKSAdncsCTZeesS1PO7TKgJQCznRB9zrA= X-Gm-Message-State: AOJu0Yy5MwUOKNRhQ7OFIkXJhu0co+IgZt3acHGa6LKixqgDLfMHksdf ZtHDDO7OhcuPyjW74J5xij1ziE9GOqe7SewouF9tidB01AEuvLvH5ayQwayEaoVOzUETNHvD99m kz700qWFnFK/AUsuGXKUH7pnOAjVfdQE6hhkAUns5BCsqbaFc X-Received: by 2002:a5d:4681:0:b0:343:e52a:f51e with SMTP id u1-20020a5d4681000000b00343e52af51emr8296789wrq.47.1715082160567; Tue, 07 May 2024 04:42:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESeSNqcQIHzk1ErFvIeBHGLDQr/04N51XuBaeu1HoaBLFdx8kWZGQAD/9HQIw5flvl8pBWjg== X-Received: by 2002:a5d:4681:0:b0:343:e52a:f51e with SMTP id u1-20020a5d4681000000b00343e52af51emr8296773wrq.47.1715082160083; Tue, 07 May 2024 04:42:40 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id s8-20020adfecc8000000b0034dda041ccasm12818039wro.102.2024.05.07.04.42.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 04:42:39 -0700 (PDT) Message-ID: Date: Tue, 7 May 2024 13:42:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH] mm: align larger anonymous mappings on THP boundaries From: David Hildenbrand To: Ryan Roberts , Kefeng Wang , Yang Shi Cc: Matthew Wilcox , Yang Shi , riel@surriel.com, cl@linux.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ze Zuo References: <20231214223423.1133074-1-yang@os.amperecomputing.com> <1e8f5ac7-54ce-433a-ae53-81522b2320e1@arm.com> <1dc9a561-55f7-4d65-8b86-8a40fa0e84f9@arm.com> <6016c0e9-b567-4205-8368-1f1c76184a28@huawei.com> <2c14d9ad-c5a3-4f29-a6eb-633cdf3a5e9e@redhat.com> <4e7ce57f-cad1-44d5-a1d8-4cd47683a358@arm.com> <9ce8a0f4-d1af-44ea-87b5-57ebdb3d2910@arm.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 5o5ikp5ie3odscz4t8ridqea66b6ozog X-Rspamd-Queue-Id: 0C06C14000B X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715082163-865667 X-HE-Meta: U2FsdGVkX18zxtG4poc/RokgZ5Ci10b2XS5Q3t0+rDW7mYjhee7YarhVPKi3n/gjTG+dTxFB1bQQao2rIPdcLoaiOkoUxvDZKIaUGG4kYEGM7iP9VnRf0yp68kyhO46jTMIPhjuFcz+H+5i7wg2s3eZaP51G/RaSqr+oqf4Xkr1OezCePYMQIo3FWxYKgsSgCYXOubVKhcRE9O0TfTve86/zbh9XtZ7UCQFObeFxJfS1X7ycJ4oa4bkpxWLyJwpxQize22PYYRyMh5sJJIjFX7/brqvSZDc+eZmd+c8WC7cueXp4MGvPWo0CPUmh44CmYt3cyRG26/ibNDZHr9Geg49XofteJUDbBaZ80Mw9fi2VALyKvtFvzHbv7LgeWpSgwzXY20CvBe7nIbq66+Fg1Ot3oQe38YFvvbKa+v545I6MUX0AHpAQnDRASZ6QNzRXThI8NhE197wOZVYZigvgmy79diM+4wEQ3Qn5IGLyNIrBuvi2a4HM4b/NSDeGZYmIdIZjA7XIJRPAaly/zTn/OCxt/SZoawdhJlGSX+gywQ6p6WNJHAqp0hoCKVqfvb9YWEH2JzjFyH0/yXji276t35ml2tPb8jBdwGfqrzbqUxAMPnxTa/Qkdm+DPD10DI3VNhkfFPvsG+YGhkl2zsy95A/ZlSZZu8hfvduDRhyjw0BLf7uMMrDGSGQwID0KUbZPgyKXIiYJM/Tgcc77P8BFIU5fVdIrQS8QQHa+TyXlret2kFZQ+dn0Ct7kq6DcWvd47A+MxKR2u54Uyre/PYlX7LlNdKAGr6hrvL11c8ncvYpRuwuFypID4eL35B+qVPtM20Zgy/FBMZEI02yL2edt0x2txXOl1sx7bolUF2BzLZASl0ZiE3LYkcxHs3goi1IOPgDCssgA6CY907ucCGpRH4wnLrNuTTFjsV8NN99xnY4pjrtjMO4inhuR2DcWX62eHPFz/w9qLZju78W1rgV uwjlYJgv aT3H7Grs6FK2+VTWPC8FWDGoA/8w+sRtPxM+vq04aHlYrhNcUiajsY1RJdLaFImmR2lOteJdr4QRW4P7K8ASjuBxPmzVLQZkdSSrOYT7MaFH4AdrbBQNmn+ocbPkmrz0HaBJF7RgTAR3+mroehxOn4y3vD7a3v2UTkraVjk3LjGGsIi2qHd2boPKUls2UnyeWNUsyFIFiBDa+GD0ijf6SsPuc0J+Z61SGvT/+2XIYYj2zUxJ1CHT96N9xyrM07imMckto3pcs9fxwW78IYuNn3lWe9lQ4Tf5naWdRh6YBJRym6QmkcdFuCPlCCbl4nVWHT17V80i0zwdbIY9xpn9JYoBxDte6KKeGIkPLH8QrHACsF57ZGAEtkRXF4j2J4qKW9ulHxBAWE/WS1c34v0nb8iamYVvyFe1czYrYBwewIVqUqa3J5kUe1N7nA1n+zcm8t4zxnNSTniXl0198njCWNFgcQBq3GDt+QNX1i6FDwd/FeoFl1kivOBU7um7Id66E9f38yt0A7WIcA1bn8oT2fAdIAPa0X0MX7T5MMh57hgXsbG0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.24 13:34, David Hildenbrand wrote: > On 07.05.24 13:26, Ryan Roberts wrote: >> On 07/05/2024 12:14, Ryan Roberts wrote: >>> On 07/05/2024 12:13, David Hildenbrand wrote: >>>> >>>>> https://github.com/intel/lmbench/blob/master/src/lat_mem_rd.c#L95 >>>>> >>>>>> suggest. If you want to try something semi-randomly; it might be useful to rule >>>>>> out the arm64 contpte feature. I don't see how that would be interacting here if >>>>>> mTHP is disabled (is it?). But its new for 6.9 and arm64 only. Disable with >>>>>> ARM64_CONTPTE (needs EXPERT) at compile time. >>>>> I don't enabled mTHP, so it should be not related about ARM64_CONTPTE, >>>>> but will have a try. >>>> >>>> cont-pte can get active if we're just lucky when allocating pages in the right >>>> order, correct Ryan? >>> >>> No it shouldn't do; it requires the pages to be in the same folio. > > Ah, my memory comes back. That's also important for folio_pte_batch() to > currently work as expected I think. We could change that, though, and > let cont-pte batch across folios. Thinking about it (and trying to refresh my memories), access/dirty bits might be why we don't want to do that. -- Cheers, David / dhildenb