linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Ryan Roberts <ryan.roberts@arm.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Yang Shi <shy828301@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
	Yang Shi <yang@os.amperecomputing.com>,
	riel@surriel.com, cl@linux.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Ze Zuo <zuoze1@huawei.com>
Subject: Re: [RESEND PATCH] mm: align larger anonymous mappings on THP boundaries
Date: Tue, 7 May 2024 13:42:38 +0200	[thread overview]
Message-ID: <adc6ac88-8fb8-44ad-abe6-9e9f9e4017e3@redhat.com> (raw)
In-Reply-To: <dbeda3dd-900a-4362-886e-d9aaa58ca525@redhat.com>

On 07.05.24 13:34, David Hildenbrand wrote:
> On 07.05.24 13:26, Ryan Roberts wrote:
>> On 07/05/2024 12:14, Ryan Roberts wrote:
>>> On 07/05/2024 12:13, David Hildenbrand wrote:
>>>>
>>>>> https://github.com/intel/lmbench/blob/master/src/lat_mem_rd.c#L95
>>>>>
>>>>>> suggest. If you want to try something semi-randomly; it might be useful to rule
>>>>>> out the arm64 contpte feature. I don't see how that would be interacting here if
>>>>>> mTHP is disabled (is it?). But its new for 6.9 and arm64 only. Disable with
>>>>>> ARM64_CONTPTE (needs EXPERT) at compile time.
>>>>> I don't enabled mTHP, so it should be not related about ARM64_CONTPTE,
>>>>> but will have a try.
>>>>
>>>> cont-pte can get active if we're just lucky when allocating pages in the right
>>>> order, correct Ryan?
>>>
>>> No it shouldn't do; it requires the pages to be in the same folio.
> 
> Ah, my memory comes back. That's also important for folio_pte_batch() to
> currently work as expected I think. We could change that, though, and
> let cont-pte batch across folios.

Thinking about it (and trying to refresh my memories), access/dirty bits 
might be why we don't want to do that.

-- 
Cheers,

David / dhildenb



  reply	other threads:[~2024-05-07 11:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14 22:34 Yang Shi
2024-01-20 12:04 ` Ryan Roberts
2024-01-20 12:13   ` Ryan Roberts
2024-01-20 16:39   ` Matthew Wilcox
2024-01-22 11:37     ` Ryan Roberts
2024-01-22 19:43       ` Yang Shi
2024-01-23  9:41         ` Ryan Roberts
2024-01-23 17:14           ` Yang Shi
2024-01-23 17:26             ` Yang Shi
2024-01-23 17:26             ` Ryan Roberts
2024-01-23 17:33               ` Yang Shi
2024-05-07  8:25               ` Kefeng Wang
2024-05-07 10:08                 ` Ryan Roberts
2024-05-07 10:59                   ` Kefeng Wang
2024-05-07 11:13                     ` David Hildenbrand
2024-05-07 11:14                       ` Ryan Roberts
2024-05-07 11:26                         ` Ryan Roberts
2024-05-07 11:34                           ` David Hildenbrand
2024-05-07 11:42                             ` David Hildenbrand [this message]
2024-05-07 12:36                               ` Ryan Roberts
2024-05-07 13:53                       ` Kefeng Wang
2024-05-07 15:53                         ` Ryan Roberts
2024-05-07 17:17                           ` Yang Shi
2024-05-08  7:48                             ` Kefeng Wang
2024-05-08  8:36                               ` Ryan Roberts
2024-05-08 13:37                                 ` Kefeng Wang
2024-05-08 13:41                                   ` Ryan Roberts
2024-05-08 15:25                                   ` Yang Shi
2024-05-09  1:47                                     ` Kefeng Wang
2024-01-22 20:20       ` Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adc6ac88-8fb8-44ad-abe6-9e9f9e4017e3@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@surriel.com \
    --cc=ryan.roberts@arm.com \
    --cc=shy828301@gmail.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=willy@infradead.org \
    --cc=yang@os.amperecomputing.com \
    --cc=zuoze1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox