From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4379CC7EE2E for ; Fri, 19 May 2023 14:17:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8C96280001; Fri, 19 May 2023 10:17:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3CAE900003; Fri, 19 May 2023 10:17:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A04A6280001; Fri, 19 May 2023 10:17:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 92458900003 for ; Fri, 19 May 2023 10:17:21 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 53DAF1A058E for ; Fri, 19 May 2023 14:17:21 +0000 (UTC) X-FDA: 80807207082.11.A1CFE1E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 11DBB1C0017 for ; Fri, 19 May 2023 14:17:18 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="lUR/RERV"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="0H/DQLix"; spf=pass (imf21.hostedemail.com: domain of hare@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684505839; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0+VZ1HyTsuRdYwi+hWd9cIzn7uyvdspX3l+sCDgOvwM=; b=b7Stuj8plrW+XjcdD4CBRO8w0dSWD5UyuIG+5J7vyzSfBHARDBpE2ivvGeaCjX55uC3DE0 GiJ3cwUtgITXwPhpncicqel1ucZSG5mVwlSSmdGZktwebU2uTIAUGGVtx7iav/AeDQkA+C GJO5ul/cPJBGg47glxdGOipOYkPLvKA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684505839; a=rsa-sha256; cv=none; b=IPfEh2GOyN3C/fLUii7mckC+ZXzhWohAOT4aZtQMTDP6D74zDSj+XVxk0mMXkpjzqxmuka UfYWRoR1T87hy2xnNw6tsoZGmdcgnNfQB27tFQnnecKNBG49YBIIV1aaHJYlL7JObCWX6z M0MPaz84p2dJX9RinoFsWMF6IMUBf/g= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="lUR/RERV"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="0H/DQLix"; spf=pass (imf21.hostedemail.com: domain of hare@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 48C7922179; Fri, 19 May 2023 14:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684505837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0+VZ1HyTsuRdYwi+hWd9cIzn7uyvdspX3l+sCDgOvwM=; b=lUR/RERVITvOIkTMYj6gZ+8JeXHqan3Bnna1FOBmjp847w9ZHf0T6hzhM7Eq/A1T0L/dJx 4wI5ealbv3H9+kP1cNsE/jTxKje5DwlQj8mmbM95l7QnmE1+pQihUz/KdlG3xypRVqbmYZ 7C0GNrUdzrqlPr3V5FwR/UHrQKpeLp8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684505837; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0+VZ1HyTsuRdYwi+hWd9cIzn7uyvdspX3l+sCDgOvwM=; b=0H/DQLixAzELypiG8mcDJ4c7dKWgixPm6jvK/14EDBieNR/7dM/kD/ybovU/M5icvpLBTz 2GDt3VvKWgu74TCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D7D5313A12; Fri, 19 May 2023 14:17:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cB26M+yEZ2ThHQAAMHmgww (envelope-from ); Fri, 19 May 2023 14:17:16 +0000 Message-ID: Date: Fri, 19 May 2023 16:17:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 01/17] fs: unexport buffer_check_dirty_writeback To: Christoph Hellwig , Jens Axboe Cc: Miklos Szeredi , "Darrick J. Wong" , Andrew Morton , David Howells , Matthew Wilcox , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230424054926.26927-1-hch@lst.de> <20230424054926.26927-2-hch@lst.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20230424054926.26927-2-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 11DBB1C0017 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: z198iegdptq1nck5prbw3yi79rytwxis X-HE-Tag: 1684505838-94591 X-HE-Meta: U2FsdGVkX19Q1mQiWDZi7pES0pE0wnjQFUljqI/YuVfdgUs4xb3tMYMqp9H91TinZ7NxE53lOE7At6cdWwyLZv/4ri3ewFvXKbTydb1DULHDv21RC1XdPdZ+1GUItdFrewJcQtGgWYriymbrrGeVyefhK97T3PSLc32QFoGuenIlrGWFUS1pBzPAW/7ZF/sCofjEq/44rfjCnCdcSrsdIDeVFfuzGcVjMSKhOPjXUdHLYhyCCzfH5OL3EPxd5HJPRZbOoWqpxJii6ZHpPNiP5T5pHJmc8MiOAA2SmrzKUFl1SPmoRMDHM6qXo0H1cBav9/+ZQXNKmeqnf7Rh13AVfLwYqv8ONkuY4RlfAUZaupkvONiu3cyUuKQmoiHo5xLSIHweiJwjmJQwtc+kYkkHNbK5DP4WJg0p8gVn0OgBk0botd+MMNOjTE5zV856XGNGxfG/LIcSEhVnb3FKTGZbRNmN86shUPJ1vW0Pp1Cj4Ca4G3QpfjI/yeNU46t+BGdyC+CwRSUdhSHJuKL3wgLY4DkkMwtWuox/mPEqCJMrVJrg13JtU+/WK1McD6w++BuvApLqauS22x8r0dFr+8vZlCpaiGOvdySdZud/OFuLuu6yF5oSdBKem28VBGDq5L6WYGaW9HZcs2DkYLUoPHx1brb3vBaN7Q1ByuPXX2C5+mK6Sh4IgkyPpWgnPYSymV0UJvDrCWBD3lrSKHAAvuoJiFaltFrSi/m8XrzrWQ+3+rdZDA498IJ87IgultkpJg1vInMf8m2z8dnFPtqacSOVrPKfIB3ZSyCREZyVzaiisSbAPBgVNJcmYWLYJpQItOb3TzxuzNO6Kc2oDpAmmQ/O/FbcMx+VH8c8lg8p2nxSief0gzEIXrxpnKYkPVt+xnkv7vsH5VxcvyOk4LSuwZQfTE8BA9L+sXxg3m3PrT7gaYYvV/wIPCDEUi65CY3Xo0B6/ushD7ZN8iofGF99o7g kQQBmGzm nc90PCsJmgoWRRnd+fAN48vy/LV/X4l8gAKAYfQxOtVlWKVTe/viHQmiKBPog1nYDy4F31p1r01JIZGEbDAXzEfkgNKEPmaEI8WAfn0AfMWxw/SoI1lz6Z7FGXyZ/5q6tkhfHr9EsOazrVbU2IXC8C+WKpvPaPapZQPlY5sR5I34M5nvzuhnpDhRQdbnWkwTRB1+nnmyWlRQRQrQkY3Xisn+pdacR/65IACc1BdgjKE2Cu7l8+7yiWqiKaYqsMuHYpdKIkfF0mqudn6IrGbDx7MySbCQNlSGEeQBQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/24/23 07:49, Christoph Hellwig wrote: > buffer_check_dirty_writeback is only used by the block device aops, > remove the export. > > Signed-off-by: Christoph Hellwig > --- > fs/buffer.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index 9e1e2add541e07..eb14fbaa7d35f7 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -111,7 +111,6 @@ void buffer_check_dirty_writeback(struct folio *folio, > bh = bh->b_this_page; > } while (bh != head); > } > -EXPORT_SYMBOL(buffer_check_dirty_writeback); > > /* > * Block until a buffer comes unlocked. This doesn't stop it Reviewed-by: Hannes Reinecke Cheers, Hannes