From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ECAEC02198 for ; Wed, 12 Feb 2025 15:32:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3851D280002; Wed, 12 Feb 2025 10:32:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 333EB280001; Wed, 12 Feb 2025 10:32:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FC51280002; Wed, 12 Feb 2025 10:32:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0015E280001 for ; Wed, 12 Feb 2025 10:32:52 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A4E321A1F72 for ; Wed, 12 Feb 2025 15:32:52 +0000 (UTC) X-FDA: 83111685384.17.5A00AC5 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf19.hostedemail.com (Postfix) with ESMTP id B20731A000B for ; Wed, 12 Feb 2025 15:32:50 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=BUv4Xa1q; spf=pass (imf19.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.50 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739374370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dPy43iKR6KpT/NgNd5rg+NCLFB5HBVXrzanhWv5cGSs=; b=H7BRGKVljyjRjRWZDZb20N1WIxocBgwj/DVTW4v8Uhg7oBivrt12va5l8S+TIZtRKFH7R2 xZcUeNvC7qECVN1aywW1y9NAWhPjpbJbJ01+DRn3f5zAKJvRijomGTGKH9NSEDwWYgLNpI HX+qCQ0L//S5pLD4Xbr6fPb6J4+M0oM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=BUv4Xa1q; spf=pass (imf19.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.50 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739374370; a=rsa-sha256; cv=none; b=3rHlQjgtXon4m3tiy5FnZUbje1eQGGzdkIw0U2tR5zM7/Nm7ZneKMuAaQAUWQwVMMlQL+v 58GdSi40/7rScGauGgQg+XTCx96E/0DSKZJ8WkSISV3I8jL50Vqi4A8jUMa6CC+kGPNA8X 5JRNIaTkeksHbhwsHY1SrnPs93fOh0w= Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-aaf3c3c104fso1188356866b.1 for ; Wed, 12 Feb 2025 07:32:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1739374369; x=1739979169; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dPy43iKR6KpT/NgNd5rg+NCLFB5HBVXrzanhWv5cGSs=; b=BUv4Xa1q87Bn4YnDGjD4J99NldQPM8mQjUwPtgiZLfJ4lTKFvC8ThBZKrK8u5+DNH3 ev8SjBw4fTQqZvwonbMz9svOrOow0fDWPruIqTF6wv3mzQ/ZvRHRAwO9pTvorkR4vPTm mIiub2j/OIK3EK1auxXR2pEq7jY3wjZXiugXThLGIjU8jqebisBI2voW5LCG2yH1FZ9U RLd0yYd3SUv5KxexYUuXsT/gYeaO8Ulx0uJ/QcxB43bEkchHz6a94/B3tpXh9ou9/EF4 W4Bbdceg9Vey7RlMCiciYYlRuTxYTaJCZkI2SekryM+N19XfVxbtQy8Wqr4m8N2sQzgA 9GrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739374369; x=1739979169; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dPy43iKR6KpT/NgNd5rg+NCLFB5HBVXrzanhWv5cGSs=; b=dzclewTQ5B/Fv48J8PHyoHHwNJxMt/2SdGK62/LAOCXjEufLCCKGecy4D1bIkSNHES R00LTfS+EmAYMdLpuADzPkRyIgtoq/DuvsRWFAaKgQ6621XkhLrcQiFIeMdfPtVOlltg kpjg4M3nFF51cH7TojH2gFV/FYvybr8jvaoZ9a4wKudpc4+KoJmouETiRisghTyhzixw UzPIrjiId/6YzYhDz9Sc7HVHrwa7bYxAfveFsGX6gf8ogiQhuU1Wh4qqvYJ/G7kjbeKe VUGDJLtOQQ9Qmd8K8pGactr/UV9q4U0UMAV69Op3aSG97VR4f/O3IJsUABFFTON4Bc0A WJiA== X-Gm-Message-State: AOJu0YwBmMOtoN3ri2+W8am/6xHui7oF7i4NYeGnXbYhk3GkR9AE950H 5ZH2D6eHIGdJ55a+Mi297i/6dS9sllh36PaReQxSRnUqL4fEOtWl8M3NgZs0QqAtzhYgaTaNPh/ V X-Gm-Gg: ASbGnctjZvM9IoGgRkf7hrtdt8lyeZtLImsfMlExSgJt/U0Y7JD3yFYCs6V/h46gjaI jwpvId7j9QdjuxZEcLci8N5KZxffPpu/FoRTdp59HK9tF18xrKHWxdcbm/3Kavi+YGqGZN/69eG hABTOUxkKMtO+zOernFAppBWKvBptcfJvVegZK3aCyfbncyU+iV+AkOKX9lBbsh0MXZIm//4B90 EfYyLRf7wo0XLgweCWz4/0ZxmhJ1CUwxT8Vac70uGjf9AaN2roFm/0t8vcQVsoPd8+R7xVD6Z9u /ots/O56JAnCNdecjJ80 X-Google-Smtp-Source: AGHT+IF6CPshz6638g2CWiyfBXW6MZu08LCjdls+xaYH/8s18PubWJy6MEiXC1TcsLyI4ZQIqkYceA== X-Received: by 2002:a17:906:c10c:b0:ab7:d6c:5781 with SMTP id a640c23a62f3a-ab7f33a1557mr357358166b.24.1739374369107; Wed, 12 Feb 2025 07:32:49 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ab7bca07294sm688753866b.68.2025.02.12.07.32.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 07:32:48 -0800 (PST) Date: Wed, 12 Feb 2025 18:32:45 +0300 From: Dan Carpenter To: Zi Yan Cc: linux-mm@kvack.org Subject: Re: [bug report] mm/huge_memory: add two new (not yet used) functions for folio_split() Message-ID: References: <2afe3d59-aca5-40f7-82a3-a6d976fb0f4f@stanley.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B20731A000B X-Stat-Signature: tnsu18nepj6heymkhc4nu6hd8w877wa5 X-HE-Tag: 1739374370-898870 X-HE-Meta: U2FsdGVkX19f/CnCwamRwWHZVMWYiG8O5jEijUgDdtA/dD+RhuDXXKY+jaOqLtGBuSdTjn5QCIhouWqwoOG5p/8AIulbA0/atWwG38oBC1y6xQDMmDzS0pnns03ECfj4gUq1JsgK5StcHlZG4bbZ64GIp/6/gssYyUdNeKIc6Xw0tdLIAjkLA1jys9lMSNe+836q9TxSxG5BcqswqK7S3RPz+cFHVLiAeCw4rWEvZgFIyMSemcvRZI0ofMVCVu0FH9+DGpRihf1VwhVs+Unp1G03IIzW/nflm5OWCPMlj4X6RwrpL77nYg1ufcswFrUcoFdSfXp2h0F/YaWDAYkchxZq/2tZw6rNQZ2y7c0bekHeRcY9iUkEW2biFLtozOWaEx40zfz/A8THMK/vWATPZsQxdQ5bwm/OPZ4hqAb4qZ8ssqib5PfUQ2TcXfM7b5gZsa/JA3V9rQUAq7GAY3kDjRdEs5RJNfluSSs9m+NmLO/5jFy0dbFNtbSfq73YqEoqmo2qMwrmmF7qUUuw9Co32wGDATgrVJjVDc5qBN54cJRCrPL0Ho1EfoVMnrnTYMIMIuo2T4n/iuz2wJ1AIC8+dYMdhiqixR4KrQDerlvqdYimm+YqRJ+lBWBxfbW9gTtTW/Fo4agzsM2Wc3L9AteXbw3EfbT9EjFdi557vm+YBkUR/TZKw9RYhdLaYamjbISLBkn5taSfTKIePWGxKcjcSm3akHNdrH1XA3eJDA/o1Y2CnXRbuAbbOixSIWY08DFaSLORCJxiOBMdaPOUyKKIKL5ppEDQ9AbIdTaM7FsOxgaitQXMV4wQUAP3P3V6l67g/QFstk5C71ZZ7XJq9OXkkyXpdAmoZZIG3FFvQ7V6TkC6zGzjLcolPADJLoi2Zr33aJdj9lYuLDVU+IJqSiejn7TM0RqhNxWn2Y3aHfaAv7beRYM9cg9dK6sRJ4nkmtGgO8isMziWJptxi9CVrLk DjnkoSC/ hv597LWM55an1X3p1R2CR25ErCxqzmygcOg3Z8BApsttdUpHV2QZ9LG7saNLLDRGMaQsP7mx9AcV8kj0DblOYyTZJzsj3FMv3L8dm5ogZvpE2yUuwYJ++3TQRXUBLfUR0gnyTI7NE3Z3n1hS3eQYzy18IHSZ6QwrX9GDJFj7P3c17AO9CT7pfew5eI5/PHKVGf+U9VKOrI8ixq4+FRnyag3YA07/GGtYRa2GBJVsebMTTmDyPUNAmEQKB13e7kay/1ccpztd9XxjzvpqQ91RoW5/COF+blwXY76rfs9KIFDgzI5lbHRpBMEWPz9/pWYj4tUmpT4vxGq8T5bIkoqb0+WLUeX2ycJ2FjPKf+zhJQB6GbBn+ZZl9p7ULUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000085, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 10:30:26AM -0500, Zi Yan wrote: > Hi Dan, > > Thanks for reporting, but based on __split_unmmaped_folio()’s call site, > mapping cannot be NULL when it is dereferenced. Is there a proper way to > tell Smatch that? VM_BUG_ON(folio_test_anon(folio) || !mapping) might > help the first case, but not sure about the second one. > No, just ignore the warning. I'll probably send another email if you ever rename the function, but I try not to... Thanks for taking a look at this. regards, dan carpenter