From: Ryan Roberts <ryan.roberts@arm.com>
To: John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Zenghui Yu <yuzenghui@huawei.com>,
Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>, Zi Yan <ziy@nvidia.com>,
Barry Song <21cnbao@gmail.com>,
Alistair Popple <apopple@nvidia.com>,
William Kucharski <william.kucharski@oracle.com>
Cc: linux-mm@kvack.org, Barry Song <v-songbaohua@oppo.com>
Subject: Re: [PATCH v2] tools/mm: Add thpmaps script to dump THP usage info
Date: Fri, 12 Jan 2024 10:01:21 +0000 [thread overview]
Message-ID: <adae46d3-a1e6-4526-91ce-750fc870d5aa@arm.com> (raw)
In-Reply-To: <4eb4880c-d189-4576-8e2e-3deb40b5f8b0@nvidia.com>
On 11/01/2024 18:04, John Hubbard wrote:
> On 1/11/24 09:32, Ryan Roberts wrote:
> ...
>>> I have all the information to create a hugetlb-specific set of counters, so its
>>> not lumped in with page cache memory. You would then have counter sets of
>>> "anon", "file" and "htlb". Would that be useful?
>>
>> Or I could just filter out hugetlb memory so it doesn't appear in this tool at
>> all? That would be easier implementation-wise, and probably more in line with
>> the original intention of the tool (it's called thpmaps, after all).
>>
>
> That does seem better. And I spend a fair amount of time explaining to
> end users that hugetlbfs != THP, so that would also avoid aggravating that
> problem as well.
>
Implemented for v3
>
> thanks,
next prev parent reply other threads:[~2024-01-12 10:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 17:32 Ryan Roberts
2024-01-10 23:21 ` John Hubbard
2024-01-11 0:11 ` John Hubbard
2024-01-11 3:32 ` John Hubbard
2024-01-11 11:54 ` Ryan Roberts
2024-01-11 17:32 ` Ryan Roberts
2024-01-11 18:01 ` David Hildenbrand
2024-01-11 18:04 ` John Hubbard
2024-01-12 10:01 ` Ryan Roberts [this message]
2024-01-11 18:17 ` John Hubbard
2024-01-12 10:00 ` Ryan Roberts
2024-01-12 19:14 ` John Hubbard
2024-01-15 9:48 ` Ryan Roberts
2024-01-15 15:56 ` Ryan Roberts
2024-01-15 21:30 ` John Hubbard
2024-01-16 8:53 ` Ryan Roberts
2024-01-16 17:27 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adae46d3-a1e6-4526-91ce-750fc870d5aa@arm.com \
--to=ryan.roberts@arm.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=v-songbaohua@oppo.com \
--cc=wangkefeng.wang@huawei.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=yuzenghui@huawei.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox