From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C600AD4337C for ; Thu, 7 Nov 2024 16:34:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 275966B0082; Thu, 7 Nov 2024 11:34:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 224DD6B0088; Thu, 7 Nov 2024 11:34:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ED0D6B0089; Thu, 7 Nov 2024 11:34:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E3C376B0082 for ; Thu, 7 Nov 2024 11:34:47 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8F8B64091F for ; Thu, 7 Nov 2024 16:34:47 +0000 (UTC) X-FDA: 82759847142.04.5626664 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id A615440030 for ; Thu, 7 Nov 2024 16:34:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DUg8qcvj; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730997234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ZhQtCCJ+QeNwkTGhIaEaU8V5oy77KACcRuqKPJDZpI=; b=EAWGqIhESPtkudG37d5IAZs5kwTnfTtui6/ARdh6cIMkqMJ1Bxk91i327iG2cGjtPF1EfB SRwKRZ0uf6MSiiJFjtMXk/xQmKqiB+56ZNcwGqNuQ2cRvEDeiRx+BW/brmGlO6rzlKzpCG eo5Tqaw5OZmk7HpRT/qKz9cAXAZghyk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730997234; a=rsa-sha256; cv=none; b=G68xjeGKGPA1aNzvTU3H83yp44SujWMDQ0dwOfCQrQXOsDNxTo7RLc8sbbtjWCyxWC2SCp 2iXq6QbqjGvDrlX64su84dCbL7fMrVunbIrHe+WjoQwdOTD4sZ5o1e8dyWxJQCxe1Xsl8l OWUtQrPH4hLUlCWtp/rQIPm1HqRtCpY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DUg8qcvj; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730997284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/ZhQtCCJ+QeNwkTGhIaEaU8V5oy77KACcRuqKPJDZpI=; b=DUg8qcvjWLlzZ4LIFwsqMsZd5A0l0gVtbt/mPzFECAJidQ/+OcOUpmpQZ37amjKL97Hna7 8kSMzMpWEE14FC3vTyIr+L58is/67wsHy/u9dj+mMsO8lYZTCjpHz6bZAyJRuPUqG7W4P5 AhE8Sz6Jcypk5F95L41KfWZm+NSnla4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-biCPoG5CPwGfc4Z9TVOAPQ-1; Thu, 07 Nov 2024 11:34:43 -0500 X-MC-Unique: biCPoG5CPwGfc4Z9TVOAPQ-1 X-Mimecast-MFC-AGG-ID: biCPoG5CPwGfc4Z9TVOAPQ Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43151a9ea95so12204295e9.1 for ; Thu, 07 Nov 2024 08:34:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730997282; x=1731602082; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=/ZhQtCCJ+QeNwkTGhIaEaU8V5oy77KACcRuqKPJDZpI=; b=bsmcutrV9Yy9ubLq2Gj8Fv+89X8DqQUkpCgasAcw0mAh0jllbhRZYeGzUMQzvBtBvh gW1g+RsfkAXudoT2kGQmThIjeixiQUMrVoZCmhGS+0cmtJVpzxauwwIIZAB82oz3BZ8K MhefSiicFM7gKeCJvH6SS3LvFQEq6gh+XPCmp4clhIsurwYJAoHIT+lcxk3LGx3I+lG+ fhTjOd2VX3ndTvz1rG+h/wA9kjCI6kHkZGf48HejDnsV7Ouukf/Ub5yvXFRI/jz+y+3i INPUBOINsBXCF9dU/y2zaoyObkEReHZyEPX18kRMH727W/rORfL1r3hZwzJIzFfOSeAf QSIg== X-Forwarded-Encrypted: i=1; AJvYcCV9RA6BEFLrpe/w9XuR/YZ4SNXW3SbZdpqEOrLOPwuV3kO66PD3w6vB56ywvgbGW3yUhBEDd+j+RA==@kvack.org X-Gm-Message-State: AOJu0Yxqv0U4aEECWZGas3P+/lYLVxZ904HZFHdDvJP/B1YJ0q8/EMhl gwcdsArHUJckw16oBnjc8LkIE5OFqmk74vR+uX5n+0FvnpZz05DlIlypoGiGhaRIh61WTAKlsqn v+6zF8oc+oJYuAJXfeFsF5lqGXTQqJw436fF1w5uIRg7fuSYr X-Received: by 2002:a05:600c:3c82:b0:431:7ccd:ff8a with SMTP id 5b1f17b1804b1-432b686e2femr1500625e9.14.1730997282172; Thu, 07 Nov 2024 08:34:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnMEuJ1zS0g37JYfnG48bMO5TvDO+F7XkQt1/ypB8HPW7mSurE6O0zL+TU9r1Pp99uUAfyWg== X-Received: by 2002:a05:600c:3c82:b0:431:7ccd:ff8a with SMTP id 5b1f17b1804b1-432b686e2femr1500465e9.14.1730997281810; Thu, 07 Nov 2024 08:34:41 -0800 (PST) Received: from ?IPV6:2003:cb:c708:7900:b88e:c72a:abbd:d3d9? (p200300cbc7087900b88ec72aabbdd3d9.dip0.t-ipconnect.de. [2003:cb:c708:7900:b88e:c72a:abbd:d3d9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432aa6b2c32sm65683325e9.10.2024.11.07.08.34.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Nov 2024 08:34:41 -0800 (PST) Message-ID: Date: Thu, 7 Nov 2024 17:34:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [ISSUE] split_folio() and dirty IOMAP folios To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, "linux-mm@kvack.org" , kvm@vger.kernel.org, Zi Yan , Christian Brauner , "Darrick J. Wong" , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Thomas Huth References: <4febc035-a4ff-4afe-a9a0-d127826852a9@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 60frqeTBYo6PUNQ00Ky1fffesTva9Qyq0bdrJfm1xAo_1730997282 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 4u4z4o1chykj6gbmfmk794ny9wyh3fa1 X-Rspam-User: X-Rspamd-Queue-Id: A615440030 X-Rspamd-Server: rspam02 X-HE-Tag: 1730997257-918792 X-HE-Meta: U2FsdGVkX19SS06ZSd2xVBWCPf0esXKnLpOq3pPirB3Q1npVPeYuiIZKIxVdlVf1cJt5xIeXGAyAxam09Ds/Q7GIKyOc44uOO55BEPB4vngQWnOnzXLrJZn/x/jTvmVjGgFdVrKOG3g7LzpxryiH03Tm8U8mn9HXkdlq7aRmcvigSbrvLVw4h48SlllPQnfO+v2lj94Ebg8pDECxJCpu9cYullaxzdKLY1AqFzkrzwf3alUySqWAUzQ294JRscLom6iXKK/wpNoGkurnTtoZHg9819V0I25IaBDBh7uL6q4pgSIqDl7cS0zLrZo6q7wdwWeZEBTCjL7PqZVE8S0EVPiVniGD1y6yz9KEUQrGmbIAu79kX5GSzdFPFxKW+9F6+QMl5mWpwKqrcd1mxoD9Hn4RffiWkVPEoQVtyTyEN9GLcNtmfAv/pkLGtzidIEs/ZmPzRtJ1e1OkmVo495WKvhhyHP6m+ZWaTs+FtgSkE3/Ynmtj59KIzKDM0N6dcclDwgu5s0hZf7QAZQ3MludRsZf6ykCkLdSqb0/rA0C8UruttmslW/FayX8FTEpis0tWiQzJh8Z0GlBnpvEo2J/98HibWnlA3YbwMQr7zCFipD3VXWskurw/Sj4WAzhIxTB//B/ifSEXYIRz+aA6KpL2vNLxtDkKibGcWvA1CmrOkWPMEct+PYVHdgFORyCi0hKmQRRhyZ360WGPp0L10TG9055UImHRsLmPUS4ro+6BXuSiQRdwpiKKb7u8p4+Lyp/i6NvcgnCxV2Kr9wwHAIZgrLc+xOX84cGAAmKyO3PzK3AUHdR0uIn+NQlfGGYP3ig2HKqLv/UF8obX6LqFIla/XyCjEyhVhMtgEIAFGj29QFGKmcfpqgveRxF9nCQbxmUbrNBIidJt0ZmCQEJkGDiH9b8MK9y+uwx5Spr9eUyPptkmXt0PPRMnHq7j/HZ+FIg/sfiwEFbQAeoURV6nc68 z9LBdvMe fI+447nPHPirupO6sXOnBywI/EbDM2m92ktzBII0xHOwpv7N40Yq8Y9otSzrmoHuuiMzOnhplf4Z2WG+i7SFaXRSohwoTOS1ksd0En16/diKTJiFGDNSqHg4PYale4jyfxTq3EO5tt7Wsk8tEYM0VZpGUHJ5FdtVvCHRe42Q38V4bBdAKP4/GrWza3rNMm5o32ONT7mNg0qNTIJViN9PVnzKy5Aa7ExuhPiXanhHehiHvNIivNsjvNQdI2L9fPaH8C/vIb64nx1DQ476erUAqcG4OS5YEErTP9h4SIAeDZTU18HJQ22z/TtuR0B1Qsu64NV3ONZPJnk7Zjm4kD9vu5diyQCoSmEHRXR2uI2uLqhBU57J8BGQzVtQGt2ca0/lop9cbD0ZSQj1t3S7WeT4XEwtLOKWmVW41W4KIZ6jB+AexeC5NJ9B9E/ZK3ATjsAcjxQSAfPjmLDzvrZCqJ5R3z4qIaZA8EEh9H7A+9Flie7aHUSQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001438, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.11.24 17:09, Matthew Wilcox wrote: > On Thu, Nov 07, 2024 at 04:07:08PM +0100, David Hildenbrand wrote: >> I'm debugging an interesting problem: split_folio() will fail on dirty >> folios on XFS, and I am not sure who will trigger the writeback in a timely >> manner so code relying on the split to work at some point (in sane setups >> where page pinning is not applicable) can make progress. > > You could call something like filemap_write_and_wait_range()? Thanks, have to look into some details of that. Looks like the folio_clear_dirty_for_io() is buried in folio_prepare_writeback(), so that part is taken care of. Guess I have to fo from folio to "mapping,lstart,lend" such that __filemap_fdatawrite_range() would look up the folio again. Sounds doable. (I assume I have to drop the folio lock+reference before calling that) It's a bit suboptimal that the split_folio() caller has to take care of that. But it's similar to waiting for writeback ... now I wonder if we should have a helper function that takes care of "simple" cases of -EBUSY. > >> ... or is there a feasible way forward to make iomap_release_folio() not >> bail out on dirty folios? >> >> The comment there says: >> >> "If the folio is dirty, we refuse to release our metadata because it may be >> partially dirty. Once we track per-block dirty state, we can release the >> metadata if every block is dirty." > > With the data structures and callbacks we have, it's hard to do. > Let's see if getting writeback kicked off will be enough to solve the > problem you're working on. Let me find some time tomorrow/next week to play with this. Thanks! -- Cheers, David / dhildenb