From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF1C5C00140 for ; Wed, 24 Aug 2022 06:27:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33A376B0073; Wed, 24 Aug 2022 02:27:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EA0F6B0074; Wed, 24 Aug 2022 02:27:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B156940007; Wed, 24 Aug 2022 02:27:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 086216B0073 for ; Wed, 24 Aug 2022 02:27:32 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D0A5D120987 for ; Wed, 24 Aug 2022 06:27:31 +0000 (UTC) X-FDA: 79833504702.17.B148EDE Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf18.hostedemail.com (Postfix) with ESMTP id 07E5A1C0008 for ; Wed, 24 Aug 2022 06:27:30 +0000 (UTC) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MCGHc2KljzXdxj; Wed, 24 Aug 2022 14:23:08 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 24 Aug 2022 14:27:26 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 24 Aug 2022 14:27:25 +0800 Subject: Re: [PATCH -next] bootmem: remove the vmemmap pages from kmemleak in free_bootmem_page To: Andrew Morton References: <20220818132104.2144770-1-liushixin2@huawei.com> CC: Muchun Song , Matthew Wilcox , Mike Kravetz , Oscar Salvador , , From: Liu Shixin Message-ID: Date: Wed, 24 Aug 2022 14:27:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20220818132104.2144770-1-liushixin2@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661322451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/VDliGto4MTwuSYv4bFPzJJzH83qarr93jDKL8YibmE=; b=pS3DVaEtJxK1j0MX/JlAbPmsWrjwDVfG49aJoaGobeaMebkW3xy525FoA0Tk3Jy/UczGKJ LRGfF01a4bivNOyYl/wcWrLUyO/n9kyizlpfQK2G/xOppWvP8hBTU4h9XKHniePnfICXQw 4GrAz8PNBdnBXKr0lPfhcz45tySDPIQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661322451; a=rsa-sha256; cv=none; b=Cg/T8ChIB9D7qk4NNnrxnernQ3I8svdiZwFyird1x8ozPFJ3S5R8Ah5wFuQGPJE5CvesvQ Nao0n1v81ZXc01d50tXxYFYTRg0eQMV9Y6ygMbd/o7e9kzE6IvfnDYaDOWdeMXClECXwi/ kFijLm+RyTUffez45ncRlURYliK1IuY= X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 07E5A1C0008 X-Stat-Signature: xze7hrwbbin6mcazasyns7p1bi9ssyz5 X-HE-Tag: 1661322450-93705 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, This patch is superseded by latter patch so don't merge it in next. Just the latter is fine. Thanks, https://lore.kernel.org/all/20220819094005.2928241-1-liushixin2@huawei.com/T/#u On 2022/8/18 21:21, Liu Shixin wrote: > The vmemmap pages is marked by kmemleak when allocated from memblock. > Remove it from kmemleak when free the page. Otherwise, when we reuse the > page, kmemleak may report such an error and then stop working. > > kmemleak: Cannot insert 0xffff98fb6eab3d40 into the object search tree (overlaps existing) > kmemleak: Kernel memory leak detector disabled > kmemleak: Object 0xffff98fb6be00000 (size 335544320): > kmemleak: comm "swapper", pid 0, jiffies 4294892296 > kmemleak: min_count = 0 > kmemleak: count = 0 > kmemleak: flags = 0x1 > kmemleak: checksum = 0 > kmemleak: backtrace: > > Fixes: f41f2ed43ca5 ("mm: hugetlb: free the vmemmap pages associated with each HugeTLB page") > Signed-off-by: Liu Shixin > --- > include/linux/bootmem_info.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/linux/bootmem_info.h b/include/linux/bootmem_info.h > index cc35d010fa94..899bc56948f7 100644 > --- a/include/linux/bootmem_info.h > +++ b/include/linux/bootmem_info.h > @@ -3,6 +3,7 @@ > #define __LINUX_BOOTMEM_INFO_H > > #include > +#include > > /* > * Types for free bootmem stored in page->lru.next. These have to be in > @@ -38,9 +39,10 @@ static inline void free_bootmem_page(struct page *page) > */ > VM_BUG_ON_PAGE(page_ref_count(page) != 2, page); > > - if (magic == SECTION_INFO || magic == MIX_SECTION_INFO) > + if (magic == SECTION_INFO || magic == MIX_SECTION_INFO) { > + kmemleak_free_part(page_to_virt(page), PAGE_SIZE); > put_page_bootmem(page); > - else > + } else > VM_BUG_ON_PAGE(1, page); > } > #else