From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 702E5EB64DC for ; Fri, 14 Jul 2023 14:24:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 036E38D000A; Fri, 14 Jul 2023 10:24:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F28B78D0005; Fri, 14 Jul 2023 10:24:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF08D8D000A; Fri, 14 Jul 2023 10:24:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CF6FD8D0005 for ; Fri, 14 Jul 2023 10:24:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8EA9AA02B5 for ; Fri, 14 Jul 2023 14:24:18 +0000 (UTC) X-FDA: 81010437396.29.B623CE1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 3F36340011 for ; Fri, 14 Jul 2023 14:24:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CGRx4pPz; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689344656; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wYk7jz6ntAwEI6PiLsydtI+XJXWTqtYTXOH7ZzwkMlE=; b=DV7xQmdEjR80aWeCXdfXoCKTmDZM4F1AJ6FyQXYGXfDzkGC+RfOdjPzpeMIBsI2JSEoxW/ yjIXp1fYO444vzEcJuB9mP81Gwxser9HXwe3uxEaoc5kuLB9F/hgovgOj2sOOrwkzZJoSB IG0j/fMkUmFkH+rkJt1jCAj06lqvuZU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689344656; a=rsa-sha256; cv=none; b=TKnLmWISGWSsQpPBTWRxHLzf1Vu9JMVJ3njQ7oR8CAvKBahwx3btQ1AohSS/e4W6jGbCca WyDs9SS+pjvg3IIgqTSdKJyorkWa0Vp/n8R5mYLucTMWmvKjWSAR5IP+LhRaLSxPfF/TQz IfEo+wj1Z4SpKOxKMUi4egG4YwSCsXc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CGRx4pPz; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689344655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wYk7jz6ntAwEI6PiLsydtI+XJXWTqtYTXOH7ZzwkMlE=; b=CGRx4pPzRYDcQCzHRAR2rY0+b20Ker3y5O2nZYLrT9tjVzRCgHhkUGtzydZQ2LT0u3SsK3 NGcFeH50kFufvV2z7FHg/4ghdQY6Ic7e8p1qY8uUl85tTMvYHdaBmbYHTkcj6XUx5G9vtU FqfyE4ynuAkZTBYp8JBaE0LS+pTllDA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-YCPGS9G3NBCKqKpv4kqChg-1; Fri, 14 Jul 2023 10:24:14 -0400 X-MC-Unique: YCPGS9G3NBCKqKpv4kqChg-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fc08035926so13193405e9.0 for ; Fri, 14 Jul 2023 07:24:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689344653; x=1691936653; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wYk7jz6ntAwEI6PiLsydtI+XJXWTqtYTXOH7ZzwkMlE=; b=jH6bMXKIgp6EztXO6bmCo/B0XTtVOnQMSNHgEE7iq1iwVVkx01haz6g6GiSagOIopg EsjjlYAYNoevFFEZz/C7l6zf/WppwVSFvexw/mffmxdfbHVsGyEeeFiTX/zbpbUfNahn woPRkm3KOFrH/eNqsCHs5nM57US3XV/VbDnjcw2beNJlCs2bpItxJNWUBPOVXJDWFyN4 LlVQVPXLEBsQEFmks/baJ6fx+aODvyW0Cik+bFTp8gvSIRe6D65II58EIFu9QqzgH25H v32+sTnSpgb9cwJYxVjpO8BaOyRBo5VgUn62E6BjWiv8B7p3hpBtSVMV4+r2XhEIdSkN 3Hpw== X-Gm-Message-State: ABy/qLaVemZTZeeRYnoP5iGRl25aHp25e6h/F7e/MTy3J+QUKNp76EOi XFAeXNrYd8Ci6OL/nGq2TXMt6OI/9Sq+IZYYao4+Ia3lDrP8xWfGsCnAUUnuqB+Kocje7YRaS3G LYEQXPY6mVyA= X-Received: by 2002:a05:600c:c0a:b0:3f7:e78e:8a41 with SMTP id fm10-20020a05600c0c0a00b003f7e78e8a41mr2336887wmb.18.1689344653161; Fri, 14 Jul 2023 07:24:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlGnkg8aA3OrK+INJg7RhquoSyjRL9/hr1Er0A3tqfhzrfsoLaE8gpCAuhI8MVbOWXXmbH0KRw== X-Received: by 2002:a05:600c:c0a:b0:3f7:e78e:8a41 with SMTP id fm10-20020a05600c0c0a00b003f7e78e8a41mr2336876wmb.18.1689344652791; Fri, 14 Jul 2023 07:24:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c70a:4500:8a9e:a24a:133d:86bb? (p200300cbc70a45008a9ea24a133d86bb.dip0.t-ipconnect.de. [2003:cb:c70a:4500:8a9e:a24a:133d:86bb]) by smtp.gmail.com with ESMTPSA id a14-20020a05600c224e00b003fbaade0735sm1571461wmm.19.2023.07.14.07.24.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jul 2023 07:24:12 -0700 (PDT) Message-ID: Date: Fri, 14 Jul 2023 16:24:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] mm/huge_memory: use RMAP_NONE when calling page_add_anon_rmap() To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230713120557.218592-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230713120557.218592-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3F36340011 X-Rspam-User: X-Stat-Signature: 8ighidtbmfgt6ype46qrwcfxnzn5m6tr X-Rspamd-Server: rspam03 X-HE-Tag: 1689344656-316952 X-HE-Meta: U2FsdGVkX1/7q1huonofmKyZNKONjZiP2P9U4GAqO/0xCbkmKSnT8A1wd6A+mt4PbrMGGSRXWEE8u4zgbLeVLIc2mYHtjl6byuMURYRhe3sNRHRgDKKam/yCkRjQnf8SZtXHkSpnuDcHRXwLBNGmHC4WUVuKN0T+f6Q4B2h7N9TbWVAileKKH1ILOlZQeX0zJLH7V77ISnsEnf4oW3nRXfNaG/nRZlrgizIRTAdZQFTR627kaVTuIsJt69xGs5HqUJmVGMcbKSenI289/cgXSJGvOfFRaF2X7ZpdbwXyC+RNEF91TmusE7iSQYoNPpFskKdMaYbxdjinkjZdsftJwO+nOO0Epzs1xeOf/avgt0AKLZH026RfCSi81LqE3vYzP3VM29CwlX3jC/pHTBs00tQlmGY3PW5UPrjj1Mjdg86Rj/9QVMmZlWt5rcGjj4ZTzx/R/buV0xNBM4s1qfv/zaiHwaX36hWeby/zpJ/8RiVedlptd253Ha4mkStxGo/PMfn1ZCeBKZtKmhkqikdpzyxVHF92LmnExhHYP+e5sCU+PArqo3/0Oxg3dBQnuPO9Z0+aNEvblZ1ZCr0U9TvCggCQ3/oQsdQRws2il5PYn0TlLd81kUYaAdB4ftMytzZvzp4Csg3PFoiMvVt5qRPZpgtDelD/pX1IaJOYnVXSAGNXRYzhKAB1vHLxJ3uRIK7pZlxzvCX8DOra+0NpfQF52gMLJOXE9GkjV2XyEpev285RnJi3Rlh2AFn07maJPw2M//tgQT2pxJP+F7T7K8SiuQm7USrfJZnT5VTthU+yPN3mEKy8D8+Jvmfza1OpODe5cmc/rrrwwVMVsXfsJNLr3Uk8vcMLpKnf8DWyc6QTI++mH1fEgdvlaQK7MWbWej1c+/P4X1ObAg5d66PE8cKpXnxvtZFSCINwiZz/Ofg9I/4fX+5bZiDXmwjLko9EdcTlxiBZD4Z2wWt6YGp/88W Xfa5zx+b m29/x2AEkX36Pq3l8qcyRq7dU1Dscx0NyHSUq5Y68LO0YAxqcQEZfoC+6IhuuzUA4hQQloSbQXWqMkgyD+JVkKJtqdqK7Hlf3h5GeKlXc1J2gQ8/66r86O7T2jmQffJ4mYJ6o2QzYrmUlX4FrvH8x+Y0u5MUY/vIIJnNws6ETABpI8yDHlvh1gTSoBi/9unfbSbEAKEbxLWh1muWpdU+aQnvuopWNfvkqTJ+mVQx1Cc6CdunNRn5B2OK+7tfaulbaiV+IqU5UGdu+EimkPnqZ98AqLG8cYbfEIybQIP27cuSN5GOa2z6XdIjhPoj6hA9zBZFrlP1Bb6a//zukRfYsZgiKLYW0cyOZ9rW/TAk1K5y3137uWemDh1wCEaJZfu7mG+pjeGjkcETFw+3amL7GexenyKyPvcG4vRvroCAsGTurLYvXWPkANNT4mVKpENBOr0lsiL0hmZ7sTLpbjCqlKJQOaVc5K6f49zQovhayswZAJG1uuSBLQJS4+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.07.23 14:05, Miaohe Lin wrote: > It's more convenient and readable to use RMAP_NONE instead of false when > calling page_add_anon_rmap(). No functional change intended. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 9f3109ed7351..762be2f4244c 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2255,7 +2255,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd, > entry = pte_mksoft_dirty(entry); > if (uffd_wp) > entry = pte_mkuffd_wp(entry); > - page_add_anon_rmap(page + i, vma, addr, false); > + page_add_anon_rmap(page + i, vma, addr, RMAP_NONE); > } > VM_BUG_ON(!pte_none(ptep_get(pte))); > set_pte_at(mm, addr, pte, entry); Indeed Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb