From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D39C07548 for ; Wed, 15 Nov 2023 10:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8C376B031C; Wed, 15 Nov 2023 05:47:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B3BCD6B032C; Wed, 15 Nov 2023 05:47:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5C66B032F; Wed, 15 Nov 2023 05:47:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 891966B031C for ; Wed, 15 Nov 2023 05:47:20 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5C25AB5932 for ; Wed, 15 Nov 2023 10:47:20 +0000 (UTC) X-FDA: 81459861840.22.0DDB774 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 0DEA81C000B for ; Wed, 15 Nov 2023 10:47:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DRAHID1J; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700045238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UqM8vrIxhwo/R/jUTHmCzXfFqE4PtPDapCucvQc/cDA=; b=0kNJvVMwXXZRlU9EOIT0/l83ZM5I2IjY5fGOei0l2GcT3s/+C4ea+NStJva8ohMdhG8YQP w52voY/xHssuh84CaEhJ5oLgIxDh4NiAhOpW4Hgv8BROEAaKNET8eyx3SookpHQqaHN4Qu dUnltWemjhXgWOUeBoHgzN81hVTqzT4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700045238; a=rsa-sha256; cv=none; b=eaqMc+ObhwoHloiDjPiQ0Jk7vA+7wB5DJrvlW8d8joVdC+rl60YPUM2oOmn9Tb697cDQ41 n7pomcpUGLmbxT6AfcQw1l1Js42V0urprcz4nSs+dg3v1rRdZculansBFylsr3GgPrAyxW zPp3U2nkLNUrBnSRNqXWc5l85dnwNwc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DRAHID1J; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700045237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UqM8vrIxhwo/R/jUTHmCzXfFqE4PtPDapCucvQc/cDA=; b=DRAHID1JbNhIUwV7LOhkzFEF85Wo2SFaw4MUmJGfA+KH96pm4LEv1lnuU8nEqDdQhNWM48 GIyOPyjDu5Jk49T4gAe84YaPJ+UFqpOvv2Wu02YbCZeW+ZyaOoMQZZJ37YeCyZ+ygwS0Kz acaGDCRA0GIjCzoFh1fu2QI39vmoYeE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-z-YmbxcENQaog3FFYhxGqw-1; Wed, 15 Nov 2023 05:47:13 -0500 X-MC-Unique: z-YmbxcENQaog3FFYhxGqw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4084d0b171eso3420715e9.0 for ; Wed, 15 Nov 2023 02:47:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700045232; x=1700650032; h=content-transfer-encoding:in-reply-to:organization:autocrypt :references:cc:to:from:content-language:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UqM8vrIxhwo/R/jUTHmCzXfFqE4PtPDapCucvQc/cDA=; b=TP/sS4D4CQkTDLX1w+CLXPNkCyEi7mQ3jtXw4qjBVqtkVAIYXGyUba/UAs+hnbAyRV 9m57fCGvLUBs0v0T7L7FFvY5fNHwVxeSVBmUZvCra59Dei0U4U32iB5N5JaWXhJbLz52 CaU9jaYoMjRoAqmbSVd126d6UKCgD7sOEIJ0I3ER6PFzbVAtcLratSJgly/mw+f7+Ze3 rXI8zInQ3R/H6C+t39NSr+e31oNS1IUBJpHMfvOBUtfCS8sCn2rEv0SWVlvNBpf2sY31 FHdCtstJozM5F0Acqku2R18rcNtYpQtLqtf/b1eJpKNFPbQu/aaYLaSDXmpy5bJbdKbb lC5Q== X-Gm-Message-State: AOJu0YyO80Pie90Php9WlKfmsvOyJ8C7jXGFGWo5foRGTAvaKZaU3h0e 1IjinJvj+DKAmU3vb32+lzujWv2hgHfq/TrYCUkBCh3XBK4Ox/Vjy3pTigL17HvZMpG4LU0z8KJ qx+kUVz1+Xes= X-Received: by 2002:a05:600c:1f88:b0:406:51a0:17ea with SMTP id je8-20020a05600c1f8800b0040651a017eamr5104020wmb.10.1700045232734; Wed, 15 Nov 2023 02:47:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEKnqmmL2A34wBOdooqU6W/s7ASRNRrGRAY763BPARxvQhcHgEpYuEF983uY5RVyY1NQMZfaA== X-Received: by 2002:a05:600c:1f88:b0:406:51a0:17ea with SMTP id je8-20020a05600c1f8800b0040651a017eamr5103993wmb.10.1700045232262; Wed, 15 Nov 2023 02:47:12 -0800 (PST) Received: from ?IPV6:2003:cb:c706:ed00:59ee:f048:4ed9:62a6? (p200300cbc706ed0059eef0484ed962a6.dip0.t-ipconnect.de. [2003:cb:c706:ed00:59ee:f048:4ed9:62a6]) by smtp.gmail.com with ESMTPSA id y4-20020a05600c364400b0040a507f546fsm11482421wmq.8.2023.11.15.02.47.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Nov 2023 02:47:11 -0800 (PST) Message-ID: Date: Wed, 15 Nov 2023 11:47:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: support large folio numa balancing From: David Hildenbrand To: Baolin Wang , akpm@linux-foundation.org Cc: ying.huang@intel.com, wangkefeng.wang@huawei.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <05dbc7b8-2e4a-4762-a6a6-278985d89928@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <05dbc7b8-2e4a-4762-a6a6-278985d89928@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0DEA81C000B X-Rspam-User: X-Stat-Signature: c4pzy37r3ptxz5m718hh3er5fzcupfd8 X-Rspamd-Server: rspam03 X-HE-Tag: 1700045237-540514 X-HE-Meta: U2FsdGVkX19zHbBOhjISYAXzrV4K41eC/AB+vFpDBKxQ+qolQShLbS2FJUvvu9DaNWH/WwjuZbCLBEso6mNdAAYTVBldzGURdLKK2zWS+8JvHFTm2l+6mJ4rAzVa7DsU7UtTDvCAxmB8PosCS35rMHPvkfoZnPsk/Or2/are+adpfW/TwSWuzwaI1rtTkHbDaDr3nAKKUSzT0/gcq4S2/NqgE97TKcweYlRIa7HQFL/V9GDMaaIx0KWPB4WmwfYCqcvp2j6K2wmeSKCtABvw4AjwYdIYIt67DeIi3WP7BORUniLlh/3pz72eYMZu9n1a6QzY5K29beuo2qtgyHFfBwMLF2w1dtDrhQuFq2XSNdonoe6S6n7fq0SWmuVFm1r+lFwkUxYmj013PMYx1m+MnKKbJ0gE1+oqRjWWkTYqFGO11HgnC0VnhLGe2iIRFtxtiIk8svkANjUA4X0DYJfcmPy0not2lmQUyDp1gVx4lvQGfJsEmowzz0yUYXhBkrw5aM2Cc1Yintqh4x0DG2RGrLpDMo+jVr0+LrTBZVAI7yA+dkg2458lcSUeQjYvaUpHmfRlmFMTXpyMajIDMUTbFqqkeRQgoMXr+MPQjkURdkWE+i8C1YAgH5InWW1Qw0mDhak+D+JtxNvDju6Y4VxWjz0eS5r7I9+t4tbJx9Uxk10QT16zLPA505fauRF09FvHAG0DdkM1+9nHyXAJHqZgj7YN5H5YGhY1D4GplLMzvJ0tIehu1e9JmVNXLUr9CTVUZhN+AyYRe599msLLmwee+SEuFoTUJZNqatlut9G0WvaYDtDRURTYNy7gZCOfkroWFdTZuXyOJK7vjiaLAcxg0U2WNYvGjNRn0BqFpBp1yOF1bB4HTO/rWkmz1+VN1lHzwcgu//IOXIB26eRyBBZAhg3xjQRG4XjhgRXLWSe2URwB4xK9d2cCsDV1Ot4ULpYqc1ijo9+StMbShZ86pL7 czOtvdlF rFnhvsv1tftkveTgAYjCC6BrJccNeMhRC1WwAsUnzGl6EP/0kIgg3yVR1y2laFmnqsaL7aPK1Ma1tv0/t+MdPW53ojZRbeRp4Kfc4CEzcU94/G3uYqNlTpId/5c0GOiVMb+WZv8VVcXiXzb5QrYKd5HW7BCw1SB9Aj75lLbDmaxpN/0QSgZWgcQbLjyw60iBTri7xTAfy23FPaLJcpnruylipydgiepDlWY6NjR8WmYn+sAjMHGUeQPJjuZ4jjRpidEAWKOWgAmuMsxyg6qWgU/qpP2ckdNMzNEc56RFY1fzpfBGbl7i0BtbWLZaAtpW7b0HmvuYgaddrANIl1ThsQMEa/Vl2Xs2GTGJSRmpSu62XcMrzs1t8nZWXpYXg2MOIuwT2O8NfdxDlon2fkKbJ/kFFk5VA66z7GneNgDsENLYDGn/fe1wxttj0DhCJ2KU3hn6drJ81hrDU8fAtPrnBK9dsGl8Lb8aVMDfOsUJP75GMDr8PaCRYyZFdFW1g0AZNV3ijUV8vrnVY3Gx8ohH1+xQL17hksXEIODYPsVyyHF+zWfnS8/nm0tTTNawAuLYJArgd34e+nE3MCnHedakAIkxRuQKcdZ8NSZMkMI+9IBvYcbdGZZ4ik7ZK3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.11.23 11:46, David Hildenbrand wrote: > On 13.11.23 11:45, Baolin Wang wrote: >> Currently, the file pages already support large folio, and supporting for >> anonymous pages is also under discussion[1]. Moreover, the numa balancing >> code are converted to use a folio by previous thread[2], and the migrate_pages >> function also already supports the large folio migration. >> >> So now I did not see any reason to continue restricting NUMA balancing for >> large folio. >> >> [1] https://lkml.org/lkml/2023/9/29/342 >> [2] https://lore.kernel.org/all/20230921074417.24004-4-wangkefeng.wang@huawei.com/T/#md9d10fe34587229a72801f0d731f7457ab3f4a6e >> Signed-off-by: Baolin Wang >> --- > > I'll note that another piece is missing, and I'd be curious how you > tested your patch set or what I am missing. (no anonymous pages?) > > change_pte_range() contains: > > if (prot_numa) { > ... > /* Also skip shared copy-on-write pages */ > if (is_cow_mapping(vma->vm_flags) && > folio_ref_count(folio) != 1) > continue; > > So we'll never end up mapping an anon PTE-mapped THP prot-none (well, unless a > single PTE remains) and consequently never trigger NUMA hinting faults. > > Now, that change has some history [1], but the original problem has been > sorted out in the meantime. But we should consider Linus' original feedback. > > For pte-mapped THP, we might want to do something like the following > (completely untested): > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 81991102f785..c4e6b9032e40 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -129,7 +129,8 @@ static long change_pte_range(struct mmu_gather *tlb, > > /* Also skip shared copy-on-write pages */ > if (is_cow_mapping(vma->vm_flags) && > - folio_ref_count(folio) != 1) > + (folio_maybe_dma_pinned(folio) || > + folio_estimated_sharers(folio) != 1)) Actually, > 1 might be better if the first subpage is not mapped; it's a mess. -- Cheers, David / dhildenb