From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22ADC3DA42 for ; Mon, 8 Jul 2024 09:36:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 585F16B0088; Mon, 8 Jul 2024 05:36:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5361A6B008A; Mon, 8 Jul 2024 05:36:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AF7F6B008C; Mon, 8 Jul 2024 05:36:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1B4046B0088 for ; Mon, 8 Jul 2024 05:36:42 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A5D04140897 for ; Mon, 8 Jul 2024 09:36:41 +0000 (UTC) X-FDA: 82316080602.04.CE1AD79 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 64B2E80004 for ; Mon, 8 Jul 2024 09:36:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IoLsbXqT; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720431371; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eU7QmxHMjysAW236gNJ+2qLBiUzO+NBXRFbeORsAJCM=; b=n1itWEw9GrY+ONv+WBCX0I2nihPIi0B5SiojWRkav+b0Jkxrmn4tTAIzRwMukBFWTzt4Sk QOEz3sKg2OtgFNw9oh+wJZEDCS2HHGCEfbB6TcCA9J+sgVpm+81gb/tTW3NgV4hBFaTKl1 JFmUSfIs02DWDs4C8Scfq/DJrFnKW5o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720431371; a=rsa-sha256; cv=none; b=zMBjcfP6MMNqKtchqIU5DO9oQivfi9cYyiTDgv83KHfuNjKBlYHSoHhGaqfNiWoe8OiUzc gsr1EWvl/oELGv8EghaB27M4tybedT80jscGZ/thNwq0Jf7tMxeKiiHGVIeTQ5oMWjQFh/ 9a7LZvb4mY1b67P09oaFQsxATjU/GW4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IoLsbXqT; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720431398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eU7QmxHMjysAW236gNJ+2qLBiUzO+NBXRFbeORsAJCM=; b=IoLsbXqTe7DLBkIu5WFfh/Ri9cNKoM86TaFbq8MlwN2kH5r1fLx8xmsNWwlxfCWdeUbwOp luhRTDgeRKnc4snLWOZVrXeJ+90U5606+VgAGgpiQivcMQEgap+YcGAJKZVnH81JEXKkRn 8hejgo1LsNPZziC+Tg8IQwZ95Pwpf2w= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-OJcWEhDmPyiXyT5ehIOqHg-1; Mon, 08 Jul 2024 05:36:37 -0400 X-MC-Unique: OJcWEhDmPyiXyT5ehIOqHg-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a728c02df80so303014666b.1 for ; Mon, 08 Jul 2024 02:36:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720431396; x=1721036196; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eU7QmxHMjysAW236gNJ+2qLBiUzO+NBXRFbeORsAJCM=; b=hisHoBrrK9eMmy5SC3GuAPyLO8/1pPnbbrSFlG42QPcCd5leAlDIG5eg6CNtBEkxHQ OFQrMh+BiTIbMvVo17UQyQ7Qjk9ryDCXs58arz5B90OMw6H6FcFclKMiA3GzBuDJqjyk aFo2zO28JjkcvTwNJzdqIg4Gih3LXLPg3QTH0lIiNknClKDFXLVLfjVIimtXcHLtN5zj j0G2c7HyGEOv2EIYJgzNyxVNXjlIXvk4WQQDHK4JB2l7SNyUwutogZiOOJuZwf/1+lTL SU3fin9WrZrSglqJpBHTtz+/jO4f/2vBjI69L+Hyp3ScIuEpdt79BTzKCQxRqJGEcIvQ KgKA== X-Forwarded-Encrypted: i=1; AJvYcCW6yOSuMAPIzug7M1Mkl0wzVlu7B2lb1QPQZQLbSe4QPOSNE6Kc7qeEcHlYd1aSdBYfWM198VRKmp7MzxRP68PgqLE= X-Gm-Message-State: AOJu0YwghZTy08Qy8t9DEE2ejpO/m1ZbjFx3+rKVdhmzyv3Be81e4/1z R/su+foCwhNw/TcpE7H/gi+SQOWH9I67q+UyeBlwGyr6CCD0WGmQaJAWiElvNa3vP4viXMY8035 mtQHTY1cDy9xzSNpv6qtL7K3CcHA3OKPvpWBRCMc6T01ZfLNt X-Received: by 2002:a17:906:f8ce:b0:a77:d85c:86fa with SMTP id a640c23a62f3a-a77d85c877emr463779366b.13.1720431396097; Mon, 08 Jul 2024 02:36:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHT1ZaoJIf6SEmzQZ2Rfn8IFMHpcuNwp/dBZWmltVdEGSFAlf1cKQcmOuURX0FRl6yZTD7L8Q== X-Received: by 2002:a17:906:f8ce:b0:a77:d85c:86fa with SMTP id a640c23a62f3a-a77d85c877emr463778066b.13.1720431395649; Mon, 08 Jul 2024 02:36:35 -0700 (PDT) Received: from [100.81.188.195] (ipb218f924.dynamic.kabel-deutschland.de. [178.24.249.36]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77d37c97a2sm272449066b.40.2024.07.08.02.36.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 02:36:35 -0700 (PDT) Message-ID: Date: Mon, 8 Jul 2024 11:36:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] mm: shrink skip folio mapped by an exiting process To: Zhiguo Jiang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song Cc: opensource.kernel@vivo.com References: <20240708090413.888-1-justinjiang@vivo.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240708090413.888-1-justinjiang@vivo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 64B2E80004 X-Stat-Signature: gkzn688yr49xmikim53crq8pr5n7pp9j X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720431399-854984 X-HE-Meta: U2FsdGVkX19mjoGoPrZdFVv8vn+XzpqHRWlP+MuX3ura3JUDxelbaGhfVxJuD9zTW5bv2yWBKSnJykcZvTsRWFeqt/mcV8SGWjOwX5dt6GDGDz0XLmf/BD7T8d6z+EDhA9X4eWO4rkKHFK5LVYbpBeW0U16C5TDDtzlSoxjWLf1xaU69AyX8i2gJ3f+dRYQ/m7CxjKZ+QkfDM7GTzlSl1cXsaUf6WaW38sHTih/9z7e8AnRwdMbyroDyni5mWCyOnS3fDpOsSTJEtoxpcqx5DHIFUxeK05HfxIcGfcN/5n/41BhxAO1pyCFLGvmzzczyvrPqFH578rRJRtCNBigBG+79q0pwt+y7wzXypWE7I8mSCpHt/qunZsc1CbXATGfVcUCJ+shSwWkkB5ap+bfQ6s0ygIJe9jm4nb7o0t3cFsh/d2M5C1FqCybzmzrOT/QI0FSbLZ/NHLGwO8vYF0viaLPoU7yCDQKCxFYezgdfa5Kk5znBzQVEOProPTa3BvEuqVS1XMAFTXWJ9o09ruhPVNwnB7o2noR27DVNxePBCqzFTxGSUNKfkgoLXJC5yg7jGcfPmauy7mOfkLveH67GvMPET3m/vOohpUt6u44lWzmsmarocUpuemZ7tIyQoeVnDO9wlyMyTdu5PAQL1Vz3lO5eJFu3Yk6YHE9gzCAi37Urb+djtiwbQEVKVcZQjMBYJ33hn5gPQ0UBgPm4gauM90XBiRw5Yg6xirODEx6pZdafiXQqGvaHeVSDix9Q6napu8cBgKddDNV7cQkCHZjXhZOR79uP4oX1Rj3YRuwWfWFaVy+lm/emMVTRtdlvJD36pxhHJgxQBsR2rNXZT5w62Kv10AAm221j52niaphFIo9ZbHs4usK+/oaQi56YBhaeE4/gkqNJsY6pMtBVQIzW4QJpdpqxUeU9RvUld9z1h+bCyImpw+S/XfT1KCwZEf6W+iKgRudd289bVf9hx7s EJsIKkVV RloPhwTiM683nr3c/8EXJz5qBflZ8R9UI2BZWGwKHZsPD9XAkHCY+q4ShqbKYEyYDOYr9/FxlxIjyhc1B47BIB0aSZ9UQQaOJiVPUoweuR3gKTbpjq/SOs44Gn9Kz53C+n6jd4QQDjj/F7rPKjJlQ/ztJS82N9AjCmT4uWcW1syBjnFkfnOVeqJr9sAURkqG4i3t/E7ZXk2UCjI8nY1UQ0Mua3M+Wm1+AawoneglUVhoN9Lle44jx0GmGJ50/jn/WZs78G1fJjSkdYFBIDxhGpnVTBffgMTOE8zaG++uW6x4EskerheqbpdmhofET1WHjw3BDYHCbvham7wQPTyL9RVu8KTyvQJqXJmhvzvQzFhE5knMhXXI4i2t12v2hF/A8kdDbXkyE+MYUFInVd8MifJLlDk6N9+OKXNSzVZmm0MhvaConCR1hrKXlSNBYz9IIbXDO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.07.24 11:04, Zhiguo Jiang wrote: > The releasing process of the non-shared anonymous folio mapped solely by > an exiting process may go through two flows: 1) the anonymous folio is > firstly is swaped-out into swapspace and transformed into a swp_entry > in shrink_folio_list; 2) then the swp_entry is released in the process > exiting flow. This will increase the cpu load of releasing a non-shared > anonymous folio mapped solely by an exiting process, because the folio > go through swap-out and the releasing the swapspace and swp_entry. > > When system is low memory, it is more likely to occur, because more > backend applidatuions will be killed. > > The modification is that shrink skips the non-shared anonymous folio > solely mapped by an exting process and the folio is only released > directly in the process exiting flow, which will save swap-out time > and alleviate the load of the process exiting. > > Signed-off-by: Zhiguo Jiang > --- > > Change log: > v4->v5: > 1.Modify to skip non-shared anonymous folio only. > 2.Update comments for pra->referenced = -1. > v3->v4: > 1.Modify that the unshared folios mapped only in exiting task are skip. > v2->v3: > Nothing. > v1->v2: > 1.The VM_EXITING added in v1 patch is removed, because it will fail > to compile in 32-bit system. > > mm/rmap.c | 13 +++++++++++++ > mm/vmscan.c | 7 ++++++- > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 26806b49a86f..5b5281d71dbb > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -843,6 +843,19 @@ static bool folio_referenced_one(struct folio *folio, > int referenced = 0; > unsigned long start = address, ptes = 0; > > + /* > + * Skip the non-shared anonymous folio mapped solely by > + * the single exiting process, and release it directly > + * in the process exiting. > + */ > + if ((!atomic_read(&vma->vm_mm->mm_users) || > + test_bit(MMF_OOM_SKIP, &vma->vm_mm->flags)) && > + folio_test_anon(folio) && folio_test_swapbacked(folio) && > + !folio_likely_mapped_shared(folio)) { I'm currently working on moving all folio_likely_mapped_shared() under the PTL, where we are then sure that the folio is actually mapped by this process (e.g., no concurrent unmapping poisslbe). Can we do the same here directly? -- Cheers, David / dhildenb