From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Luis Chamberlain <mcgrof@kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"agk@redhat.com" <agk@redhat.com>,
"snitzer@kernel.org" <snitzer@kernel.org>,
"philipp.reisner@linbit.com" <philipp.reisner@linbit.com>,
"lars.ellenberg@linbit.com" <lars.ellenberg@linbit.com>,
"christoph.boehmwalder@linbit.com"
<christoph.boehmwalder@linbit.com>,
"hch@infradead.org" <hch@infradead.org>,
"djwong@kernel.org" <djwong@kernel.org>,
"minchan@kernel.org" <minchan@kernel.org>,
"senozhatsky@chromium.org" <senozhatsky@chromium.org>
Cc: "patches@lists.linux.dev" <patches@lists.linux.dev>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"willy@infradead.org" <willy@infradead.org>,
"hare@suse.de" <hare@suse.de>,
"p.raghav@samsung.com" <p.raghav@samsung.com>,
"da.gomez@samsung.com" <da.gomez@samsung.com>,
"rohan.puri@samsung.com" <rohan.puri@samsung.com>,
"rpuri.linux@gmail.com" <rpuri.linux@gmail.com>,
"kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH v2 4/5] dm bufio: simplify by using PAGE_SECTORS_SHIFT
Date: Fri, 26 May 2023 09:21:58 +0000 [thread overview]
Message-ID: <ad5c229c-4c7f-e9ff-3326-477aad226388@wdc.com> (raw)
In-Reply-To: <20230526073336.344543-5-mcgrof@kernel.org>
On 26.05.23 09:33, Luis Chamberlain wrote:
> *data_mode = DATA_MODE_GET_FREE_PAGES;
> return (void *)__get_free_pages(gfp_mask,
> - c->sectors_per_block_bits - (PAGE_SHIFT - SECTOR_SHIFT));
> + c->sectors_per_block_bits - (PAGE_SECTORS_SHIFT));
> case DATA_MODE_GET_FREE_PAGES:
> free_pages((unsigned long)data,
> - c->sectors_per_block_bits - (PAGE_SHIFT - SECTOR_SHIFT));
> + c->sectors_per_block_bits - (PAGE_SECTORS_SHIFT));
The parenthesis are completely unneeded in the new version,
please remove them.
next prev parent reply other threads:[~2023-05-26 9:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 7:33 [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT Luis Chamberlain
2023-05-26 7:33 ` [PATCH v2 1/5] block: annotate bdev_disk_changed() deprecation with a symbol namespace Luis Chamberlain
2023-05-26 8:13 ` Christoph Hellwig
2023-05-26 8:20 ` Luis Chamberlain
2023-05-26 7:33 ` [PATCH v2 2/5] drbd: use PAGE_SECTORS_SHIFT and PAGE_SECTORS Luis Chamberlain
2023-05-26 9:20 ` Johannes Thumshirn
2023-05-26 7:33 ` [PATCH v2 3/5] iomap: simplify iomap_init() with PAGE_SECTORS Luis Chamberlain
2023-05-26 8:13 ` Christoph Hellwig
2023-05-26 9:20 ` Johannes Thumshirn
2023-05-26 7:33 ` [PATCH v2 4/5] dm bufio: simplify by using PAGE_SECTORS_SHIFT Luis Chamberlain
2023-05-26 9:21 ` Johannes Thumshirn [this message]
2023-05-26 7:33 ` [PATCH v2 5/5] zram: use generic PAGE_SECTORS and PAGE_SECTORS_SHIFT Luis Chamberlain
2023-05-26 9:24 ` Johannes Thumshirn
2023-05-26 9:26 ` [PATCH v2 0/5] block: simplify with PAGE_SECTORS_SHIFT Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad5c229c-4c7f-e9ff-3326-477aad226388@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=da.gomez@samsung.com \
--cc=djwong@kernel.org \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=p.raghav@samsung.com \
--cc=patches@lists.linux.dev \
--cc=philipp.reisner@linbit.com \
--cc=rohan.puri@samsung.com \
--cc=rpuri.linux@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=snitzer@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox