From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E1AC67861 for ; Fri, 5 Apr 2024 07:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 619666B00AB; Fri, 5 Apr 2024 03:33:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C8176B00D1; Fri, 5 Apr 2024 03:33:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 440F06B0118; Fri, 5 Apr 2024 03:33:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2098C6B00AB for ; Fri, 5 Apr 2024 03:33:07 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CCDD04038E for ; Fri, 5 Apr 2024 07:33:06 +0000 (UTC) X-FDA: 81974661972.17.5E90EAD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 85B901C000A for ; Fri, 5 Apr 2024 07:33:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dUmQa+YO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712302384; a=rsa-sha256; cv=none; b=psXQDctDFw+5EGZFZJFp/S6UaOx0n6oUWDBcKmPbU+JZTOYQglpAsV7rhUd9iDadQ/tWkI MkUR++3qcZ1rJuQcRKbKZXAftYXU17LP0TGeQWhwP2Jh1k4ve6BeKr7tqu5azgAHxmlxXu DKrnKE7fzOwHGip8/A1BQkCcDMqi6TI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dUmQa+YO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712302384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0RWDBqy0DnzbZpHreh7sOl3vKrjAY2y7gNTu7wlEODU=; b=XGg9MsfZQPT3W1dc3Wi+7p6FTFz6uPz0d8Br+703sNlJo5iPYJq4z8KH0vU9vDXmloow42 f7InQLmZ4SogNDrs9ee3qfyuZbpNWSr/smtkELl5MXF6TBfauVx/SKg/a+bDM16ScF7g+A t9g8twnWIJg9qNJPABxB6m+wmqteYY0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712302383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0RWDBqy0DnzbZpHreh7sOl3vKrjAY2y7gNTu7wlEODU=; b=dUmQa+YO8AoAOnu/Sij7qOhMLOqOaFr14SuUhEACDxfZ0MSPUkR4OE6gX/ochwgDRU6yFf fhfwo+kVKqk1d/YRu4HMYzhzOjR+BY70ZauBf9NvSZ4RWhrd4o/Gv6nJuUVG4sPcA+/giA UTle0QAxEATr2GDzYyG+sbLFFRh2Ta4= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-66-D7PdX-5oOg6VgpSpRKy_pQ-1; Fri, 05 Apr 2024 03:33:00 -0400 X-MC-Unique: D7PdX-5oOg6VgpSpRKy_pQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d855c0362bso16549201fa.3 for ; Fri, 05 Apr 2024 00:33:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712302379; x=1712907179; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0RWDBqy0DnzbZpHreh7sOl3vKrjAY2y7gNTu7wlEODU=; b=j68D0bJxnTe6tx01l1GIDY9o0koBPZw93+x7aolZrJEHvt7Rgzqnrit1sS67YhS5JD 7RvUzzEnoCWtnT5fMRtd0PeAbG+RZJQuaP5aCBHgyOgbIi1e8yoVC8+LKRzU2ktKQg4E 7mvpIA6S5q2a4J56trTZQgBBcOuyUk34K7c4OS/6THHUuINKUG1p8oXET78rfe6yJ/5+ MLrLoYGIJwczqHMb/kZV13PyOJWvpmMtgiyA/xFzC/6MrvEVr8hulBPC10TDKMCUfqgj 53qRGh85BKPHwqpwoM2SMRYTtYf0czwHzMsKbL86d0Vrd320UOvpjifQh//AxneW/FlC 9y0Q== X-Forwarded-Encrypted: i=1; AJvYcCUMord1/1Y3O7ZWaz5WhvXrKT+CUHpTgkS4zi0btLZU2WNwCh5YmUE9NXda/VRIwkDWC/y1ehk9QAyEGEX2GO+IYhU= X-Gm-Message-State: AOJu0YxrrwHGgoATIvxR6xVQz+Chsh7AyFkuD1jxQftHCvFlXdbIZAoa qdAyKgnjRRMwXLAj3kZhiVFTm7yYnun/EzUQUL2MvO1r7FHJ5J6WVbLe4WCosCJ97U9fUnaQbH8 du70h2NvufOxECC4vepysyR47yLjTW5uceDrWnl67UH3m1TWk X-Received: by 2002:a05:651c:50b:b0:2d8:4b0b:670e with SMTP id o11-20020a05651c050b00b002d84b0b670emr573363ljp.45.1712302378958; Fri, 05 Apr 2024 00:32:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcLepH0FnTWoD78gZGi3J7mSWeUNyJIyyV4xeb+xPa1k5vTea/cOuU2ApT7Hz5NuRCoUIINA== X-Received: by 2002:a05:651c:50b:b0:2d8:4b0b:670e with SMTP id o11-20020a05651c050b00b002d84b0b670emr573352ljp.45.1712302378581; Fri, 05 Apr 2024 00:32:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1? (p200300cbc74b5500e1f8a3108fa34ec1.dip0.t-ipconnect.de. [2003:cb:c74b:5500:e1f8:a310:8fa3:4ec1]) by smtp.gmail.com with ESMTPSA id u17-20020a05600c139100b0041563096e15sm5468468wmf.5.2024.04.05.00.32.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Apr 2024 00:32:58 -0700 (PDT) Message-ID: Date: Fri, 5 Apr 2024 09:32:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/14] mm/ksm: remove set_page_stable_node To: alexs@kernel.org, Matthew Wilcox , Andrea Arcangeli , Izik Eidus , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ryncsn@gmail.com Cc: Hugh Dickins , Chris Wright References: <20240325124904.398913-1-alexs@kernel.org> <20240325124904.398913-15-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240325124904.398913-15-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 85B901C000A X-Stat-Signature: jarsh9dnb3ns7snc3efdss8mpo5of3pt X-HE-Tag: 1712302384-745934 X-HE-Meta: U2FsdGVkX1/v9S7FKOdquSWjCeVKm0NYyBciWkc1KyIW1DDlnYVUYgGH8spA64xjmRv1P2kUd3tzV8Z9eww0e7mZrPUjFd42dOeFlsqUkBDSuptWAPsMldr4r6pGLJvpuV2PZxfhWM0wHcxAvxYI7wsJ57e6iggcGNz9ArLfN3B+PBM9CwecE6j5HmyhlEIBOH88OjG2z48359sIENVz1jVSzMbion9KTRxT/OjWFInqLE/+pUTaMFxDeyCNtmeimAMvCDoJ2tJybdIjz/c35MLKl1kDIzUPcaRJ+dk34lS/tHs1GEC07gdovRFZ6C4t3UGYXxMqzM8pMzRC1TzZFmAxoUdEo5/TsTFq8nWeke2luscFCO9/Wxw9/2Mogqrf5OPWRXyBTaOK1twm47P84U6/KgSjp9kzWAnnppjsMRFKW9J2GQXSGOethilfH10T1D0DfwiqAHJd2yR5RZKnAdwdn2fWA11diIM0ShML+1u9VqruMEehEpHfnpjKb67mV/IiEPdCIhcRWoYV60EMj0bAnUvgiI1kAbeiYNLY/0bE4WfdcY37f21C2rz7zU0REa/yieNtUAtBLYt7mnxTSjHMMQpscQKmioaySEQSH8gm1cSWZH6ELMZhysTFk/8rRFXEZK3K6tlmdE1ry5d/qbIENQkF/f9QU853gV1eBe3XIQxP5lEFVGbCBhRCzg5eKrFqL27dI7cz7WPA60o2XZgfX3UFEbXOtIpRw+3IFXFqOW3/sSCSF+T+0u5Yp0kXaVmaxEHKe3vhHMyo3YxTEk9nMwSXCKAQJPONOlfRsKI0ceToM3/6Erev1E2jEusn9RfQU3S7N7e/vudBhxsgnGIDbSkOsW4oaxY3WVq/qEqCLk7bKodY36SyEJra+3CxDf4zJ7R0c6GVc9f+X1OKsQCe9LRKwdERWX8TOrlbfnRdo2jPhU2dCbq6+Cb7TcSYT3iQSPS+XkixiKuEG4J CP4z36QI T7pfhJkdd0MjmKZCZLXhDRh9LCTpZ/Cd9C6cfy+Nbtg4fNLg71Aezmq/EC22fJsyce/M3sBkP+Bx+M+4CbPXkzHzQGbgoWqLvV8h16YaIJblb3OA1ObS6JbjSMC8t7Chyz200TZ2Exi0OolD7bjqt3gtx+X3jymcjZBCLOolAtQD9cbUpfcEPWysCE1peSA6e/WrogBNz2Sj0ddEb0n0DB62aVFn1LH2ZPOEo4/uU6tDissOsSRhMnf7AOBEQhbN1t1MN9E/BNIV3hA2JcsXMDc48+ZHmSUrvjJUb+u0mS0FELrhvEmBOpY+NmZt4fhXXB/FIcbcYlWitqN05ll+DROO921+ceK6N0pLpsqJRdkql5PzeRrqfC6jYqsWJ2+63r1O/QUalBAcGRm3uFaZ5ouIt4Kj6QHareZpfpxkb3tX+my8ZxGU/SSCocXtPLNS5W28pUgIjXnIAjfJhTRzC7vSL/C8lITTPhpCkyMllh/PV5oRHJm9KhxrFWYiJLEyyKG5pqxFEhaSzbduxTIxlla7hmw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.03.24 13:49, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > Remove the func since all caller are gone. Also remove the > VM_BUG_ON_PAGE() because it's not applicable for a folio. Ehm, it is for small folios that we are working with here. Please keep that check and convert it into a warn. VM_WARN_ON_FOLIO(folio_test_anon(folio) && PageAnonExclusive(&folio->page), folio); > - page->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM); > -} > - > static inline void folio_set_stable_node(struct folio *folio, > struct ksm_stable_node *stable_node) > { > - set_page_stable_node(&folio->page, stable_node); > + folio->mapping = (void *)((unsigned long)stable_node | PAGE_MAPPING_KSM); > } > > #ifdef CONFIG_SYSFS -- Cheers, David / dhildenb