From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F03FDC25B78 for ; Tue, 4 Jun 2024 09:23:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B8CA6B00B3; Tue, 4 Jun 2024 05:23:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 568306B00B4; Tue, 4 Jun 2024 05:23:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4089E6B00B5; Tue, 4 Jun 2024 05:23:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 226576B00B3 for ; Tue, 4 Jun 2024 05:23:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BD244A0550 for ; Tue, 4 Jun 2024 09:23:52 +0000 (UTC) X-FDA: 82192669104.10.112CD9A Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf14.hostedemail.com (Postfix) with ESMTP id C657F100002 for ; Tue, 4 Jun 2024 09:23:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=RCa783qe; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf14.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717493031; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=xemicTBwRPyiUNufo8q8iiZLE9eFd5HL26ZHWNiDDh8=; b=TkmNIHAysorN6G4IY7GBySaQmZV7cc4MXFi4V0CNGx70z4B2pqlrCyQt8HOeClqi29FyDC wIXQzhfeHUQegejg55yNYFDfZILWnoJrkjCznFT/u87T4jp6FP6DQ2Gzzvx3VFQ9jwYgit n3fGnxUGMeeK5WTVspv6ZUM0pdoWjsc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=RCa783qe; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf14.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.218.46 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717493031; a=rsa-sha256; cv=none; b=0pWyS72GDjIfdoOKng+a5GZioYx6oMnQeGIPoTxqWLEVz8JGLb7/1J6YkvsQCKNZd9RQqr hWhgJCoD+w5Z7MurjvgOnCl8Fsd5hXtmxIaWVQdPOkeUW+vYl8NV1fhB3VJ7R5PLrzoybS p/lUKjCWLXpWgBddjyIfwG2OwVgI4AI= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a6269885572so936584466b.1 for ; Tue, 04 Jun 2024 02:23:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717493029; x=1718097829; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xemicTBwRPyiUNufo8q8iiZLE9eFd5HL26ZHWNiDDh8=; b=RCa783qeqAdZI7a8ubkBQNFpjmC0y7A4pk93AzsVNlZ43q7YHV2QiL7nJbd9Q/TOmc 5aPnWZnsltu1VGwr+I6USZHKvYr0AdCPmwm/WCKc05VGzyYj6sktgHlIu64ihf48Ic8S Frzk61fL3J91JCAzC0RDyMbOWOc/Sb3A+UQ6laZyQuBJ52uHTqqCOt0X9alKyhlV/15Y 877+sOBCWOoBS//qz81Eq58tgUWgCFaDPzpyAA0KZZJP28JKXpPyFLm4b+Vk3RjUUCbX QPTZ2KuoNclsyD1NwQQ0CdVoajqpXzKVZqoJDljhExR7W4g//SSeu03I3++Ajlj8sXQA S74g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717493029; x=1718097829; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xemicTBwRPyiUNufo8q8iiZLE9eFd5HL26ZHWNiDDh8=; b=YwyFgrC20DRSdKhIJRGrTumA48uO9nMtHoQNa1gRveV61IwLJlSi4D+8pdmaPfU0kK kmEdOldxWWEohzDkbJc8DzHrNUkQwIF8/Ivj6m0+tRwHzdw/83IURFDsQrvq6CqE9jhK 90xdtL/O9SNMF5p6sE+HV4APpY47QyPnTMFmQvmfHX0mTCeARv8nbmPzb+x37gxNIK6n KrUOz56ZBNsSN4Rg3nvKh/PixkY3Lj6EyXGt+Cfw/yJV6viTVBgf6IS9MFJK1NaQ+nj8 7mdOpowfs03sZAhXrXH8UEX7CxEgGMxoeNu/Tf9q4b0d+kPLvaD1zIk3IOaIdzavWQ00 4eIw== X-Forwarded-Encrypted: i=1; AJvYcCUPUljHGBGdL12oeUmXKY6sHrXmVQRLYLxq2Xda4UTNLf0Db/59got+82hgPRuQnuPu4BrPl+EXR3aq11fbhfUuUyc= X-Gm-Message-State: AOJu0YyXigWc3k8uAhSb+Yw/Gc9CvV9aU3Av2MnmDO3KPAJBZoBStlC4 9EERVyrhyWVtoe2gznGcln5NXrq/pH3L8sLqDMgMlPpGA77s0iBG8M4WvEKSriEO7INKHP+f524 M X-Google-Smtp-Source: AGHT+IGgzFJu020ZVDFJOaUBGqmgiXocPAB8ffUUBJMs4jrthf8Wee4u7s4o7NJ9GYESXPBanDgkdQ== X-Received: by 2002:a17:907:bc4:b0:a68:f1ca:a8de with SMTP id a640c23a62f3a-a69545649bbmr126880066b.36.1717493028989; Tue, 04 Jun 2024 02:23:48 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a68fa8035adsm332061266b.185.2024.06.04.02.23.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 02:23:48 -0700 (PDT) Date: Tue, 4 Jun 2024 12:23:45 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Baolin Wang , akpm@linux-foundation.org, hughd@google.com Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, willy@infradead.org, david@redhat.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com, ziy@nvidia.com, ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com, baolin.wang@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/6] mm: shmem: add mTHP support for anonymous shmem Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: C657F100002 X-Stat-Signature: wgog558kgfw4qz6ss8amc3jpu5ysyf6e X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717493030-940900 X-HE-Meta: U2FsdGVkX18cDvJtt/gG1NB5a4z+d6PJrG8I3HDNZVF+wngGN5zx8JEEW7fZOsqZSRWW6WK5Qlq6BsVkiDZ9rPQsqlw2gcpUjrGS2Sbment+TNQJke/A9lpmDltmvrCWo8IjSHnJgFidQQnCX5rtwfuxVRh/kn1wXJIgGN+vX6BjmIVa/wcKbHc0EciyV9geI3SXt8QU7M5V/t3fpDEDIlKd7cfRKq0ZbZb1nZiPgVGr4+OgzRVXaiheoQlhikBBCv6w3lRVWriY7q7LpYmCEPZLyBpYrtOHvs/cNrgcsd40o82TFq+qhzto3rIhg76yL46DHynuqQY51zcpxLvX4B5O17yYzjkUAX+19XLNCLnoo3At3xxAr5QsMjgUxd453DWVWqJlBboa8yv/3NLAXsy3D9cbl5IsZrvHgEjqgB4CbG3I3Q7IcONXTxYjDpbOU++noK6bQ60XhHJ7+bP7fIywGPVDJSLOHKUX9I2XJ/RldqaOW47doARr3PfnmD78wYUhHfY6UnDDu5iQQ82fGkm3SgQYO378ngTt9aBFLCslmJ+sFHFNFat3x9OwbYvkFiTfX9GnpOxp15ig7hgN5P2hF19leJKF7BD+5daGG1gJJSGAKodlwTQHE78vSV3P1daAiulZlBX1Qp5olr3HmVx++VjnEiLBDQVGgdQsFWuy2KL6igvCSlbW5vChlc3/rlSs2/A1tQKTQ4FrJSn2LU8X4UXvYDfI5Miszt4HkkM+ca5KoHjXO/JOPnm5cyJOWaU7u1wQbX7BpnIaijlI/Ptguww/Wq3tnt8c8pIkhPtwlk+369yIhS9g611s911QEnidcq3R/0F1kGP1oZOmDFJUVNZv51idjqH8faQ6GBljzya6IUmWe0mORnapdFRGhWmBS2kCx+SlYuZ9enw/xsLPrZMRTcuhWb8wjH5miZ5vS4XI6jgpSGlSzIjHpbIfWKlobfBlznTHCwxtjiM szbSVD01 FR2oMXLNslmd52wZr74MWf7oPu3vWRuf+HHdF2QWtIigHo2NabyTdkfVJNjSGWto9nCc0gPRCXdBcOpWhlYRXhIy2y206TVAKrsM0XhVSGpiJ2LbQGfbzK8KczpFgIBwCpYF8g7hWcHV++AjjfqSs6xb8tWjrSIHgFkRMJI+zgQwdQRnodTpBVwtD/iLCCcDydltu+Up3rpYlcKJEHUhQQ+5nB014Fx8Z68gtkRRaydW0txUG26cjHKqc1Pwp0YzMtIkMVR32x5Bg0/kxhaCiAqFApdcPIL4nVYRTuVq1QuT9MpmhgG9rZehzAbQdm6JhxRnyAjI2TPwKKGX/7kwLfM69nTPl71xnHgQdO4JhLCqqkfNYdQeUJqRvEqYmJaUp6zcC0QoRit9ek3yBum4iCeV6Jk6PQcwnyCV5XUnKByH0JjU9u/bMfTuVEIJJ5TlZg5HO+MaXjR6/2AhuXngwaj8eDHoyv1Itwzu1ulGTEKrbj84pB1yUq9MkfAalewoXPOkQbVQhY5rD//os+WJNBXoTNccPX4AyA1xrvs2WcgVl8bTvAHhJF/jgXnIXcnaN1YPKqUtjgrKcpCWuaRQy8IlUieaNY+HCihYmoSsIAaxtVXo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Baolin, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Baolin-Wang/mm-memory-extend-finish_fault-to-support-large-folio/20240530-100805 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/ec35a23026dd016705d211e85163cabe07681516.1717033868.git.baolin.wang%40linux.alibaba.com patch subject: [PATCH v3 4/6] mm: shmem: add mTHP support for anonymous shmem config: powerpc64-randconfig-r071-20240531 (https://download.01.org/0day-ci/archive/20240602/202406020203.14sT311e-lkp@intel.com/config) compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project bafda89a0944d947fc4b3b5663185e07a397ac30) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202406020203.14sT311e-lkp@intel.com/ smatch warnings: mm/shmem.c:1766 shmem_alloc_and_add_folio() error: uninitialized symbol 'suitable_orders'. vim +/suitable_orders +1766 mm/shmem.c ededbc2c2f28a1 Baolin Wang 2024-05-30 1729 static struct folio *shmem_alloc_and_add_folio(struct vm_fault *vmf, ededbc2c2f28a1 Baolin Wang 2024-05-30 1730 gfp_t gfp, struct inode *inode, pgoff_t index, ededbc2c2f28a1 Baolin Wang 2024-05-30 1731 struct mm_struct *fault_mm, unsigned long orders) 800d8c63b2e989 Kirill A. Shutemov 2016-07-26 1732 { 3022fd7af9604d Hugh Dickins 2023-09-29 1733 struct address_space *mapping = inode->i_mapping; 0f0796945614b7 Mike Rapoport 2017-09-06 1734 struct shmem_inode_info *info = SHMEM_I(inode); ededbc2c2f28a1 Baolin Wang 2024-05-30 1735 struct vm_area_struct *vma = vmf ? vmf->vma : NULL; ededbc2c2f28a1 Baolin Wang 2024-05-30 1736 unsigned long suitable_orders; ededbc2c2f28a1 Baolin Wang 2024-05-30 1737 struct folio *folio = NULL; 3022fd7af9604d Hugh Dickins 2023-09-29 1738 long pages; ededbc2c2f28a1 Baolin Wang 2024-05-30 1739 int error, order; 800d8c63b2e989 Kirill A. Shutemov 2016-07-26 1740 396bcc5299c281 Matthew Wilcox (Oracle 2020-04-06 1741) if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) ededbc2c2f28a1 Baolin Wang 2024-05-30 1742 orders = 0; 800d8c63b2e989 Kirill A. Shutemov 2016-07-26 1743 ededbc2c2f28a1 Baolin Wang 2024-05-30 1744 if (orders > 0) { ededbc2c2f28a1 Baolin Wang 2024-05-30 1745 if (vma && vma_is_anon_shmem(vma)) { ededbc2c2f28a1 Baolin Wang 2024-05-30 1746 suitable_orders = anon_shmem_suitable_orders(inode, vmf, ededbc2c2f28a1 Baolin Wang 2024-05-30 1747 mapping, index, orders); ededbc2c2f28a1 Baolin Wang 2024-05-30 1748 } else if (orders & BIT(HPAGE_PMD_ORDER)) { 3022fd7af9604d Hugh Dickins 2023-09-29 1749 pages = HPAGE_PMD_NR; ededbc2c2f28a1 Baolin Wang 2024-05-30 1750 suitable_orders = BIT(HPAGE_PMD_ORDER); 3022fd7af9604d Hugh Dickins 2023-09-29 1751 index = round_down(index, HPAGE_PMD_NR); 3022fd7af9604d Hugh Dickins 2023-09-29 1752 3022fd7af9604d Hugh Dickins 2023-09-29 1753 /* 3022fd7af9604d Hugh Dickins 2023-09-29 1754 * Check for conflict before waiting on a huge allocation. 3022fd7af9604d Hugh Dickins 2023-09-29 1755 * Conflict might be that a huge page has just been allocated 3022fd7af9604d Hugh Dickins 2023-09-29 1756 * and added to page cache by a racing thread, or that there 3022fd7af9604d Hugh Dickins 2023-09-29 1757 * is already at least one small page in the huge extent. 3022fd7af9604d Hugh Dickins 2023-09-29 1758 * Be careful to retry when appropriate, but not forever! 3022fd7af9604d Hugh Dickins 2023-09-29 1759 * Elsewhere -EEXIST would be the right code, but not here. 3022fd7af9604d Hugh Dickins 2023-09-29 1760 */ 3022fd7af9604d Hugh Dickins 2023-09-29 1761 if (xa_find(&mapping->i_pages, &index, 3022fd7af9604d Hugh Dickins 2023-09-29 1762 index + HPAGE_PMD_NR - 1, XA_PRESENT)) 3022fd7af9604d Hugh Dickins 2023-09-29 1763 return ERR_PTR(-E2BIG); ededbc2c2f28a1 Baolin Wang 2024-05-30 1764 } suitable_orders uninitialized on else path. 52cd3b074050dd Lee Schermerhorn 2008-04-28 1765 ededbc2c2f28a1 Baolin Wang 2024-05-30 @1766 order = highest_order(suitable_orders); ededbc2c2f28a1 Baolin Wang 2024-05-30 1767 while (suitable_orders) { ededbc2c2f28a1 Baolin Wang 2024-05-30 1768 pages = 1UL << order; ededbc2c2f28a1 Baolin Wang 2024-05-30 1769 index = round_down(index, pages); ededbc2c2f28a1 Baolin Wang 2024-05-30 1770 folio = shmem_alloc_folio(gfp, order, info, index); ededbc2c2f28a1 Baolin Wang 2024-05-30 1771 if (folio) ededbc2c2f28a1 Baolin Wang 2024-05-30 1772 goto allocated; ededbc2c2f28a1 Baolin Wang 2024-05-30 1773 ededbc2c2f28a1 Baolin Wang 2024-05-30 1774 if (pages == HPAGE_PMD_NR) 3022fd7af9604d Hugh Dickins 2023-09-29 1775 count_vm_event(THP_FILE_FALLBACK); ededbc2c2f28a1 Baolin Wang 2024-05-30 1776 order = next_order(&suitable_orders, order); ededbc2c2f28a1 Baolin Wang 2024-05-30 1777 } 3022fd7af9604d Hugh Dickins 2023-09-29 1778 } else { 3022fd7af9604d Hugh Dickins 2023-09-29 1779 pages = 1; -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki