Re: [RFC PATCH 2/2] mm/fake-numa: fix outdated return value comment

[Mike Rapoport <rppt@kernel.org>]

Hi,

On Tue, Apr 14, 2026 at 12:44:38AM +0900, Sang-Heon Jeon wrote:
> split_nodes_size_interleave_uniform() returns absolute node ID when
> succeed, not zero.
> 
> Fix the outdated comment to match the actual return value.

This should be merged in the previous patch.
 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
>  mm/numa_emulation.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/numa_emulation.c b/mm/numa_emulation.c
> index e7f856c8f2a1..c1d0a76aef64 100644
> --- a/mm/numa_emulation.c
> +++ b/mm/numa_emulation.c
> @@ -214,7 +214,7 @@ static u64 uniform_size(u64 max_addr, u64 base, u64 hole, int nr_nodes)
>   * Sets up fake nodes of `size' interleaved over physical nodes ranging from
>   * `addr' to `max_addr'.
>   *
> - * Returns zero on success or negative on error.
> + * Returns absolute node ID on success or negative on error.
>   */
>  static int __init split_nodes_size_interleave_uniform(struct numa_meminfo *ei,
>  					      struct numa_meminfo *pi,
> -- 
> 2.43.0
> 

-- 
Sincerely yours,
Mike.