From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102D1C35FFF for ; Fri, 21 Mar 2025 11:27:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC999280002; Fri, 21 Mar 2025 07:27:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7982280001; Fri, 21 Mar 2025 07:27:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F3B3280002; Fri, 21 Mar 2025 07:27:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 73FBD280001 for ; Fri, 21 Mar 2025 07:27:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 25AC31A235A for ; Fri, 21 Mar 2025 11:27:51 +0000 (UTC) X-FDA: 83245333542.03.18A8D8F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id E99DE140010 for ; Fri, 21 Mar 2025 11:27:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T4FIth9q; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742556469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FjH3y9m0H0aFP2lC6btVV389x+pkCbjvtz6kIzJXcCI=; b=YySydi6XNU2fXMcyTgkoq53L7wUJEHy1KQh4cr7nbOxugewbYOftAChugsT6PcI0B+o8Mn F43+Wtqk1lKI03G6H7UecL0fLFtp4z/Yx3L40ScUjScHBsPgKkAwr+cKWCWmtKpAL3UF0+ aA4rrQITbQ7YRzk0GuzR0dxqzm04PPQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742556469; a=rsa-sha256; cv=none; b=nL28MBy3RP8qHe9TwoKSHrJFqrqADtaJvVM65ZhK1RKtO+viGOcg46GHPK6PrxRDwpsjH1 y2PQJoZTsGEnUSMU9zYWhUL4685OS7h00YIIYEkXapiKcaD3+E297x/jEBV8iyMwyF7t/l MBLxAqZmCKvBcOBJ1Gao9YrmU97vdMo= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=T4FIth9q; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742556468; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FjH3y9m0H0aFP2lC6btVV389x+pkCbjvtz6kIzJXcCI=; b=T4FIth9qC80djx3m3RJ4Ma6gwHzdVOxWDK1bg+V4BlpdBW2bFzZ1HjdDnGp4xF/X2QevLx NZDWoLaYT0F5fJdlvdkgF1v+YYVMTxbTLHy6/Z7ffcto5Tn/ZrCsjIdzbMgRLWp170KLjx AV3MJmRYvoT1TNyloZcHK3eskwegEME= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-W-kDWbQjMF6tFMwhwdykAA-1; Fri, 21 Mar 2025 07:27:46 -0400 X-MC-Unique: W-kDWbQjMF6tFMwhwdykAA-1 X-Mimecast-MFC-AGG-ID: W-kDWbQjMF6tFMwhwdykAA_1742556466 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43cf5196c25so9092095e9.0 for ; Fri, 21 Mar 2025 04:27:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742556465; x=1743161265; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FjH3y9m0H0aFP2lC6btVV389x+pkCbjvtz6kIzJXcCI=; b=i/VmzXMnEylQ5xiyATR1IL4y30Y3RF4vt8B/502pA8r2y2+Bnc+LQEspqaSgHH15gr gA/cSoKQVAql/SpU6PiOq7DPMSuA4tx6iUJBGhx7+S2cZt2siSy/1laeo94Or1wc8fe0 li3/GGnfIc9yfbi2g531jHXxc1PaCSI1SCp7xrs9zFC5HstZjzbHqQgfRlk1eyxzo3vy usfxP1ajb1heR59xcV+7P0zbSllnQynm4H1CwyoQmxN4EZZ7RGXphB/BaZOGD8jXbkFS ytbS70tLNhBOqu9t4VQKJq0qqhYWhcYnvO/24KReiEuCm0Wwrkxq+8xLkkrmgIdvFJxS tn0A== X-Forwarded-Encrypted: i=1; AJvYcCV6se4ftKAiGRg/gRUKppkVIKvz5opCdGey+hLP0PsX6tNxnpqqx5YomjQ7bM7+sHtj5gISQTJeYg==@kvack.org X-Gm-Message-State: AOJu0YwPfBZgUw4IB6aDwBHaBkNh6V5v+n0hpyIOngslwGTUWOpFatbR BG6aEOHY3xU+XPaugyipblDguoJBnMn7/NBeoRFXYCJ2VEDb5GhXunDdQcrynoeHyweemRF6KD8 nPG90tU28T0CSNJYpejpcwoHxN8B0sVmsoGlq/qUHPNsljtXILQ3GHDuTXn0= X-Gm-Gg: ASbGncs83u964BrDTir9yl7lF60E25cXBCDRVrqwfPRW8wM/7/lW7z8P5WEDqnBq6UK KJo2p5lnWfKAFZzWE7ElXe/gzUViZe4IvsO9EgyvWW5LDEXLVxszt5q/2a+M0Li9xKXPLIrmq5u yFV2IMOmgDRA6/4xHp4HJUrlwhujAUii2i+k66Tpz8+1rut3t2S4ESHcS46flkaH+vDIBpq7Tfu lKHsxR8SlXxbR55DCXVKARaqYpmA2kzgzLXHSv7tQS1Hy9cDqTI7hZa6epGVulBY/yXa5E4nIsv 9ayRTrGdzpTxAElEBjcOVrOzvZcqTVf02VVZBoJLfzWuVhPK6hz32FY2mW6ioXVG4cdOWcMdsdf /pBnvLbSCJW8g93iDK36CJXp73Awb5BEog8oR9u1WDtM= X-Received: by 2002:a05:6000:2a4:b0:391:ba6:c066 with SMTP id ffacd0b85a97d-3997f932dc7mr2725587f8f.35.1742556465503; Fri, 21 Mar 2025 04:27:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFg/cuQvIRoNR4MVFuFpo9AxwX7/33cG0EGBmH4EhjfBtCVl+4Nqdi6+/ZaZIp51gTXMF/EQA== X-Received: by 2002:a05:6000:2a4:b0:391:ba6:c066 with SMTP id ffacd0b85a97d-3997f932dc7mr2725566f8f.35.1742556465005; Fri, 21 Mar 2025 04:27:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c72a:9100:23d2:3800:cdcc:90f0? (p200300cbc72a910023d23800cdcc90f0.dip0.t-ipconnect.de. [2003:cb:c72a:9100:23d2:3800:cdcc:90f0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f9a3428sm2142972f8f.26.2025.03.21.04.27.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Mar 2025 04:27:44 -0700 (PDT) Message-ID: Date: Fri, 21 Mar 2025 12:27:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] Fix parameter passed to page_mapcount_is_type() To: Gavin Shan , Vlastimil Babka , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, osalvador@suse.de, gehao@kylinos.cn, shan.gavin@gmail.com References: <20250321053148.1434076-1-gshan@redhat.com> <0d096764-302f-4b80-a867-22f5302b8045@redhat.com> <5ec97dd6-6561-4687-ac94-41c63ffc82cf@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <5ec97dd6-6561-4687-ac94-41c63ffc82cf@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YztMCMPYDZZ0RBVLFv5MlbNiyNURs3e2Hx9Pn1gpc1I_1742556466 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E99DE140010 X-Stat-Signature: c7mwitf7zrpdjye9698u1trdiijhsp3c X-Rspam-User: X-HE-Tag: 1742556468-523109 X-HE-Meta: U2FsdGVkX1/YJjwjrEwrxeGmpiaj05LJh2u1GN7MYoD80Ahh8TYRqJAbNIW8H3JfA0NCKvaL73An/17IVU4u3bsMfoJMQnjgFxnEaNPqEpdR2rwpVAzYVHI9InGDX/0//oJejbJq8//hB7HrhcndgFlCekUiaKgfzXQ/nntcp+j5+0Ip0YjbutxWPne7dDSBmreI11yVZCllR2UBUaqvZJh9rzcxm4rOen3rskBrzTLAaW0srqAKeAmud4H8Tf+J4m5ZW95Q26hBt6bNx5q/J3g9Z5WzLgyRDx2mifrh+XP6AEm3h7TfHi78vGhvR4wr46CrQkoHvvrclfi7UtNSgcCg/aqA50JV3phSNbEMFKxENTimabktnKw7yFYjQqjrlCeRFBUqQlgOOnbhJ0MaeeJyvLVL89bwTTN8i2Gngg05BAPKTSIZMQQGVFvVy9irHPdUH1SGTf2Erb5i+fb0kT39TIJOJLV9wH4+JjIye4yu8cJQW4YSvvPDpcoaQxTMG6AssDt6Gtu8eKZT3UAz5SAk4t18ZX1TOmakFco4+1k4JKMRAt/D44NkILeYDI14S9hJm08mLLFUQV6UfMIkdcp/mE2D9JfwBD3Oa0g6P8+rkGSMIpOC0ER26bZlS7MRi2EYIMWN1KL1ZDEtpjksD6puxtIufW3XqOpx1KEXb5jnBdECdVxy7f0DWNQSt0oklV2CoWHzgpH8rtrqmvSC/I8prBnwEyZUbdTf/CrrZvznvpdqzWsaCCMzxVpq0PziLtoRYO6+z72l05QkHMxWFaBXXVmpU2ccBjMiIrWvP/HKRKkyHpnC9eLMXRvY7R4xkVyHbLyZHjdJxufBDx/HPiAyJz4L1GndTBHirGVN8B399gLfw8iBT4r1jr7yaMB/yr3Pn4lGCcxHkBd23TheBPkysAYpBzgbtIEEwgWy/ocOuTcBuICj3MmSqf9GSfgDkmj9OhDFtl/fBHPtTtw bhD9COVg 1h+x63wOs9MFarzYQiSm19HdIJGgxmHXHDn93RjfONLFzicf7SS9/qLfgTZUcb5mbRaK5e88dGq7F+u3jq2SMCkdzmgv16p2UrRFPCHmgksHKhw6SoDlH2h4QoackN8QQGpYXlzsFN2SFSElivpTZjjx+usoGkVdqlszXUZCiu5EDEmeno9iIB11SZUAC5EtHQ7qZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.03.25 12:25, Gavin Shan wrote: > On 3/21/25 8:11 PM, David Hildenbrand wrote: >> On 21.03.25 10:23, Vlastimil Babka wrote: >>> On 3/21/25 06:31, Gavin Shan wrote: >>>> Found by code inspection. There are two places where the parameter >>>> passed to page_mapcount_is_type() is (page->__mapcount), which is >>>> correct since it should be one more than the value, as explained in >>>> the comments to page_mapcount_is_type(): (a) page_has_type() in >>>> page-flags.h (b) __dump_folio() in mm/debug.c >>> >>> IIUC you are right. Luckily thanks to the the PGTY_mapcount_underflow limit, >>> this off-by-one error doesn't currently cause visible issues i.e. >>> misclassifications legitimate mapcount as page type and vice versa, right? >>> We'd have to have a mapcount underflown severely right to the limit to make >>> that off-by-one error cross it? >> >> Agreed. Likely not stable material because it isn't actually fixing anything (because of the safety gaps). >> > > Yes, it shouldn't cause any visible impacts so far due to the gap. > I just found the issue by code inspection. Lets drop the fix tags > in v2. > >>> >>> I wonder if a more future-proof solution would be to redefine >>> page_mapcount_is_type() instead to not subtract. But I'll leave that to willy. >> >> With upcoming changes around that, likely best to leave that alone. I expect page_mapcount_is_type() to completely vanish. >> > > +1 to remove page_mapcount_is_type(). After Willy confirms, I can post > an extra series to do it if needed. I think we should only do that one Willy splits struct folio off from, struct page, storing the type elsewhere. For now, we should likely just leave it as is. -- Cheers, David / dhildenb