From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DB8D6EC15 for ; Fri, 29 Nov 2024 14:44:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AFC26B0083; Fri, 29 Nov 2024 09:44:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 95F266B0085; Fri, 29 Nov 2024 09:44:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D8C86B0088; Fri, 29 Nov 2024 09:44:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5B1A26B0083 for ; Fri, 29 Nov 2024 09:44:27 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id ED46940DAF for ; Fri, 29 Nov 2024 14:44:26 +0000 (UTC) X-FDA: 82839402744.20.747E87A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 92C36120013 for ; Fri, 29 Nov 2024 14:44:12 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eQDklMsX; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732891460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QeUMTmns+Qd13SnAS5HSZCKej4V2Qr/wJfM4unvoo40=; b=g+YDYARfnA+AKbd3SdLHdt3n4srwh+AW9DJ+uDEl5af6jSZOKLs++t+Hel12DU5SHcUuGd n44SArc40L7ufRI8eZg6HSUjMGLTn20Vw6Pn103exSWNAz/N4oycpcnpb17k8dpDoW3xe7 EKCwMF/MUZcVCuIU3HBvWChp66I3hg0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732891460; a=rsa-sha256; cv=none; b=OFra50bJEzmRj85gDqUNz4Csxx5cjlFyCZCT1GYA+cFuzHZJhmjk7DzdfHWlSYvfetJr62 RdOHnxKYxLY0kaZOhpoc4SjoE8xzQCVLxVWaULEWspDJAMb0utUXvzOje2MQEogC7Zjill p0E4iYPuBlmjuu94Wm/Pe4YazdBgEbo= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eQDklMsX; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732891463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QeUMTmns+Qd13SnAS5HSZCKej4V2Qr/wJfM4unvoo40=; b=eQDklMsXmNIa7uvtv2PhNcOsTQDiFpGo4KAzcv3eODdU5j/B03NCNVeqyOlrz1pIl4YA3W LrPDx0WFbnS73DpHaelkBggUiIOZg8twH/B2cfbmceJZuD4l+HvEoTYv4PZy8OxQ9UcSk2 q/uPBkI68V6HpA/vXhdYCrV3sUqm3Xc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-IM7npQXLPDmmIBhXX8gjSw-1; Fri, 29 Nov 2024 09:44:22 -0500 X-MC-Unique: IM7npQXLPDmmIBhXX8gjSw-1 X-Mimecast-MFC-AGG-ID: IM7npQXLPDmmIBhXX8gjSw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43499c1342aso14735345e9.1 for ; Fri, 29 Nov 2024 06:44:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732891461; x=1733496261; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QeUMTmns+Qd13SnAS5HSZCKej4V2Qr/wJfM4unvoo40=; b=uMSz165lQMH/Fda3GRfetAw0AnUC8+hCsBgJZ4d2S5SysOnZS2x7xYIdQOFRlU5z06 0RYV4AuHLrL2ESmcuBAzbO/7tSFIXzzFMfyy+4PF4XD+fEj6vdVZC0DnCH1fZRKJsoyz cR6nnqiNztfHsOzSkgExCte0QeqUME3ePB5iD0IrZ+4P8TZIRv8T5pPyoqdPuasj1Pme e4U9glMfAOaorcer9UEjHHzldqwubyTbYXXQRXK/5hrkBatG0u0LgHg0j1dT2TiZeFcp 5gkxk2eV/i9i460f2mX+hSPf8j/kIeeT4hU1j8dEtUxwj5Q5ZeCUTJ7B+cECDtDFAOCc 9vDg== X-Gm-Message-State: AOJu0YwWnGv8EPfoVRFrFs6lafu/yAZSQ7Xkf5ybCZA/juHmOy3sPxSw zwaqv1Z1L0ZIW+1jUdDCYu/FMtWI1rNexzS2s6pVEHFxEQMfcVbem8YfCRCdRbOqACwVUZRyt5K DmeqrE4mtAr2+i56GyvRyKCBp1zOBd/UXVkuyWDAPXOGKdINb X-Gm-Gg: ASbGncsC5A6DLnFriae/l3CMDKo8TCAxbibEutxNMK7T/0AXjv5aoH8rSdzTOZpUuD8 9ys4RWoj0zSXfPBBsRDYlMj3WBQiF42HQcFYxrjEIV8Is8Q/wgSYFa/w5gD5xZBtWfv5lP4neF5 v7t5RALogz7gB0JRqzItGZbqrB8evAf2oT9QHJv30CyyxzDequ/Vt4buuSH/yHl3c4qAPJXof1Y arE4l+c82gPaEEmV5NwyIIny02hgWlzHe3wffYBezqeWTJOm5hcPBGFXSoyc2W4Z+Vp1b0ZzwFO RgUSeua3zy8MVCv2AXaPwS6i6X9uUoAD5wFah0lNPAEqfGHILwR4YCb+ZGd23QCU0MRPDOcWpYT +QQ== X-Received: by 2002:a05:600c:4750:b0:431:60d0:9088 with SMTP id 5b1f17b1804b1-434a9dc5241mr113514845e9.13.1732891461215; Fri, 29 Nov 2024 06:44:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGWem08wzZaxz4oSo92bk9IyygMCow/L12vjRUwanjW49Oi9SiPhXoLFSCBQUb0EQJOS6JAoQ== X-Received: by 2002:a05:600c:4750:b0:431:60d0:9088 with SMTP id 5b1f17b1804b1-434a9dc5241mr113514585e9.13.1732891460842; Fri, 29 Nov 2024 06:44:20 -0800 (PST) Received: from ?IPV6:2003:cb:c71c:a700:bba7:849a:ecf1:5404? (p200300cbc71ca700bba7849aecf15404.dip0.t-ipconnect.de. [2003:cb:c71c:a700:bba7:849a:ecf1:5404]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385dc169d79sm2718462f8f.92.2024.11.29.06.44.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Nov 2024 06:44:19 -0800 (PST) Message-ID: Date: Fri, 29 Nov 2024 15:44:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 14/15] mm/mempolicy: Add alloc_frozen_pages() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, William Kucharski References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-15-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241125210149.2976098-15-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uQbTgPnq3aKwchMoUBr0PMUaHJXCNTfCWNp_xVC9Pg4_1732891461 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: hek13kkbbtxy4fi31jot5byr893mhkms X-Rspamd-Queue-Id: 92C36120013 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1732891452-767019 X-HE-Meta: U2FsdGVkX1+KMQAo/FiBAqEDmbg4/nx6y6qZSOyWpluuqQy0RTuBcrBDTUutQthX6gepuKaGaxhiJ2QoA2plStLQdW5jaL8t9LRbHzf1YRa20B283QuxE38irdFcclFvMP6C0Bj3s1xVqC6udeDUlq0LfTi1K8ZAXS83fiC3CJcZWYgvP2SnpJT8BOG9qUFcB3KXoF4/jbm4OhuTN9aqVzWd1ebNpBNmiSrKUYXtP0DDThtqowac+jwpy6BYOVv6zmJ8qmPOMKoe/H7ApWFBTETrf1NxFWMFzDBKka9nZsTq4gH0NbkJfKeziaGcATPDtF8Z5lh9RBOim5v/LhSiED6FwmvMHmLNx/szrlOlBfcZpjF2MH6sZVUmGWla0wMzRlg6cVthauSPP4kcy+j9nCrme+OX8KrbEGUiX/NZOlpSiXczt79FcVwCmEKcWDZW9fgh4NPQlK6plHmcJ3ES9rS8OQroCsViYMWE+MkTwP+kxRDiqKe8svwAw2tB+P8Tkpv2sD7zSDmnLmPNxDyQiFHIpzRagj+/FVfK1FheIphBvzQohf2kc4u5Xi+UKZjNZpziWHnU5LnWwAJlrzyjwbFjCR8nVenJ+Gn7lSkXtknfZj34xni70T6H+eBQWX+XFzK90Gc3PBgyAexn9oaMptdJweqKiiuLTt/LmN+OT/1YvypCgLLEVsmnTKtTAbBkiWzS3olgzy1IfZE5HFJt9r8ycwJGRXJS494NQIcBOpzzTnSCBAVRDu2A5YhXVmmzg+VRmF9TQw+CRwWEpNEt3rcR30QWPiAv14Csxcq8gG+aBafBtdWWjocv4Cd3V4szXK8J6Dw4HyQKPBMVKC+bu2UER5rOmyivg5cEdMpF43eIUC3Wtw6o02k7QYFX5UL9Jki7A89xEXM2+7atIIsvg8UUyyqx5LgjSVErJ6x/yWxwfDVlKkyPX1eot0uLHSJhtxudpIzljvEB/3tPoIQ Oh6Z1bPo UjmG7XtZF7HV/Kv+88fdSdgAeTXaJNpQaSrlI2KfRYv8P2VHfzYHy9ns5uI2o/mcB1HRe281z/f09TDCRvPlwG2kT8H3obTmTGM7S9fOQvEFrLDbZC+IqZykLqhpjaBSxFQUpiJxYTNMptM7vkhRQMsYLPPBy/BnnpSzjgyCbD5kMpntVvbC//4L2DYBdRaNpaT2RHHlz8ZyxpzDe5joPOeAg9HTmC+D66bTwpQniEyYrXvIIYp5dGLGg/+uAFDNqNLraoVxMKg5Spa46o/LJFnC5d5s54F6WOoAVgVmUlpi1nQNCcPR2jX3Hb9D3LuZvQsfGZFQIN4884RzKYRH/tw6m4x0gua5j9hRyBUIvo4iCCXI3BE1KtnQ/g1mjxpc2t13oPIZkb58dX5ReOnc2YBg49NTnOSfk7BJVBXpA8FRnjZ0fLeEYR86UW5OKd7cupdFcz6B10XMxycyx1U7osJgCS1C6H8fJLnKzO4+T9sXQluFcrT9bvKkGX+E52f13x9aoAvRQS2/7LeLpz1YE7EBWJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.11.24 22:01, Matthew Wilcox (Oracle) wrote: > Provide an interface to allocate pages from the page allocator without > incrementing their refcount. This saves an atomic operation on free, > which may be beneficial to some users (eg slab). > > Reviewed-by: William Kucharski > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/internal.h | 12 ++++++++++++ > mm/mempolicy.c | 49 ++++++++++++++++++++++++++++++++----------------- > 2 files changed, 44 insertions(+), 17 deletions(-) > > diff --git a/mm/internal.h b/mm/internal.h > index 55e03f8f41d9..74713b44bedb 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -747,6 +747,18 @@ struct page *__alloc_frozen_pages_noprof(gfp_t, unsigned int order, int nid, > void free_frozen_pages(struct page *page, unsigned int order); > void free_unref_folios(struct folio_batch *fbatch); > > +#ifdef CONFIG_NUMA > +struct page *alloc_frozen_pages_noprof(gfp_t, unsigned int order); > +#else > +static inline struct page *alloc_frozen_pages_noprof(gfp_t gfp, unsigned int order) > +{ > + return __alloc_frozen_pages_noprof(gfp, order, numa_node_id(), NULL); > +} > +#endif > + > +#define alloc_frozen_pages(...) \ > + alloc_hooks(alloc_frozen_pages_noprof(__VA_ARGS__)) > + > extern void zone_pcp_reset(struct zone *zone); > extern void zone_pcp_disable(struct zone *zone); > extern void zone_pcp_enable(struct zone *zone); > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index cda5f56085e6..3682184993dd 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2201,9 +2201,9 @@ static struct page *alloc_pages_preferred_many(gfp_t gfp, unsigned int order, > */ > preferred_gfp = gfp | __GFP_NOWARN; > preferred_gfp &= ~(__GFP_DIRECT_RECLAIM | __GFP_NOFAIL); > - page = __alloc_pages_noprof(preferred_gfp, order, nid, nodemask); > + page = __alloc_frozen_pages_noprof(preferred_gfp, order, nid, nodemask); > if (!page) > - page = __alloc_pages_noprof(gfp, order, nid, NULL); > + page = __alloc_frozen_pages_noprof(gfp, order, nid, NULL); > > return page; > } > @@ -2249,8 +2249,9 @@ static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order, > * First, try to allocate THP only on local node, but > * don't reclaim unnecessarily, just compact. > */ > - page = __alloc_pages_node_noprof(nid, > - gfp | __GFP_THISNODE | __GFP_NORETRY, order); > + page = __alloc_frozen_pages_noprof( > + gfp | __GFP_THISNODE | __GFP_NORETRY, order, > + nid, NULL); > if (page || !(gfp & __GFP_DIRECT_RECLAIM)) > return page; > /* > @@ -2262,7 +2263,7 @@ static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order, > } > } > > - page = __alloc_pages_noprof(gfp, order, nid, nodemask); > + page = __alloc_frozen_pages_noprof(gfp, order, nid, nodemask); > > if (unlikely(pol->mode == MPOL_INTERLEAVE) && page) { > /* skip NUMA_INTERLEAVE_HIT update if numa stats is disabled */ > @@ -2280,8 +2281,13 @@ static struct page *alloc_pages_mpol(gfp_t gfp, unsigned int order, > struct folio *folio_alloc_mpol_noprof(gfp_t gfp, unsigned int order, > struct mempolicy *pol, pgoff_t ilx, int nid) > { > - return page_rmappable_folio(alloc_pages_mpol(gfp | __GFP_COMP, > - order, pol, ilx, nid)); > + struct page *page = alloc_pages_mpol(gfp | __GFP_COMP, order, pol, > + ilx, nid); > + if (!page) > + return NULL; > + > + set_page_refcounted(page); > + return page_rmappable_folio(page); What I don't quite like is that we now have a bit of an inconsistency, that makes it harder to understand what gives you frozen and what doesn't give you frozen pages. alloc_pages(): non-frozen/refcounted alloc_frozen_pages(): frozen folio_alloc_mpol_noprof(): non-frozen/refcounted alloc_pages_mpol(): ... frozen pages? Ideally, it would be "alloc_pages": non-frozen, "alloc_frozen_pages": frozen. The same concern applies to other internal functions, like "__alloc_pages_cpuset_fallback". I'll note that that's one of the reasons I thought of having GFP_FROZEN instead (function name doesn't really matter). The only ugly thing with GFP_FROZEN is that we still need separate free*() functions. Well, or detect during free_*() that the refcount is 0 and assume that it was an frozen allocation ... Anyhow, if we could make this more consistent, that would help. -- Cheers, David / dhildenb