From: Vlastimil Babka <vbabka@suse.cz>
To: Rongwei Wang <rongwei.wang@linux.alibaba.com>,
akpm@linux-foundation.org, roman.gushchin@linux.dev,
iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org,
cl@linux.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hyeonggon Yoo <42.hyeyoo@gmail.com>
Subject: Re: [PATCH 1/3] mm/slub: fix the race between validate_slab and slab_free
Date: Tue, 19 Jul 2022 16:21:32 +0200 [thread overview]
Message-ID: <ad258412-2f8f-8e15-fbd0-c0933aeb1a6d@suse.cz> (raw)
In-Reply-To: <5344e023-29f0-9285-a402-19e2a556dbb0@linux.alibaba.com>
On 7/19/22 16:15, Rongwei Wang wrote:
>
...
>> +
>> + slab_unlock(slab, &flags2);
>> + spin_unlock_irqrestore(&n->list_lock, flags);
>> + if (!ret)
>> + slab_fix(s, "Object at 0x%p not freed", object);
>> + if (slab_to_discard) {
>> + stat(s, FREE_SLAB);
>> + discard_slab(s, slab);
>> + }
>> +
>> + return ret;
>> +}
> I had test this patch, and it indeed deal with the bug that I described.
Thanks.
> Though I am also has prepared this part of code, your code is ok to me.
Aha, feel free to post your version, maybe it's simpler? We can compare.
next prev parent reply other threads:[~2022-07-19 14:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 8:15 Rongwei Wang
2022-05-29 8:15 ` [PATCH 2/3] mm/slub: improve consistency of nr_slabs count Rongwei Wang
2022-05-29 12:26 ` Hyeonggon Yoo
2022-05-29 8:15 ` [PATCH 3/3] mm/slub: add nr_full count for debugging slub Rongwei Wang
2022-05-29 11:37 ` [PATCH 1/3] mm/slub: fix the race between validate_slab and slab_free Hyeonggon Yoo
2022-05-30 21:14 ` David Rientjes
2022-06-02 15:14 ` Christoph Lameter
2022-06-03 3:35 ` Rongwei Wang
2022-06-07 12:14 ` Christoph Lameter
2022-06-08 3:04 ` Rongwei Wang
2022-06-08 12:23 ` Christoph Lameter
2022-06-11 4:04 ` Rongwei Wang
2022-06-13 13:50 ` Christoph Lameter
2022-06-14 2:38 ` Rongwei Wang
2022-06-17 7:55 ` Rongwei Wang
2022-06-17 14:19 ` Christoph Lameter
2022-06-18 2:33 ` Rongwei Wang
2022-06-20 11:57 ` Christoph Lameter
2022-06-26 16:48 ` Rongwei Wang
2022-06-17 9:40 ` Vlastimil Babka
2022-07-15 8:05 ` Rongwei Wang
2022-07-15 10:33 ` Vlastimil Babka
2022-07-15 10:51 ` Rongwei Wang
2022-05-31 3:47 ` Muchun Song
2022-06-04 11:05 ` Hyeonggon Yoo
2022-05-31 8:50 ` Rongwei Wang
2022-07-18 11:09 ` Vlastimil Babka
2022-07-19 14:15 ` Rongwei Wang
2022-07-19 14:21 ` Vlastimil Babka [this message]
2022-07-19 14:43 ` Rongwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad258412-2f8f-8e15-fbd0-c0933aeb1a6d@suse.cz \
--to=vbabka@suse.cz \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rongwei.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox