From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E49F8CD11C2 for ; Sun, 7 Apr 2024 13:44:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D73C6B0085; Sun, 7 Apr 2024 09:44:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 560476B0087; Sun, 7 Apr 2024 09:44:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 400856B0088; Sun, 7 Apr 2024 09:44:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 224206B0085 for ; Sun, 7 Apr 2024 09:44:11 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CBF59C07C8 for ; Sun, 7 Apr 2024 13:44:10 +0000 (UTC) X-FDA: 81982854660.07.6978444 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf02.hostedemail.com (Postfix) with ESMTP id C239280004 for ; Sun, 7 Apr 2024 13:44:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DWw0NREs; spf=pass (imf02.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712497448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vMqdQCAzDlHOX8MsoDGfkIgox0Bxd5XntMdzXg60cqY=; b=rB1hKpbZurRDJcmrV2gVvkNh2rGJr5QN8hUahN8n67vRZNVee5i3DdvlheG2Ur894Q7vM8 rtcBvGH+4w4Rd0hi0wG3f9jICSoXSUXKyGoYhsei3a8J951D4026Avv4auEmMNHXPWUo0l H3zo0xNFv+r+4cFAX8WB1Z/cm3xh8ZY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712497448; a=rsa-sha256; cv=none; b=hTje4g/dgxWvBFcM5fQO40wL7VZNgcDKqU3HcaaVbbNU+DKmRKbLKnakS2GSOfgK52rcdB z/BfYvxLg0ThW4kSLcPiIwm4EkioaPvlhwKhYKqa+z1FV7r3u+NVmSuvxxIMNJ46YTelyp knceWj1f6kSW5o2P8EBC0ar7y3udHfw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DWw0NREs; spf=pass (imf02.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-516c403cc46so6481069e87.3 for ; Sun, 07 Apr 2024 06:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712497447; x=1713102247; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vMqdQCAzDlHOX8MsoDGfkIgox0Bxd5XntMdzXg60cqY=; b=DWw0NREskNCjsL3BVnykN8jPVzcrGfKl7e3mIUKugP+OJ9w2Mm9GBOjCrmZOa0Pba5 +Ks7Cx9fcmIzfqdjA6n3u8EvHM4CMflbnhpdtgK/qH8uOIMYfkDY9IEkkA188Adhhe5T xSd1DNXnzURAGgOEpvx8p2/QytOku/VPbhVn2zn+EFja0N0RdwxVn97Gt4JbtJyPY5sp TjnZDEB2vIea1D6584X39JaQExH22VU255nYOMg1lctVogQDIegSLYbCX0JxoxvfaX0P AccFYxDzj9rK3LSeXjuNugdsxXAquJBUuQ0RPSZsUXdvBFiwiU4EKEiYI78oygp6TpWd SgCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712497447; x=1713102247; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vMqdQCAzDlHOX8MsoDGfkIgox0Bxd5XntMdzXg60cqY=; b=s9io4RH4Vopz5xg4i5uE94nrDACSPq7FVUZGdE8quqXz8KWzNChSqBQzXZ3BRYUVjh 4/S+pzuCl+JlFZ+QPKsAGV2LdY777z6fwPtUslqjsO+3FBKiuIbkgJC6hBVJf570yZS8 mGc6OIqWViVA8VZvtjEzql/oGJBvRdNDIX0ruvx8IHF02RZ5ZmUDogo7h6R9Xyw3szAJ njGEqS5Kq+/hQSiFNLEFgTdH8St2YIqngPCVIFpShkt5v5MC5BXOpVkA75YBbjwUhJr5 hs8+Eltl/O7haPbUmCk2G7r2UQ2B0e53gVkpLbIoxVkKU2zgQzq9dJElwJr6g1C14NcE WufA== X-Forwarded-Encrypted: i=1; AJvYcCVcCeQ2dl2YjugPVJ7MvMdrek3rpDTmRP+8vgkmN7VbdkZ8QWS6y+uZspn+FmpzrDUQ2266xTGn4zZ+JyMbaA7pasc= X-Gm-Message-State: AOJu0YzmD4sjaIngi254d0FZ9XBel5aF6AyruRlEXVkulYjH1uo21BnK BY0DIEOBPTx5JGaeuWxw2XT3ZIBrKw1mstsbDPv/YxijZbO0e6E3 X-Google-Smtp-Source: AGHT+IE1tiO7siqzwDY0v+GklkSmpzuhad4k1luOgBNgpb3uenlVhwlfg4Y/viQAF8R6/S24mcdO8A== X-Received: by 2002:a19:ee19:0:b0:516:cc2f:41d4 with SMTP id g25-20020a19ee19000000b00516cc2f41d4mr5209382lfb.25.1712497446573; Sun, 07 Apr 2024 06:44:06 -0700 (PDT) Received: from ?IPV6:2001:678:a5c:1202:2659:d6e4:5d55:b864? (soda.int.kasm.eu. [2001:678:a5c:1202:2659:d6e4:5d55:b864]) by smtp.gmail.com with ESMTPSA id n5-20020a056512310500b00516cd482c44sm799770lfb.198.2024.04.07.06.44.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Apr 2024 06:44:06 -0700 (PDT) Message-ID: Date: Sun, 7 Apr 2024 15:44:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 13/37] lib: add allocation tagging support for memory allocation profiling To: Kent Overstreet Cc: Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, "Peter Zijlstra (Intel)" , juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, Nathan Chancellor , dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, David Howells , hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org References: <6b8149f3-80e6-413c-abcb-1925ecda9d8c@gmail.com> <76nf3dl4cqptqv5oh54njnp4rizot7bej32fufjjtreizzcw3w@rkbjbgujk6pk> Content-Language: en-US, sv-SE From: Klara Modin In-Reply-To: <76nf3dl4cqptqv5oh54njnp4rizot7bej32fufjjtreizzcw3w@rkbjbgujk6pk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C239280004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1yyuqawtj5ua3nuk9k6qw1ik698craxj X-HE-Tag: 1712497448-980445 X-HE-Meta: U2FsdGVkX19vNCvZsj1z+m2HWiGajl6Zi6SquYQPi+b8kSkvN3iCP5HZWWvywd1lUID0YBRcojHWX1y2JdJ6l+qkAqc0wpmQMYBZVMGJymBx+XdMAF23Nq9YQSTJ6NfRMQrzTl//KtaOHUJAWMFZ3jB3WIOXskwZiyDCFhNwD/XV6NenffAeBHEX4he9iLE0PSsSw9p7kePNs21vIlBnk34jLWEx8KImjv+UVHeN4xCBWclKzy5hoTfy3biDNg1+Ti1ni+dFpN5xa/Kvp+LDUEiERssVoWWchpsHC/df07+eMVOvUB9C3/+gMEOSUapJaQEatoPDecTVTjmHmzj4HlEaFXaMaErjQtNOpM3Hh4GrERgyypvESWxXSClAvlxkc8myKfJDSyQCGecwNPO6jDazvZdDkT5pTQZFWwLHghvW4eL2aeyZvz/tr27PBMVSkUfHlLdCKlhucZKiHssFDDrRbrCu1qQfwNvfH685XZ4J0yD72/vtFz/bJYOTzr5cQJnidSOI8C1IFECirVLhYqyi9od+CnvJms50kPsl8uGYTdXSvP4PC/9Mqn22X3t5bzO59L04tNErVQORVVvjX+ngZDwcihH7cOPttwm6HXgWpl9lNsrt3CR8apMZmdCiJJb2mP8da6qwHiTpygKryYVUlk9zVnr7H4eUE8UUT9z1dXha7vQpxzfskU8JzfFylxxJa7lywpdCrt4lTVSbN7VaBs//5l5drkJ2Pum3pmOED++SMeQpj8itNiKBUpx/+qd8Jp8pgGHIO4MltHjBG8QCR7QRb5bm4EicYAb6pKk7d141aR6ddzm/Q9tGdOB7f84fXIHm5801tYNyV0HR/nG0qtWWpyTFS2gc6ShHPqWqhCTotI7Hn4vhsbwISplC5O+0KLUl/aBRNalEsWVRN7pAvI9DEPFhg78CeIUXSnDIgdEIl1f1cnQKw8rN4GkKDfbDKPjypvvSW1i4v/W 7LvFmS2l 52R7f66WyMXFQUGD4J0gYDyLHPq9uUWpWJCyxUhCi9sakc8g4J7CuIntGvxPmkYVdfWS2As2uPmGRckKdaWe6EnPa/nAJaU7MaNhVoxLd8ot4bL2JAv72ca/Ln6TYsLZwrbWTM0ndoLRSkcjWXtYw+m6SzK/C9gtWJDrjZwgL8t369ESR8XDVDQdChxL5PYncdNjq7VA65cGQucnY7wotB0ffFESrOHxdGiVGQhf71000OXhNoqy+NIRzNdE/kemzmv+Th4duIa4nlG/4mKBvMzltYOnZ5vPTQPOjnvgd63fruqvTFccngs3NP4oIiM/cZbxWTEVx3i7TVB7OefZRaH4c5NL9tQIMyar+QNRyz0Z00km5AOXd1vyt9EQewgdT2zFAC+EUV7nJhoG+4hE05z8KBKyG9AkmzlBi5TYR56VHkZrJ1RHyRJSyF7O/sWJtnx6kPx1EjGtheVEezfmsIxPFuZoCvRD8Okxgz3GmQLzGOZbElJt/QJcLWwFD03r3O41xBI0kfyZDMV8A+40c/yix7+jSFLNnGbbe4/PlatiBJJ5agAV2hqhFnxlZFnD5DFVDhbwNu2ttB+sOFIK6g8ELwdB4FBMEcX4w5ks/v5YmvvGCS2cRPr5XdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-04-06 23:47, Kent Overstreet wrote: > On Fri, Apr 05, 2024 at 03:54:45PM +0200, Klara Modin wrote: >> Hi, >> >> On 2024-03-21 17:36, Suren Baghdasaryan wrote: >>> Introduce CONFIG_MEM_ALLOC_PROFILING which provides definitions to easily >>> instrument memory allocators. It registers an "alloc_tags" codetag type >>> with /proc/allocinfo interface to output allocation tag information when >>> the feature is enabled. >>> CONFIG_MEM_ALLOC_PROFILING_DEBUG is provided for debugging the memory >>> allocation profiling instrumentation. >>> Memory allocation profiling can be enabled or disabled at runtime using >>> /proc/sys/vm/mem_profiling sysctl when CONFIG_MEM_ALLOC_PROFILING_DEBUG=n. >>> CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT enables memory allocation >>> profiling by default. >>> >>> Signed-off-by: Suren Baghdasaryan >>> Co-developed-by: Kent Overstreet >>> Signed-off-by: Kent Overstreet >> >> With this commit (9e2dcefa791e9d14006b360fba3455510fd3325d in >> next-20240404), randconfig with KCONFIG_SEED=0xE6264236 fails to build >> with the attached error. The following patch fixes the build error for me, >> but I don't know if it's correct. > > Looks good - if you sound out an official patch I'll ack it. > I gave it a try and sent out a patch [1]. This is my first time doing that and it's likely not without mistakes. 1. https://lore.kernel.org/lkml/20240407133252.173636-1-klarasmodin@gmail.com/T/#u