From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 765D4C43381 for ; Thu, 7 Mar 2019 00:17:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B7C320675 for ; Thu, 7 Mar 2019 00:17:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="jHiVPwWd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B7C320675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A4DDD8E0003; Wed, 6 Mar 2019 19:17:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D38B8E0002; Wed, 6 Mar 2019 19:17:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 826DF8E0003; Wed, 6 Mar 2019 19:17:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from mail-yw1-f69.google.com (mail-yw1-f69.google.com [209.85.161.69]) by kanga.kvack.org (Postfix) with ESMTP id 5380E8E0002 for ; Wed, 6 Mar 2019 19:17:56 -0500 (EST) Received: by mail-yw1-f69.google.com with SMTP id 200so18486054ywe.11 for ; Wed, 06 Mar 2019 16:17:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=1SSZKMewF3WkzE1mzuK0CNh8oEr66tJRi9S895bMdCU=; b=Oq1FLwgnvCMA+l3PVolkxvppjd3VZV1x2JCeGHInpcumXiaDyxjYVXw/B5fuXLQsC2 fLJzt8o5KUH7t3+TBRtt4QBWMa1Rf99kBs2CznShHG7Ftif6gpHVn0Tcdd/s6fsV0FL6 imV8BQ2pddNvV0DjX/objoOYnjGQzziSNT+iv8k/slh2OoKTq0fLGP8NoPQuKZ7VJDAB V1t/jBy+arYjghF46LqenMOcQ3Rh+wzPqIUHCQDzNMC72d1veYn4grIzp0aVa/z7H9HG I0dnaTBBEqeU0cNmnvbf6Rw0ZEeoSl/EkPF/IsQvwx7NYptbehsDQljhLNMonM6MAFNs EHaA== X-Gm-Message-State: APjAAAWsZMkeCfe9F29nHeiWBu4P/rHqC8Ykxj4WNLw03u1ZWu39hXId ayvNKHRFgc0IbnVZz7YggWjcTIPlaNkchyn3RK7pqrQrvy+3nNd8FNLqtgjhpdumC+ZuCnReBXZ cl59h+esbtylv+o3inV+CAFWrKhNPepPpEUC4lTCyVxs1AMZo5TbtDvWAEd+swhoQwg== X-Received: by 2002:a5b:bcd:: with SMTP id c13mr8199159ybr.318.1551917876019; Wed, 06 Mar 2019 16:17:56 -0800 (PST) X-Google-Smtp-Source: APXvYqz+6xbeQs9VKPb/ZwI7+OrQjtx8PRA7LsrUqBqHF4KGuf1J+drKhnZWs9AB8CpU5NER8el4 X-Received: by 2002:a5b:bcd:: with SMTP id c13mr8199118ybr.318.1551917875149; Wed, 06 Mar 2019 16:17:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551917875; cv=none; d=google.com; s=arc-20160816; b=xLbqD9B9H5+M0u3u8DB6u57r8PT+mFmirlG9/V2E0d4m1DO1fQY/omA26GUNjgLCVo RzVZ5l3a+lSiZA0Korp0piLaClP2CwQRHOHc2s5vQPITC5z4uC/NTscs8a/+I0UXcrEB Zv3mma/eT0+Pm1aVn50ar8bOVb40883Rx6iKF1kyu8svPMkBZAPZutIZjrJjooEtI7bK 1Ar6XJeRks+UkHAIVr5jbaxfXvmC80EPAdNVzTHgcS4Kp9jqtxjGd1FK8wS6FXS6nUCC bqKrxWftvmIQqqtygsh5hoTFd6wWy7OoCKguzqsPAqf0a+YptjpcfOkMHRf/OEd01pAM xOwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature; bh=1SSZKMewF3WkzE1mzuK0CNh8oEr66tJRi9S895bMdCU=; b=JeQjLL4HQcpfFQ0z3lEI173wwUVHeLgaDAPOmIf33HfuMdcdPI5qV3Z7RWUoaG6xg7 0LFmMoqD299okxamNcrD3gT1dcKd75Vxj0YlQTxjQjz73V2nbtqXmrJxKHhNe8q0KVxN QH8n5Ot7Z7gdXghg1Uu44kDlegPQ9V1jYs9Bh8myXo3UC6g4CanztYEmekh4vGaBf8r7 ole11F56p5WFfuzqXtAkNjHN9brVFZCVkTL4s/8rwgqcHHmAUpiix5zC2XSscOU3NfPr HJHh1jeUJRA0V1T135ueXiSZDBKj4Rw0KmoaoWaDUo4zZZElS1ktjonYHAPrfMsDznsA J1kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=jHiVPwWd; spf=pass (google.com: domain of mike.kravetz@oracle.com designates 156.151.31.86 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from userp2130.oracle.com (userp2130.oracle.com. [156.151.31.86]) by mx.google.com with ESMTPS id b83si1800474ywb.306.2019.03.06.16.17.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 16:17:55 -0800 (PST) Received-SPF: pass (google.com: domain of mike.kravetz@oracle.com designates 156.151.31.86 as permitted sender) client-ip=156.151.31.86; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=jHiVPwWd; spf=pass (google.com: domain of mike.kravetz@oracle.com designates 156.151.31.86 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2704Z8n124182; Thu, 7 Mar 2019 00:17:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=1SSZKMewF3WkzE1mzuK0CNh8oEr66tJRi9S895bMdCU=; b=jHiVPwWd3BlJYp8fneR7mB+nGICQf8Gt+VHVCBAsjGYPW2f8giLaYJgCve0Iai3Id0On EUGrVJOcF0WvOaSF2KkAC7hqwLlE67FcXBxR3ysYCzQTHI/jfBmH7xy5xiG1VaQaiBWr raSoliwOmnDSfjEZpIA7/OXYjT3yxjYg9uHCgEuS6RZo6vO/bk0B2wKGARi0foHZ8oCC eMygVw3J2JG0tNPZX+egVEWdDHnVxdPkFOTRR5VDhPvGm/abbMkvGOlbP5RA/9y09xWn Bbm7GqYw63XxPpQbi6iKFK5uqgzSNjSJKPwuhSKj4lG1PdS10ZGQ0tmy78D2I3Z4q04D Vg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2130.oracle.com with ESMTP id 2qyh8uf375-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 07 Mar 2019 00:17:40 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x270HdpG019570 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Mar 2019 00:17:39 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x270HaEn008410; Thu, 7 Mar 2019 00:17:37 GMT Received: from [192.168.1.164] (/50.38.38.67) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 06 Mar 2019 16:17:36 -0800 Subject: Re: [PATCH v4] mm/hugetlb: Fix unsigned overflow in __nr_hugepages_store_common() To: Oscar Salvador Cc: Naoya Horiguchi , Andrew Morton , David Rientjes , Jing Xiangfeng , "mhocko@kernel.org" , "hughd@google.com" , "linux-mm@kvack.org" , Andrea Arcangeli , "kirill.shutemov@linux.intel.com" , linux-kernel@vger.kernel.org, Alexandre Ghiti References: <8c167be7-06fa-a8c0-8ee7-0bfad41eaba2@oracle.com> <13400ee2-3d3b-e5d6-2d78-a770820417de@oracle.com> <5C74A2DA.1030304@huawei.com> <20190226143620.c6af15c7c897d3362b191e36@linux-foundation.org> <086c4a4b-a37d-f144-00c0-d9a4062cc5fe@oracle.com> <20190305000402.GA4698@hori.linux.bs1.fc.nec.co.jp> <8f3aede3-c07e-ac15-1577-7667e5b70d2f@oracle.com> <20190306094130.q5v7qfgbekatnmyk@d104.suse.de> From: Mike Kravetz Message-ID: Date: Wed, 6 Mar 2019 16:17:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190306094130.q5v7qfgbekatnmyk@d104.suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9187 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903060164 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/6/19 1:41 AM, Oscar Salvador wrote: > On Mon, Mar 04, 2019 at 08:15:40PM -0800, Mike Kravetz wrote: >> In addition, the code in __nr_hugepages_store_common() which tries to >> handle the case of not being able to allocate a node mask would likely >> result in incorrect behavior. Luckily, it is very unlikely we will >> ever take this path. If we do, simply return ENOMEM. > > Hi Mike, > > I still thnk that we could just get rid of the NODEMASK_ALLOC machinery > here, it adds a needlessly complexity IMHO. > Note that before "(5df66d306ec9: mm: fix comment for NODEMASK_ALLOC)", > the comment about the size was wrong, showing a much bigger size that it > actually was, and I would not be surprised if people started to add > NODEMASK_ALLOC here and there because of that. > > Actually, there was a little talk about removing NODEMASK_ALLOC altogether, > but some further checks must be done before. Thanks for the information. I too saw or remembered a large byte value. :( A quick grep doesn't reveal any configurable way to get NODE_SHIFT larger than 10. Of course, that could change. So, it does seem a bit funny that NODEMASK_ALLOC() kicks into dynamic allocation mode with NODE_SHIFT > 8. Although, my desktop distro has NODE_SHIFT set to 10. >> Reported-by: Jing Xiangfeng >> Signed-off-by: Mike Kravetz > > But the overall change looks good to me: > > Reviewed-by: Oscar Salvador Thanks. I'm going to leave as is for now and put off removal of the dynamic allocation for a later time. Unless, you get around to removing NODEMASK_ALLOC altogether. :) -- Mike Kravetz