From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D47C3ABC9 for ; Thu, 15 May 2025 09:24:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F01896B00A3; Thu, 15 May 2025 05:24:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E89246B00A8; Thu, 15 May 2025 05:24:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB5836B00AA; Thu, 15 May 2025 05:24:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A88C66B00A3 for ; Thu, 15 May 2025 05:24:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2D2331D172F for ; Thu, 15 May 2025 09:24:54 +0000 (UTC) X-FDA: 83444607708.09.50C2EB2 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf03.hostedemail.com (Postfix) with ESMTP id 5BA6520003 for ; Thu, 15 May 2025 09:24:50 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Xj41abCA; spf=pass (imf03.hostedemail.com: domain of borntraeger@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=borntraeger@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747301091; a=rsa-sha256; cv=none; b=JjpMunenV2y6Ujcj6v0mOeoT/wWZUjDkZ3fKHyNXphQ6i6TW7QoaI2Z6Qy0x1v/rC5iGu6 Zvwb9f4uRmpVl0lLSgLKXte0DkN2b8nslvVQBw3+WYaMe9I8wBeGIGxXlL4Kt3AVafjZ1L HKhrZe9eVbeZJcjqgp868KfZIhvETBA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=Xj41abCA; spf=pass (imf03.hostedemail.com: domain of borntraeger@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=borntraeger@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747301091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8h69w08A9QwkYhNAcKreTXG+qKfy8roG1DkTKo/70aI=; b=Q1Y0JfNQ21OLVDt6w9Kw3CpOvdGO0/03LChb6CHMJuqUo63AYeo9YjevauvybK3KTJJHvt RkIEp0haQtZtfSf7mOg+RK4t/c11rPDFagn8PVBYR3j/MkCqmdFeS0oe5whMChVaXo0UXr igY2LVUK7JGMB3GGJa551BGHq5ZD7Cc= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54F6OCW7014537; Thu, 15 May 2025 09:24:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=8h69w0 8A9QwkYhNAcKreTXG+qKfy8roG1DkTKo/70aI=; b=Xj41abCAvpx3NzcjYZxMR2 YFtsxFY+S0mBSGzTScOiXZArfp1+WQOXSyL2f9UVAC9FOSJtLGVu6RnTX9/wjaWj foXGsaYnb8HYPonZ779p0muRhd8+S24mym0IpmyzXSzENWEJZ6oXzMl/xln8HtN4 +fpx/TGn1F3wqlX0PyqKCARWW0Lytz/BgCL3bnbMSwSCD3u+putGcfFSDiWBkwGt IDwHs9Hq6NwbpRyYEC1fm/ClHw4HdWsks75TZd661KO/y8EuXj2ifnWFF0ytZ4aL IIl6atmgXo05o9N7oa6U6cllP7WFxtFIxR6d7E0Jg4W57CblO38lstMSmrMXtjhg == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46n0v6kdj0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 May 2025 09:24:46 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54F7F2u5021396; Thu, 15 May 2025 09:24:46 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 46mbfrscer-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 15 May 2025 09:24:46 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54F9Og7P55771644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 15 May 2025 09:24:42 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F127D2007B; Thu, 15 May 2025 09:24:41 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 796392007A; Thu, 15 May 2025 09:24:41 +0000 (GMT) Received: from [9.152.224.40] (unknown [9.152.224.40]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 15 May 2025 09:24:41 +0000 (GMT) Message-ID: Date: Thu, 15 May 2025 11:24:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] KVM: s390: rename PROT_NONE to PROT_TYPE_DUMMY To: Lorenzo Stoakes , Andrew Morton Cc: Ignacio Moreno Gonzalez , linux-mm@kvack.org, Yang Shi , Janosch Frank , David Hildenbrand , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com References: <20250514163530.119582-1-lorenzo.stoakes@oracle.com> Content-Language: en-US From: Christian Borntraeger In-Reply-To: <20250514163530.119582-1-lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=IqAecK/g c=1 sm=1 tr=0 ts=6825b2df cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=VwQbUJbxAAAA:8 a=QyXUC8HyAAAA:8 a=yPCof4ZbAAAA:8 a=TAZUD9gdAAAA:8 a=VnNF1IyMAAAA:8 a=6puILLhiXrOUVKTfem0A:9 a=QEXdDO2ut3YA:10 a=f1lSKsbWiCfrRWj5-Iac:22 X-Proofpoint-ORIG-GUID: yZcsqEheSgMmMrQugs9qS4KVCkbgPcbu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTE1MDA4OCBTYWx0ZWRfX9n/zFJb8L9f5 DKjXxvWP7VtulRdOLoorNI1YLivkoVzk0E+QGp5E/ONJ4Irj6yaVyQKsSnpyRwyDcY8BEa5o/IM 6SpGZvKvY/MgEao81ze72+Hwny/ODqBDcy2zzwaqNoIY2MrxYjKG9V2Tj0o7tU1CnaHwpW+u0D9 1URwvRTeIqxd3UdKEynSKOsB/GFdceDPq0xTaMYAnF/3d31ZcEgbEuMNwERSjnUhWSYPJCCmG/G a01F/feD71JTquMhQbUSNmulT5LPz6AfQMwHPePO4ZveIC7DtRUcx7i1qYhXvFWGspP9tgKTBIB c+vPyIsS0gAr/Ibp70+/ykIbLQyrdRnA6rYUDmCRiO0YawgHOoi0JD+gBV/2BWriX3Y+oTRSOjW 84IA61t/j5YsxaD/bt11UpeYNgGeRu2RG+mKbI7z5dTcKhOOvos+aBgux5Rqrxmk0GP8TMxP X-Proofpoint-GUID: yZcsqEheSgMmMrQugs9qS4KVCkbgPcbu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-15_04,2025-05-14_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 spamscore=0 mlxlogscore=661 bulkscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505070000 definitions=main-2505150088 X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5BA6520003 X-Stat-Signature: fhr5ee1eyywj3gg4mu7amxm7i6xw4t9t X-HE-Tag: 1747301090-679333 X-HE-Meta: U2FsdGVkX19/WvOXZiGv+7VJZmE28vw9hhfEdmN97w6k+bfJgYec2PhIywvl38QdkUWI9b7vAOOogqVEZxvAjvgYOK2C+jbZOWXCy6gHs7d24s9C+KfijbYUGr+Ol+TIyF/AhdqFVE7hWLWnmJUaNpxWsYWl96bxndF51IuztvwSHghJiLBiRzHLXzvvitZjvYohQzdLdzXD7FSQjnqInqRCb9c/3miKcsyVvAIyV9V/5FNjK5xKBWWPDkVyVl4nYUuVLyCiIG9NLDT5wnSfhmRNPOs7XhqStEQ/tCDIkoDkQZHrKjWuTB3olarz9mX7oR2mOQCSkQ+amoUK98jZipneXSx0xynML5bcufXulIyvhXcc2wjN1IFR5K9bFBBFGn7KFoY/LjsHJ96v2Np4RzcpBtwdZ9cFvcbKmMI7DAl85jU6oI+B0KCpMW9l06ARgusm2BoIM7wOgFWaDVNE3QjtbVR/PV5lUU2Y5XB0JEng1Dsymv0otTzcensquqYnv7DAeNLqeaKsfEx+XairfUwzmzeior79Mu6p9g+++Zx9Px4V6FKc/r47d7sD38fTLToMHl67kSu9NzQxoOc/w18a1z2lcIAIp5wpqL2OgrE+fNQ4YT+L5/IsJfIwgYYkfYXz039QMslqDJuvm0mH3wUPeKUkJ1IU5DM0lfkL1KyXmUaB+f23CgAhpmkCdoHMbYg5On1rowB16i0Ha0j6P3xWuuRUlKVR/LSAcqM/HrrDEE4rcoVeQnaetPXoiqlpBymK4HSXAUbTSFdkCDoezWMYLtzrYiKWOOWBQcGeuz26t1fCLdI2T4ynC26i+97XvFncQ2v8SzzPp5PwquQg236zICWu7NLYoT9u3wDbi8RhzqcE3kMbzVAh07FC+LeCEzD8BsvX6J+1cMHoQfjBo1HVU1k5k3fsw4edUMBU+fheLPcHve7hQBWbrd3Qss/Cfs5Uxs72vLsULxN59bl GYnnnVEW yUVkRgDYgpxPB02LtG4YYIxUJJSqMMenh0kV2wBW5rXbkmBluRVlN+qfYEArZdhbjI9AXF/4CQ/GM8t4kRWZstDS/xFrg35nXNDUz8BSQgoUZMseCP3gvMpl7OBgSI4YxA36MZwOvNDjk6U/al0sV8N2XLE4224gtwy6oWsqhzQmNRKiiCiVlQZr265De5299yrUyazK1STGI96OCcoz7bQcqMJrG9VJTxveOhO60JPVejVWzwIOSqDIrbJJ9kA10EDDZvtILRW6GYapHeOc1VgoFA5+s/MdSFqzLjcX9VHP2mR10fV2MqliXrneNjzlTQkIKX/MZFTNnJsyKAV67WSCHpPZ4+xtW0G1106muYBgyeZ+4wFyUhRcoPHzNc6gpiHlcXjg4Ga91t9i3XuENuU8yu3zK8py8evSMwaWd0OolPlk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Am 14.05.25 um 18:35 schrieb Lorenzo Stoakes: > The enum type prot_type declared in arch/s390/kvm/gaccess.c declares an > unfortunate identifier within it - PROT_NONE. > > This clashes with the protection bit define from the uapi for mmap() > declared in include/uapi/asm-generic/mman-common.h, which is indeed what > those casually reading this code would assume this to refer to. > > This means that any changes which subsequently alter headers in any way > which results in the uapi header being imported here will cause build > errors. > > Resolve the issue by renaming PROT_NONE to PROT_TYPE_DUMMY. > > Signed-off-by: Lorenzo Stoakes > Suggested-by: Ignacio Moreno Gonzalez > Fixes: b3cefd6bf16e ("KVM: s390: Pass initialized arg even if unused") > Cc: stable@vger.kernel.org > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202505140943.IgHDa9s7-lkp@intel.com/ Acked-by: Christian Borntraeger I think its fine to go via mm tree.