From: Raghavendra K T <raghavendra.kt@amd.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Valentin Schneider <vschneid@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Peter Xu <peterx@redhat.com>,
David Hildenbrand <david@redhat.com>, xu xin <cgel.zte@gmail.com>,
Yu Zhao <yuzhao@google.com>, Colin Cross <ccross@google.com>,
Arnd Bergmann <arnd@arndb.de>, Hugh Dickins <hughd@google.com>,
Bharata B Rao <bharata@amd.com>,
Disha Talreja <dishaa.talreja@amd.com>
Subject: Re: [RFC PATCH V1 1/1] sched/numa: Enhance vma scanning logic
Date: Thu, 19 Jan 2023 15:54:56 +0530 [thread overview]
Message-ID: <acf37296-485d-0281-69fd-811e7ce011b9@amd.com> (raw)
In-Reply-To: <Y8kP2KbJqWDIgGRZ@kernel.org>
On 1/19/2023 3:09 PM, Mike Rapoport wrote:
> Hi,
>
> On Mon, Jan 16, 2023 at 07:05:34AM +0530, Raghavendra K T wrote:
>> During the Numa scanning make sure only relevant vmas of the
>> tasks are scanned.
>
> Please add more detailed description about what are the issues with the
> current scanning this patch aims to solve.
Thank you for the review Mike. Sure will add more detail in the patch
commit in V2
>
>> Logic:
>> 1) For the first two time allow unconditional scanning of vmas
>> 2) Store recent 4 unique tasks (last 8bits of PIDs) accessed the vma.
>> False negetives in case of collison should be fine here.
>
> ^ negatives
will take care of this and one below
>> 3) If more than 4 pids exist assume task indeed accessed vma to
>> to avoid false negetives
>>
>> Co-developed-by: Bharata B Rao <bharata@amd.com>
>> (initial patch to store pid information)
>>
>> Suggested-by: Mel Gorman <mgorman@techsingularity.net>
>> Signed-off-by: Bharata B Rao <bharata@amd.com>
>> Signed-off-by: Raghavendra K T <raghavendra.kt@amd.com>
>> ---
[...]
prev parent reply other threads:[~2023-01-19 10:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1673610485.git.raghavendra.kt@amd.com>
2023-01-16 1:35 ` Raghavendra K T
2023-01-16 2:25 ` Raghavendra K T
2023-01-17 11:14 ` David Hildenbrand
2023-01-17 13:09 ` Raghavendra K T
2023-01-17 14:59 ` Mel Gorman
2023-01-17 17:45 ` Raghavendra K T
2023-01-18 5:47 ` Raghavendra K T
2023-01-24 19:18 ` Raghavendra K T
2023-01-27 10:17 ` Mel Gorman
2023-01-27 15:27 ` Raghavendra K T
2023-01-18 4:43 ` Bharata B Rao
2023-02-21 0:38 ` Kalra, Ashish
2023-01-19 9:39 ` Mike Rapoport
2023-01-19 10:24 ` Raghavendra K T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acf37296-485d-0281-69fd-811e7ce011b9@amd.com \
--to=raghavendra.kt@amd.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bharata@amd.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=ccross@google.com \
--cc=cgel.zte@gmail.com \
--cc=david@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=dishaa.talreja@amd.com \
--cc=hughd@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox