From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10AE0C0015E for ; Tue, 15 Aug 2023 11:13:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67F8D940017; Tue, 15 Aug 2023 07:13:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62F808D0001; Tue, 15 Aug 2023 07:13:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F633940017; Tue, 15 Aug 2023 07:13:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4058C8D0001 for ; Tue, 15 Aug 2023 07:13:07 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0A9A51A0D55 for ; Tue, 15 Aug 2023 11:13:07 +0000 (UTC) X-FDA: 81126077214.07.2FC8CC8 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by imf25.hostedemail.com (Postfix) with ESMTP id 84A97A0009 for ; Tue, 15 Aug 2023 11:13:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692097984; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mJnfisdIq44YiMxglbXihQzSRh0XS9a4raj2cGuUNa4=; b=4GhO+7CrW52YUU17blgWUNpOruHm3cG+E8Iqk+s8yJMvTUpwOjui9h73388cNL3QhFsK9Q 2ca9vBqF8IaFzxzxIfTLykwmAOBe6hUVQs7kSz4Eav1kvya6ByC1Lfic6OGkGhVR4Vgf7j yadeuWUKxFPVQj8JZ0wpIIsBsOpl7Hg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692097984; a=rsa-sha256; cv=none; b=hXH9bE9Fu7qw6qTZTkcRYQDbz3ExgzKIYyxCDJkiikeXVSJfmvqzODZM9NdIPm4ziXK+Y1 VNMuaBz6jV/VcnNqGmDvT6vK7Kf1F1uXRulc0U/yT/tlgnutQEr6ohMO5UsMY5cS+9m1fA +dnYMQlZ4hO4hwVVoG4cQyQ8TO/Tsuc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of david.laight@aculab.com designates 185.58.85.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-180-guUsedkBOBOlgnKb9Vot1w-1; Tue, 15 Aug 2023 12:12:59 +0100 X-MC-Unique: guUsedkBOBOlgnKb9Vot1w-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 15 Aug 2023 12:12:57 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Tue, 15 Aug 2023 12:12:57 +0100 From: David Laight To: 'David Howells' , Alexander Viro , Jens Axboe , Christoph Hellwig , Christian Brauner , Matthew Wilcox , Linus Torvalds CC: "jlayton@kernel.org" , "linux-block@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: RE: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs Thread-Topic: [RFC PATCH] iov_iter: Convert iterate*() to inline funcs Thread-Index: AQHZzGHVnVxrFjw7PE2nk6LHTBa8tq/rOLUQ Date: Tue, 15 Aug 2023 11:12:57 +0000 Message-ID: References: <3710261.1691764329@warthog.procyon.org.uk> In-Reply-To: <3710261.1691764329@warthog.procyon.org.uk> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 84A97A0009 X-Rspam-User: X-Stat-Signature: i16969emxqim31fteimz3g3aycetgtbe X-Rspamd-Server: rspam03 X-HE-Tag: 1692097984-869663 X-HE-Meta: U2FsdGVkX19mYOSktfAKPcgbZ63J9MXCuz+U49aQ3i/VtW5ni2yCuEBN8Fz5SSg9N4BXXIpOyAG1RtDHf0XKVIdvQRkU2kdr+SNK7x1EDaYc1e1Nx2bveydvJ7pxKvFR2JK7GhfEy+PlkfJPbcqC2+TdxTdB333cc8Tu2k+psTmUY2X9b02oUOXQgFpO78hWkuXQrbhjeg6p9VlcE46qqrTtJ0laen8DNU+b0yw0MXb6wrqonuvjh0WoZlag0z6WHF5U/zpxpFCtFr0PXjVh0GTtkTtdNvQc9uCSXlHphdzs/dzFoLgFxnd0Z7PAD6ZEsRdCjJLTBR9tCaP8wmHGhBRdB6SLWdBOv0Ha3d7hBenBX5FzooVdLHVx1wJHsQGZjtqhRJjzFg2oSoDpyT7uXrA42ujtstrHV9rZZvXBaRrFm377PrU0SlH/y/bXmH31N9Y5aHxELIsgz6leRKKlo5iNV+OxtPoYDz6KwhciDLUbm8kb/ESapwkhe4imfZHPAKuxCHTfjKzBstKvSYKwokMzPWuLqNXTfg2dtgkOIlDr9jbkodvRF9WEtVvO+s7qyHtKsu12tmY7mYaJuiWKbTrt7eIlgi1oXz2rU/u5U5IMDo8KK5oEPiWjfkEdNidL8jioCxXVlgZN8fBhG91p7RQo57GQx11lhfpMSYNk4o0h7ijt2kwcXE9rfk2incGbKr+oOGdCubAXoUTJqnQQ8ewQC3K6snquPoPn7K1m1+0hENyOgfitmMpjsBzZnoAfZVo9CxLVMk9Ifpe6E2meFFPJd8eJtvN5YdFW1pI+VjWQc4l1uIql5KX0VnyEPhgjBI50KwrPSez4ucughKXETjj9kRMb9JcVutH6DfZz/ctr792xNA3yA8tzUNTkHBByi9tuVEz8cTEJmhMBvW+zmonNreW72/VCRJLU4ud6+kJDKv30jXIVxbCd0m5F//ACNJHRYhgUTAEz/cC9QTD JupzQazX Tb5oQk67qOfPEBnQKj51C2CiXrq6aQ3uNrKEqy6YxcYLpiy41UlDr9PcPun1yyUtkJ/DDlAkZUaW1aV/Qp4qlH6SRXmIQHPHwQ9rwT1ljyUBr5SVYlSGslmQzldWu4fJ0KsjI9MrEpkr/MBlH1vEFZ3iQQI9f13AYH/Ft8B45EurDQst0kAyY+V6k+5Uh4AiNBbDOj/xh+qR0SgUJaYgScAHcBNXSMVZaL6Ap+V8UOqmwU21MBNu82eKsh/nOHAvi23jrk5fOZUH2NYMTJmHgUToT7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: David Howells > Sent: 11 August 2023 15:32 >=20 > Convert the iov_iter iteration macros to inline functions to make the cod= e > easier to follow. Ideally, the optimiser would produce much the same cod= e > in both cases, but the revised code ends up a bit bigger. ... Actually quite typical because inlining happens much later on. I suspect that the #define benefits from the compile front-end optimising constants. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)