From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B955C5478C for ; Wed, 28 Feb 2024 15:36:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C1ACF6B009F; Wed, 28 Feb 2024 10:36:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC9B56B00A0; Wed, 28 Feb 2024 10:36:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A91EF6B00A1; Wed, 28 Feb 2024 10:36:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 981FB6B009F for ; Wed, 28 Feb 2024 10:36:41 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 402BB410DD for ; Wed, 28 Feb 2024 15:36:41 +0000 (UTC) X-FDA: 81841615002.03.7A7DCEE Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 3254840026 for ; Wed, 28 Feb 2024 15:36:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="SY KdGNX"; spf=pass (imf01.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709134598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rzh7fFKDHPXXBiFPuiszpKYf6i6kw5PNZfcDhIT104g=; b=ZeikboRHktkacYlzALpLyaYqnfAmH3AJmsMZRGRLGq8jeeuo6sj3OrOuPd9dkYAEGSp+zB lAOVYyvhYDVvRBGca2Hntgl1ITypb47WGcd4JIe+B5bKLIKWUwa+xLH5WaxbhTBWdtk00z IT28DcgQpkA1Vhgcy5fBmpMY2Ohz7Hk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709134598; a=rsa-sha256; cv=none; b=FGTt1uusji6FNsGTo6E5atpXgKcvkZ0H1Lld8d7YF+OK67Cqe55aFMBvnhVwyLlNC/i0S4 TM7L8T03nNGSF8Sa4HItR0xxqZwHzuctS3rtf7ICRys+Xa1k9s/53unKDXUdBI9XUGHOdV sJcVmmDmVoWdTS2buRK3HYuqye5xS7s= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b="SY KdGNX"; spf=pass (imf01.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41SDd9vi008537; Wed, 28 Feb 2024 15:36:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=rzh7fFKDHPXXBiFPuiszpKYf6i6kw5PNZfcDhIT104g=; b=SY KdGNXZgrPZXVr+9BRHFyUy78XbJmIkyTvZ7gXMjPeu/SFyoVJjxC1ESOY6FobeiT I4Tfkug2ynU9bUZkt07rm8K75dYfX38boPkRbHJZEj9rFsNprDSd10ngubbeKCDM jt7MShm1QfQk83GucwGKdxoJFWT1Kt6rB2KxO3OfUByaswDLgYFDxlC4ZmBadJND jkeTOc2Cub8svfkhQqIW8hgpYZD0N7FJxBgA3e3Pe/VxXUKuF9jvY/2G8oaKtDnz wccOeIdftI01zvXsImb2t/sJmJQWtR6lMnVze7g52WrWQcrwi10TpwSFTcScUX4k XqX/v42Xcw08GhQQKO0w== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wj5wc8a9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 15:36:28 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41SFaRXo005518 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 15:36:27 GMT Received: from [10.216.4.223] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 28 Feb 2024 07:36:23 -0800 Message-ID: Date: Wed, 28 Feb 2024 21:06:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/huge_memory: fix swap entry values of tail pages of THP Content-Language: en-US To: Zi Yan , David Hildenbrand CC: Matthew Wilcox , , , , , , , , # see patch description , Huang Ying , Naoya Horiguchi References: <1707814102-22682-1-git-send-email-quic_charante@quicinc.com> <8620c1a0-e091-46e9-418a-db66e621b9c4@quicinc.com> <845ca78f-913b-4a92-8b40-ff772a7ad333@redhat.com> <30ea073d-0ccf-46e1-954d-e22f5cbf69f7@redhat.com> <1ABD022A-35FC-4A6E-ADAD-36F3D745FB91@nvidia.com> <42be658c-cb13-4001-aae4-8d8275a84038@redhat.com> <07A26237-B17E-4418-9A19-E86F450B9695@nvidia.com> From: Charan Teja Kalla In-Reply-To: <07A26237-B17E-4418-9A19-E86F450B9695@nvidia.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 3DgsQ5K6CdeE7HoNgVxwNN7q32GPa0T7 X-Proofpoint-ORIG-GUID: 3DgsQ5K6CdeE7HoNgVxwNN7q32GPa0T7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-28_07,2024-02-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1011 priorityscore=1501 mlxlogscore=999 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 impostorscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402280121 X-Rspamd-Queue-Id: 3254840026 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ruhhm4xeh8qdn6nmuftokw9rraw38nbd X-HE-Tag: 1709134597-298286 X-HE-Meta: U2FsdGVkX18ZHUwwwY1iT3+NI/AJlDpNGMaQq6KgbxdTlKATCZkEOSmoFph5T+8BSL83bmBc8IZOpMIrJewfVUa+0678B9gCpaPAbUvceKgwMnwVTTi5pAfqzPvmMsfvCfVcXmC+UDzU0RtBPMTwoHyk+rva0QNGcY3mqdM35J2GCIMlP5B3DQXizZj1whVu7+SAbH9Oh8RRKPPOHgRHiF4cv57MivboDZtpFFREUspAgaHSHIlca5Iiyo0l5XUOQ0AkoTebz0LQyDqsOkPFWXrN/upIhfEdX3J3/oO0nAhZv5yrIx9VQJsaKjm5gDkITXogFbTuQdX1cZytOSLnuk7spRyCXkcAUZc2gkeQXniXR1TTwDZOZhqyjRU7DWx6llklb5dQfLyi/Gf4f7lL+a0+bLbNq1dM76NDd42LsxZfUWuJnbKnSSmM4wFWBPpemQAUnDKFGnOvLxFnzI6NC6dMTuIG8GK2cf2lqMKOZQ82Gao0ZA1mkeKUi3qEPEufv8XkSN73TLTni2fuqZcC9k9GJ9m4uJH2/3k2EQQecs7A78aTeFiq5Y609eO4PDVe5Qc9X7e5YZDqtObwHLaXWEvjW8euoRIcekqO+Ayjxc3VoQ0IS1ZjFSIVryvfbsyPAQd5qoeWPkOxIwxTwi6gTDGZKsSbU1i/Yzi3GIgQe+E7WGmWfZLp0IUacDiAkpj/K7lRYTeGdSC4fKOFooTTpYvJ+A5rqr3OAGDkFS1A/vIFmrcdMr0Ksx/b7sL0JGNbGKOukAkCKLkYDRObAnvKGEZY5XGr6GZnuekKWCSgylh00EdtQUW/gWp7f1jbVSiOU+KX/sEHgrRF+RxYgWfCiouyu8AEsJjt+zh5QuaBdNYWEUUipeu0A/cvlwUS1XuoHONtu9nDwA5le6rrbpHIVVRFekJWKFcdw+lfU/fjfdoRNu4q04jBaA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thanks David/Zi Yan, On 2/27/2024 9:45 PM, Zi Yan wrote: > So likely we'd have to fix the stable kernels: > > 4.19 > 5.4 > 5.10 > 5.15 > 6.1 > > That's a lot of pre-folio code. A backport of my series likely won't really make any sense. So, I assume this is a consensus to have stable-only fix for this issue. > > For v6.1, the fix would like below? > > diff --git a/mm/migrate.c b/mm/migrate.c > index c93dd6a31c31..c5968021fde0 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -423,8 +423,12 @@ int folio_migrate_mapping(struct address_space *mapping, > if (folio_test_swapbacked(folio)) { > __folio_set_swapbacked(newfolio); > if (folio_test_swapcache(folio)) { > + int i; > + > folio_set_swapcache(newfolio); > - newfolio->private = folio_get_private(folio); > + for (i = 0; i < nr; i++) > + set_page_private(folio_page(newfolio, i), > + page_private(folio_page(folio, i))); > } > entries = nr; > } else { Similar to this is what we had tested[1] internally and observed no issues. Can this be taken to 6.1, please? [1]https://lore.kernel.org/linux-mm/8620c1a0-e091-46e9-418a-db66e621b9c4@quicinc.com/ Thanks, Charan