From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AEA4CF8548 for ; Wed, 2 Oct 2024 23:11:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 032286B04C2; Wed, 2 Oct 2024 19:11:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 009446B04C3; Wed, 2 Oct 2024 19:11:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEC246B04C4; Wed, 2 Oct 2024 19:11:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B90526B04C2 for ; Wed, 2 Oct 2024 19:11:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 46338120C9D for ; Wed, 2 Oct 2024 23:11:34 +0000 (UTC) X-FDA: 82630210908.13.55C0E80 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by imf30.hostedemail.com (Postfix) with ESMTP id 8068B80004 for ; Wed, 2 Oct 2024 23:11:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dbOi5vKK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727910549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WEPJG2bw6vMknzWbR2om8H71nDMP+Mzano5u1esBxjY=; b=w8UUk4e+gZxtKsninPmFWE/9hISlcI1m1dY+ZwBsbfgVp+ll0jAOArls73lSq8FOyk5ruv aitXMThKzanRtJnE+KUvMyFR5hcPgvSc7YS5Kx8UvTgJZso3avKCAB53EOPmeThQN1W0Xt 939SaPvgCeYcx/luHwy1RzG3wXYGGT8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727910549; a=rsa-sha256; cv=none; b=g9FgAY5U30jjizBG3wkURPV9FsVX6+XaTJ3w6xC945q4Ic0DnPfW2RtmgwL7KyseJqAN8Q eW9aIfhG9ZE9bT6wmlUEM1mul6KrOhgGvvpS2QvMFFN+d3eeYCAZosAEeYXK8Oa6Wf8XnI 2izRcSLdbWSwj/iu+CQi1OxodNXSpSY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dbOi5vKK; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf30.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.12 as permitted sender) smtp.mailfrom=dave.hansen@intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727910692; x=1759446692; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=nK1HJccHlPuB3nSLHcSWkaY3D97X47KrWdomQSrqRUY=; b=dbOi5vKKJHO/R+xcwosglu/B3wxnu6tYtIxxRVB6EGXrrhfru7VHEv/j 1eHsZGTLRPfu1CTG6DsLPV16pxWrYscW2gZV93LSH9rOVvaW9GlNqNGM6 6JTp4PE2JfeTrlOUte6KiySGRUbe1foqIZ04hiY+fgcWOQrQd4PjH9eCN 7gba/4l8UwovfW9lbdp7KwQ/zSAvKtaQDr6fne2fki7AJRzIyk7e4fIW2 ttsBiTUXrT/j90VUKNkIly/Mi2TA7l6DYnqAinjnt5Ktg9JIA4b2soLRi mSXtrBnuEudD6QxZrot3HUNslfN4+9jJ2Pj6uEvIzSCczV7/bI8jhOTCN A==; X-CSE-ConnectionGUID: olt2QvCZTi2Q7xQwBnUYhQ== X-CSE-MsgGUID: Xi4kLf/7TyC+cAua7xpgwg== X-IronPort-AV: E=McAfee;i="6700,10204,11213"; a="38478055" X-IronPort-AV: E=Sophos;i="6.11,173,1725346800"; d="scan'208";a="38478055" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2024 16:11:30 -0700 X-CSE-ConnectionGUID: YyqDMVXbQ2aDadqywwjg5A== X-CSE-MsgGUID: S983ZUTCSsqWDmfkuYmczQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,173,1725346800"; d="scan'208";a="78575144" Received: from auryshaf-mobl.amr.corp.intel.com (HELO [10.124.220.104]) ([10.124.220.104]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2024 16:11:28 -0700 Message-ID: Date: Wed, 2 Oct 2024 16:11:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 00/10] Add support for shared PTEs across processes To: Anthony Yznaga , akpm@linux-foundation.org, willy@infradead.org, markhemm@googlemail.com, viro@zeniv.linux.org.uk, david@redhat.com, khalid@kernel.org Cc: andreyknvl@gmail.com, luto@kernel.org, brauner@kernel.org, arnd@arndb.de, ebiederm@xmission.com, catalin.marinas@arm.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhiramat@kernel.org, rostedt@goodmis.org, vasily.averin@linux.dev, xhao@linux.alibaba.com, pcc@google.com, neilb@suse.de, maz@kernel.org, David Rientjes References: <20240903232241.43995-1-anthony.yznaga@oracle.com> <9927f9a3-efba-4053-8384-cc69c7949ea6@intel.com> <2dffaf2e-8a27-44bb-8d54-ef4cc0b08dc5@oracle.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <2dffaf2e-8a27-44bb-8d54-ef4cc0b08dc5@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8068B80004 X-Stat-Signature: 7ykrbzqdb9uamh8udutramiuusdfepjo X-Rspam-User: X-HE-Tag: 1727910691-197569 X-HE-Meta: U2FsdGVkX19jto/0Ch0VXuzpecvHtjOGGBNJSnpsP2CqWhb8bCZF55aL6vsSPXFJHvELGEvJxXk0TN5gzZE5ZYQsB0mLFPxDr9CK0snxRz7PQXiMZNXMh+xVcnOVWNn26sAWJRGbM4FjMNxWfIgyqsOPpWqWECahkhiPeXMlPhlZ9toJ73LueFtYAMR/x/+ifxOzp2Dg4ddSsv4a3M3g93z4kEmrRADlM908PNIrKCPRvF9T3iS8e9WX+1VdV6vIocLlG4xiAFNed4Qur+Pv3rpCsbPhRwWEZFrhJB1ntSdP1/IUefuEWdHkUf8fgNjIkE7efAr8qUB0/RSbUcoETxDdhOwd423I4jPv/urcSKkWkyl4aUu9nQFMT2qj8YzHThgR75BNlxVxQUtGgDls+tKALxf8NHWWLrKlo2qudHydW5tmp9oxXiCzzfOzvd9efZSmopJWndlR+Tyxdta6PQKcBa4++L/ZdT4L5CFtmrpeTJILWJA/C8+qHNKcEsiRJpKyl7drgcpUCb372x3g1ohn3bazXKHFXz41KRXUGPH8rmrZu4gHwWz0TRFmT1l5Vo3WENgVdS+pAYhWapmFWHg6UggGPsYbwaMzuDgAzu4k9xOEYlwfu+ZV6cupqHjTcgpW5LRprogISIYIOvEscFHqeq4oeHvOD1rnlriL5xJ76gRXgjC0OXR155EM08aA93nvP36ceMhzaLQUrsp9vl6MbKi36mYJqvn/KY1eDZr4UkLqDlm3hHV2MhT4PvVi5jrbD643MHxlWIAAbuMc5IcVdizo1MstSNIWhLXpfSvGafrcmfB88wVSL8Mblps7B7tvDFgW0PBQxIv+V7VKQQsgNGvxsIUINC/r3loLJAz7E5HAw0gAiW5LhC48dss7prGgT/zZudJ64T7Peo7Fi0vw+S5zRh6S0i4zVcPUhyh0haJxsoNPDNdrMjYI1TySnA+TMdQ3YQcVo737XHv JMcI8ytU eSOdukPanFEG/cBOazbupAnflfy0MJm1WppXQ8MQB/1IWlm1tEHv8n+o4eTPJvODarCn5+SwxgxJt5brFZFdvB2PSB+gmaNaRtFQv36DTTzC6AvXxJG04oI8Uza7gZKS6Wg3ra8f1EC7Lbo99XSaYKa50RU8h4EXjtUgJAKEmGhdmNA9sI+UD6An0zOhgaxBbrnG8gdw+QyxwWPY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: About TLB flushing... The quick and dirty thing to do is just flush_tlb_all() after you remove the PTE from the host mm. That will surely work everywhere and it's as dirt simple as you get. Honestly, it might even be cheaper than the alternative. Also, I don't think PCIDs actually complicate the problem at all. We basically do remote mm TLB flushes using two mechanisms: 1. If the mm is loaded, use INVLPG and friends to zap the TLB 2. Bump mm->context.tlb_gen so that the next time it _gets_ loaded, the TLB is flushed. flush_tlb_func() really only cares about #1 since if the mm isn't loaded, it'll get flushed anyway at the next context switch. The alternatives I can think of: Make flush_tlb_mm_range(host_mm) work somehow. You'd need to somehow keep mm_cpumask(host_mm) up to date and also make do something to flush_tlb_func() to tell it that 'loaded_mm' isn't relevant and it should flush regardless. The other way is to use the msharefs's inode ->i_mmap to find all the VMAs mapping the file, and find all *their* mm's: for each vma in inode->i_mmap mm = vma->vm_mm flush_tlb_mm_range() But that might be even worse than flush_tlb_all() because it might end up sending more than one IPI per CPU. You can fix _that_ by keeping a single cpumask that you build up: mask = 0 for each vma in inode->i_mmap mm = vma->vm_mm mask |= mm_cpumask(mm) flush_tlb_multi(mask, info); Unfortunately, 'info->mm' needs to be more than one mm, so you probably still need a new flush_tlb_func() flush type to tell it to ignore 'info->mm' and flush anyway. After all that, I kinda like flush_tlb_all(). ;)