From: David Hildenbrand <david@redhat.com>
To: xu.xin16@zte.com.cn, akpm@linux-foundation.org
Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org,
roman.gushchin@linux.dev, chengming.zhou@linux.dev,
muchun.song@linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, cgroups@vger.kernel.org
Subject: Re: [PATCH linux-next v3 1/6] memcg: add per-memcg ksm_rmap_items stat
Date: Tue, 23 Sep 2025 10:28:15 +0200 [thread overview]
Message-ID: <accb281c-3c2a-4162-ab14-38e883d1ff72@redhat.com> (raw)
In-Reply-To: <20250921230854496C6rkj7YZAYi39dNV3t6Fp@zte.com.cn>
> +
> +/* Show the ksm statistic count at memory.stat under cgroup mountpoint */
> +void memcg_stat_ksm_show(struct mem_cgroup *memcg, struct seq_buf *s)
> +{
> + struct memcg_ksm_stat ksm_stat;
> +
> + if (mem_cgroup_is_root(memcg)) {
> + /* Just use the global counters when root memcg */
> + ksm_stat.ksm_rmap_items = ksm_rmap_items;
> + } else {
> + /* Initialization */
> + ksm_stat.ksm_rmap_items = 0;
> + /* Summing all processes'ksm statistic items */
> + mem_cgroup_scan_tasks(memcg, evaluate_memcg_ksm_stat, &ksm_stat);
What happens here if you have to tasks that share the same MM? (CLONE_VM
without CLONE_THREAD)?
Wouldn't we end up counting the same MM multiple times?
--
Cheers
David / dhildenb
next prev parent reply other threads:[~2025-09-23 8:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-21 15:07 [PATCH linux-next v3 0/6] memcg: Support per-memcg KSM metrics xu.xin16
2025-09-21 15:08 ` [PATCH linux-next v3 1/6] memcg: add per-memcg ksm_rmap_items stat xu.xin16
2025-09-23 8:28 ` David Hildenbrand [this message]
2025-09-21 15:11 ` [PATCH linux-next v3 2/6] memcg: show ksm_zero_pages count in memory.stat xu.xin16
2025-09-21 15:12 ` [PATCH linux-next v3 3/6] memcg: show ksm_merging_pages xu.xin16
2025-09-21 15:13 ` [PATCH linux-next v3 4/6] ksm: make ksm_process_profit available on CONFIG_PROCFS=n xu.xin16
2025-09-23 8:25 ` David Hildenbrand
2025-09-21 15:14 ` [PATCH linux-next v3 5/6] memcg: add per-memcg ksm_profit xu.xin16
2025-09-21 15:15 ` [PATCH linux-next v3 6/6] Documentation: add KSM statistic counters description xu.xin16
2025-09-22 8:20 ` [PATCH linux-next v3 0/6] memcg: Support per-memcg KSM metrics Michal Hocko
2025-09-22 9:31 ` 答复: " xu.xin16
2025-09-23 14:17 ` Michal Hocko
2025-09-23 8:26 ` David Hildenbrand
2025-09-23 17:58 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=accb281c-3c2a-4162-ab14-38e883d1ff72@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=xu.xin16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox