From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3275BC4CECE for ; Mon, 14 Oct 2019 14:44:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E665B21721 for ; Mon, 14 Oct 2019 14:44:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E665B21721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 910D78E0005; Mon, 14 Oct 2019 10:44:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89AEC8E0001; Mon, 14 Oct 2019 10:44:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7615E8E0005; Mon, 14 Oct 2019 10:44:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0006.hostedemail.com [216.40.44.6]) by kanga.kvack.org (Postfix) with ESMTP id 4FA8F8E0001 for ; Mon, 14 Oct 2019 10:44:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id E7F121F1A for ; Mon, 14 Oct 2019 14:44:32 +0000 (UTC) X-FDA: 76042661184.19.crime55_27a00f8edbc09 X-HE-Tag: crime55_27a00f8edbc09 X-Filterd-Recvd-Size: 6000 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Oct 2019 14:44:32 +0000 (UTC) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x9EEZUVm069450; Mon, 14 Oct 2019 10:44:12 -0400 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0b-001b2d01.pphosted.com with ESMTP id 2vmt312n7s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2019 10:44:12 -0400 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id x9EEeLVF014283; Mon, 14 Oct 2019 14:44:11 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma04wdc.us.ibm.com with ESMTP id 2vk6f6u5jr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 14 Oct 2019 14:44:11 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x9EEiAHr28443060 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Oct 2019 14:44:10 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0B8496A057; Mon, 14 Oct 2019 14:44:10 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 59E7F6A054; Mon, 14 Oct 2019 14:44:06 +0000 (GMT) Received: from [9.199.41.79] (unknown [9.199.41.79]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 14 Oct 2019 14:44:05 +0000 (GMT) Subject: Re: [PATCH 2/2] mm/gup: fix a misnamed "write" argument: should be "flags" To: "Kirill A. Shutemov" , John Hubbard Cc: kbuild test robot , kbuild-all@lists.01.org, Andrew Morton , Christoph Hellwig , Keith Busch , Ira Weiny , LKML , linux-mm@kvack.org, Christoph Hellwig References: <20191013221155.382378-3-jhubbard@nvidia.com> <201910141316.DHpeevy3%lkp@intel.com> <20191014135234.7ak32pfir6du3xae@box> From: "Aneesh Kumar K.V" Message-ID: Date: Mon, 14 Oct 2019 20:14:04 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191014135234.7ak32pfir6du3xae@box> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-14_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910140134 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/14/19 7:22 PM, Kirill A. Shutemov wrote: > On Sun, Oct 13, 2019 at 11:43:10PM -0700, John Hubbard wrote: >> On 10/13/19 11:12 PM, kbuild test robot wrote: >>> Hi John, >>> >>> Thank you for the patch! Yet something to improve: >>> >>> [auto build test ERROR on linus/master] >>> [cannot apply to v5.4-rc3 next-20191011] >>> [if your patch is applied to the wrong git tree, please drop us a note to help >>> improve the system. BTW, we also suggest to use '--base' option to specify the >>> base tree in git format-patch, please see https://stackoverflow.com/a/37406982] >>> >>> url: https://github.com/0day-ci/linux/commits/John-Hubbard/gup-c-gup_benchmark-c-trivial-fixes-before-the-storm/20191014-114158 >>> config: powerpc-defconfig (attached as .config) >>> compiler: powerpc64-linux-gcc (GCC) 7.4.0 >>> reproduce: >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # save the attached .config to linux build tree >>> GCC_VERSION=7.4.0 make.cross ARCH=powerpc >>> >>> If you fix the issue, kindly add following tag >>> Reported-by: kbuild test robot >>> >>> All errors (new ones prefixed by >>): >>> >>> mm/gup.c: In function 'gup_hugepte': >>>>> mm/gup.c:1990:33: error: 'write' undeclared (first use in this function); did you mean 'writeq'? >>> if (!pte_access_permitted(pte, write)) >>> ^~~~~ >>> writeq >>> mm/gup.c:1990:33: note: each undeclared identifier is reported only once for each function it appears in >>> >> >> OK, so this shows that my cross-compiler test scripts are faulty lately, >> sorry I missed this. >> >> But more importantly, the above missed case is an example of when "write" really >> means "write", as opposed to meaning flags. >> >> Please put this patch on hold or drop it, until we hear from the authors as to how >> they would like to resolve this. I suspect it will end up as something like: >> >> bool write = (flags & FOLL_WRITE); >> >> ...perhaps? > > Just use > > if (!pte_access_permitted(pte, flags & FOLL_WRITE)) > > as we have in gup_pte_range(). > > And add: > > Fixes: cbd34da7dc9a ("mm: move the powerpc hugepd code to mm/gup.c") > b798bec4741bdd80224214fdd004c8e52698e42 isn't this the commit that need to be mentioned in the Fixes: tag? -aneesh