From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D2E2C36002 for ; Wed, 9 Apr 2025 10:34:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77E5C280066; Wed, 9 Apr 2025 06:34:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72C98280065; Wed, 9 Apr 2025 06:34:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A678280066; Wed, 9 Apr 2025 06:34:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3C50F280065 for ; Wed, 9 Apr 2025 06:34:56 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5C3D51C856A for ; Wed, 9 Apr 2025 10:34:57 +0000 (UTC) X-FDA: 83314147434.18.7E4736D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 04A1B10000F for ; Wed, 9 Apr 2025 10:34:54 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iunUVmxl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744194895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=83roHr45eFAfDwWGjHwmHyxjB/WDYkk0hQKFuD5ukgE=; b=3lVphh+eXlIYYYM3l7DH0eelwy4Mv1GZS3A0ayPznQ1mI1lzxz5P1Q+LjGB0Wk5YLMFwCw UGOQtHCY/B6blJDiv88lcHiKQFhU0Ps1W6ucFEWYPuQYr0EAUNXb6sjpe2dP5Zc5Or0iFN NOOWr0m3rQ89DpBaFufmDUcxZ6VnJ80= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744194895; a=rsa-sha256; cv=none; b=zbC/Sk7KZuN6afaaEILYIuvq0f0PszxpwoMrdGVPuA+kSlOUX1M5HQPxaBNt0UqUpza2yn qvQSJwg9yij4LceN1ApA22teyprJ6fRVxNA3OBEUA1e9t1K7KIwRZ+Ld9Q5Z3G+6TmTkVE i9EhO+kKThRdf/qUkLBhJ6QOH7si8v0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iunUVmxl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744194894; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=83roHr45eFAfDwWGjHwmHyxjB/WDYkk0hQKFuD5ukgE=; b=iunUVmxlYBtp2ZaU7ZG3rv3nNOEQBhpBwG8ht1QK6VWgIlAqZw5xRfrdg8mtI7OBTdr6Vq cg1BPmwQZJWVeEyN2uD/IFjVQwy0Krfsw7TBAWjUyyNbpaXYf6cPdMSpHVkvv/NkMYnw8l NNOj+UPGodxjD9ckDwPPi3iap5IYOvk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-290-IA5D_yvXN6-W2xSBHG-65Q-1; Wed, 09 Apr 2025 06:34:51 -0400 X-MC-Unique: IA5D_yvXN6-W2xSBHG-65Q-1 X-Mimecast-MFC-AGG-ID: IA5D_yvXN6-W2xSBHG-65Q_1744194890 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cf327e9a2so55611035e9.3 for ; Wed, 09 Apr 2025 03:34:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744194890; x=1744799690; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=83roHr45eFAfDwWGjHwmHyxjB/WDYkk0hQKFuD5ukgE=; b=K8nTkyl1rPAR/c1/JPvGFi37If8LuYFvtYyfX+Bw/7g5W/2g458rpnS2xZWd0XvM3O khOMa8SeJf+4h/Z0NIsbdEtp9M1Zf9v+ywGsidgYa8DzCxFl3YCsiLnKP9PmLbFRH+qz bFkLuyc14rAdV8rPdHG53YUyjQajWlBJaZXR6/nK9IoSEy7231KBCAPxY5R1yQaklx16 +f1F182KoEoOoixA5W0LV5ql4jn0vpgr2MjzuGHfBK8GGHOHmD6fqEiFa/KZaYQ6w9PI HHRNhi+ddW/a+7/Ykz56zSRQ+jEKSHijeIJTk9kbTkgkhQReQ4kFVJk7+RB7rYsaYAnq N2RA== X-Forwarded-Encrypted: i=1; AJvYcCU+qxKCgqnOmKhWDZzvZSwOTVz34IPfKMjgCwtP2ZttxiWMD9Mz/6rldUBaeOw+ERyJydXikgLPHQ==@kvack.org X-Gm-Message-State: AOJu0YyCp9Q49MeoJL66a8A8TYnDIdQeVdp61DrKEAtAuZIKyzqdy9tn n9B1ZYcY0QVB2o8tibyoA2VoNsjsfXfbUSWS/yz5g2VjykoSN5Wu2GBMPQ6X4ROB9iI76j/1/Vk M1kdLLenG4M5vKzScBxYb0i6qqwgJOccMsHFpiHLDQAGqDpc3 X-Gm-Gg: ASbGnctUc+8ld58grXSBvnRlpr7Sap2WoaNBrlAGA3DbCdfopjZP+D6OZlMbx4/kN9h dyaW7GIG3BFZoW3GqkhU3TdoxU6bADfA/sq/Hrgry3nAmJi6/ZH3QU4VtSELATZP7zrXu7WxVMU vR5xVA1o5emRyUwkXdxeblwk+I1N8r89YhpBywssDMvLnIi2vB+1P0ns+c2maDjc2WxHSTCBsjU 3asZfLi1MxBeKKteCBfqctm9+cjHZcTHVmj8yKCim0d4NZg8Sh1DFflPBUH11OXz8S3gqy4l1Fh K+r63zi/Ll+Jqycr/a/62pw/eYin34XGvsrpflvIE99UROMwNPs367eeyTUu8ecisOkkzVcSISL zXj6F5zEAukiH85ReQkfbH6/pDC7vy2yieQ== X-Received: by 2002:a7b:c5c8:0:b0:43e:b027:479a with SMTP id 5b1f17b1804b1-43f1ecdad2cmr17328075e9.16.1744194889803; Wed, 09 Apr 2025 03:34:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbCKJCIIyD6uSvYRB2J5oGynfaNGKKM5UkfpatHWUgekD4QxrjfUPEtg+ep230sZKa6VK3rw== X-Received: by 2002:a7b:c5c8:0:b0:43e:b027:479a with SMTP id 5b1f17b1804b1-43f1ecdad2cmr17327815e9.16.1744194889450; Wed, 09 Apr 2025 03:34:49 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:8400:ed9b:a3a:88e5:c6a? (p200300cbc70d8400ed9b0a3a88e50c6a.dip0.t-ipconnect.de. [2003:cb:c70d:8400:ed9b:a3a:88e5:c6a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43f23572bb2sm11794645e9.29.2025.04.09.03.34.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Apr 2025 03:34:48 -0700 (PDT) Message-ID: Date: Wed, 9 Apr 2025 12:34:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] x86/mm/pat: (un)track_pfn_copy() fix + doc improvements To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kernel test robot , Dan Carpenter , Lorenzo Stoakes , Andrew Morton , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Rik van Riel , "H. Peter Anvin" , Linus Torvalds References: <20250408085950.976103-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XWtVtz2JGSl-Hd5OBO34ELfITi65kw09yOj9AtrJxTg_1744194890 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 04A1B10000F X-Stat-Signature: i9c984jb9wqk79nsjw6b4rkarf1zzupz X-Rspam-User: X-HE-Tag: 1744194894-429907 X-HE-Meta: U2FsdGVkX1+eqOOdrDNlAsvy9bDN6Lh28DEXTU0WhDXfK9H5Lm50dt1y1V6C/wsCaiJhNttnPWFMnqaeCrxxMSWN5kRf+7ulTJSkoARNLTARVbLQL0NaFe9tJL8+BiFc1Q/UY4gBlJBSCCrVnD3+ExLiIdfnT3rCuOfGT1qnbr65SMOcPd/YTZieabUaf17IecEx6mOmbU8/KBtT1ioFc00igT+yNgADlnFyM7xRfUhQ5GGtVNgZTgttFDWF1Z4ST1K2Z+FY6Qr0uMTFejTv5W4we8v1ZddW9ofbymMBNZf1634mSy3040OyqJNoY5kuSX7B6h2UQv/ToNxp3TnDOb9ZR/TAb9UW+SuNMLd8fg71VI1ki6am+fOuzD0Ec4VZMi/aOoOBXFNvsHtRtsAnTmAMb0qompcUq4Rnf3QSYDJDKbV+BoZEfwXbtJNRGnoH8nwPK/oYhZVCcK4QtLrz7JiHgAVNOodLnLU+2Bm/Uh4izNsPbybUVVtwd7XANI2jCsYANsgbWzylBCuv9MV9PZKTLksK9MwkMbMwgy9l+m+/gjuK7xUmhvTQ6XS3fdOv8J35cdyWesyKWukW65/x06tm/EMnzagLfZc/TzuRnr8kqhuJ6p2HwMmhkw8Q27F0Xo0PAGwuEL3M17BtdYBnTEbIMM1/IIj1lD/8vwc24DK7QYCtHH+JB6B7kNexcDThoTs/KHm94RvERUhJuQRstOCxjZKVj+tmJGufz9MILktRZUZJ3pflyoQGdvf8JtAn+MRzpYSN1316oDQ3l2IQZqXAhsVVkbuYO2kUUUEqBQFIrQUlvypenSpG1zR9jrryFACuB0AcpJ60OY/PsI/UNL84TS0U9qU3eySI+ZTYMKqLRe8dfJEEEpFQd3nDESJAEldbIkEEn3sn9X1SlrkEhGURWZ2JzDK9Ku/y2fiRS+vt1q54zOX/N8LUsNhOV9FyaRdiV/KjOYpcj6KMBtz U0SthjLa hVAw1wJ/TJ+uDxzuqYc7N7YtqlfNcmNJ2Z5CPLeZ2GPBZSLYaSG8jhFeYgrY0GwNfcF4iR8xBHTVzZaa5R+eAh8LF0TKWhVrN5Gx5EttKGOti1+uf56X6rBPWC8XW2qh69C7ImxDwtqOCxaQ62Exqs36NCmBydSF2oHc5NQs1OzAKGW46qglDYg1hbcX1ZzMjDZaZTV+o01h0eblg3uVNg1LidqRULtBjGJ/07z7MdGM1TxcyfD4x3sfCDGjK00G2vhRZdRsIovhGMPUxGgaSboGFhEDyHzjJUcXFqB9JqAkoa5+HmXIZk6/QAFT5ZWmxxkv9PUyDgZdwx0vM+I+XWV91s37OCkLW4k82Lwjx0eIKO12rWdJqbH6jJDF1xj7W3ViIfXkxdsy0tKWrSdb4lQfO5RMI8wwQ/Ly4U2c/m7eIshAMjKDbX7zER+9aUxwFvIaWZJ7171owxXJxn5j2a+36SngrKjT3v+2d X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.04.25 12:32, Ingo Molnar wrote: > > * David Hildenbrand wrote: > >> We got a late smatch warning and some additional review feedback. >> >> smatch warnings: >> mm/memory.c:1428 copy_page_range() error: uninitialized symbol 'pfn'. >> >> We actually use the pfn only when it is properly initialized; however, >> we may pass an uninitialized value to a function -- although it will not >> use it that likely still is UB in C. >> >> So let's just fix it by always initializing pfn in the caller of >> track_pfn_copy(), and improving the documentation of track_pfn_copy(). >> >> While at it, clarify the doc of untrack_pfn_copy(), that internal checks >> make sure if we actually have to untrack anything. > > Note that the title isn't accurate anymore, it's not an 'x86/mm/pat' > patch, but an 'mm' patch. Agreed. Who will take this patch? If it's Andrew, can you fixup the subject please? -- Cheers, David / dhildenb