From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C04FC3DA78 for ; Mon, 16 Jan 2023 03:17:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7C4E6B0073; Sun, 15 Jan 2023 22:17:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C04A06B0074; Sun, 15 Jan 2023 22:17:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACC606B0075; Sun, 15 Jan 2023 22:17:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9AA166B0073 for ; Sun, 15 Jan 2023 22:17:50 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5AA4FA5869 for ; Mon, 16 Jan 2023 03:17:50 +0000 (UTC) X-FDA: 80359202700.13.11B0CBE Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 9880F20010 for ; Mon, 16 Jan 2023 03:17:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=B62I4qse; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673839068; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GwoQNGx5hsrKaJKEbgHWK3TDLSUxn/TFj2UY0KJBWG8=; b=d8wfTONRjZ9FaQjSTD1nVFb838CpHSdQ3LqZ2OIYT1G1PrU0lxIPDhuixNb+FUTrCmdo6o QqJfCrWT95Vchg5nbmOYAGfcxb82A81wMCR21tYuKMPERXAEZjX279EmWnVP7LS/Ut0JbX 7ExG3W14D0PfTp82PftZYP5y+93kqq8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=B62I4qse; dmarc=pass (policy=none) header.from=bytedance.com; spf=pass (imf03.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.215.172 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673839068; a=rsa-sha256; cv=none; b=LNb/dyTRZZW8JhrReSFjjA1gfNE3Pr/mpDr5a/Jn/5IxnaEe6yd4A6RiPJZiVF7YByy+jK +CWfrzKlbMbVJ9FrJ5YLMsn/vvItIn/cElWQC6rnibt9yddjBWY6B4JngB7JJadvrb6/o0 wcBPPxQIpmz7sBt9oMGREDMM9ZbmWwc= Received: by mail-pg1-f172.google.com with SMTP id q9so18765516pgq.5 for ; Sun, 15 Jan 2023 19:17:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=GwoQNGx5hsrKaJKEbgHWK3TDLSUxn/TFj2UY0KJBWG8=; b=B62I4qsemLL8C1gosT1DZDagIOkG1PBUaXfUsMgaL0A2yZ32TpBdntLMQlv5z5LrAW 2bm7QqvMpBeNqBuU9eLJforPRn1kdNyCuc5Fdm7aTopl8C7BysDgn/RI41SP+Kun157R GLe0k9saoMwo/MlDQw9IgQUGiEjBOfLiaK1ZIhck7NKNfguES9JJAEnKHV4MNUTLxBCC 49Dm06GFONdGH37aGA+FGDENIINBlZZjaDeGWWZK0xShNJqKSbuPkVECw0dhsoecUfzK Hevu0NdAti3NtpzS+/NaCq7VvwhFsKaARY+XMTUFb2CzRyLE6K11dOPe9nm5kSKiQDBi K6nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GwoQNGx5hsrKaJKEbgHWK3TDLSUxn/TFj2UY0KJBWG8=; b=tH9jg7CgL2/gSmVgSkDLE0e7Da+zRADKX81/Hw+vgyJH1eE7aAI2tAFfOtFegstAP4 8yHG6kUIbPRK9YaCFSvzD3wci1js1qMvXKt0N9ubIxY8fEgP7cGu/1xo/qGsavuW+JPh wu+0ZTwILmF+eMQg9D6rsccJZNzz61dvlmK4fHquDn9dlgLzeV040rZjcsrwQmButoRK X+7/CiRLQQNaq7nb0g8dBCp+b8UaA2Z0gnvjM9fI7CmYjmcjUjqFRphT4OeBhYaCYvFM Z6v3UIoRzL0W/F8j+QU3QA4tCQHHRlK9Q3xsoUWzEXTceyzgifF3zt1osznK+IShy0uk Hfsg== X-Gm-Message-State: AFqh2kpoGoFmM0fB3GQDBFDkkW8i+xippJvpJHR1Wc1JhRbzwMsTN6nt bzB3pUjnfIZWGor18OKVYBTUlw== X-Google-Smtp-Source: AMrXdXuSptKk1KjUsp4wFKj0Ou8+R7Ai5i27k6GhyYCrLplf26cddgis7VaamdOB5agannovFkJe5w== X-Received: by 2002:aa7:8d04:0:b0:58b:c35:ebab with SMTP id j4-20020aa78d04000000b0058b0c35ebabmr17384619pfe.11.1673839066156; Sun, 15 Jan 2023 19:17:46 -0800 (PST) Received: from [10.90.35.114] ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id w23-20020a627b17000000b0058bc37f3d13sm3379044pfc.43.2023.01.15.19.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 Jan 2023 19:17:45 -0800 (PST) Message-ID: Date: Mon, 16 Jan 2023 11:17:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 2/3] memblock: Make finding index faster when modify regions. To: Mike Rapoport Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230113082659.65276-1-zhangpeng.00@bytedance.com> <20230113082659.65276-3-zhangpeng.00@bytedance.com> From: Peng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9880F20010 X-Stat-Signature: qrjgqekc5b5xmu8ifp1a7tuney9z1q3u X-HE-Tag: 1673839067-781139 X-HE-Meta: U2FsdGVkX18rBYzRoEjZ3csGoQb6EEQf7enfLAvnVec3FEmOVwkAp5r+z2ugd9t55Vvccx5KzQTxWBriBYBGDwP1kYWMV6VsIJjyHSAOWR9sDeIvxK3TVqn8C9tXcn3cREjSnPeorLDQK3nsJ6t7TUAsZWEH4F0ihET7/7gCaTZNaa2mzAsh6uutux0Q5E+RRT52WccpydRQJijOhfHZfkUJfTWblWRT18SUYioNdZOvztkmX5LB5qoed2/qD2mfZo52cljCWms3TgrCOG8iBVZOgqkIhi/16DPW+qNqe1M5AvkA9KQvii2QAV9UruFw6FkJqo0CZdep02vPXsZ25QqXN7zJvznciuwfku1m9OCRmWFmIAvCU8douRi2ycYPOUenGjMmRVHGppo5TdK2PKYv/zo7xkA5/TEgHdEqxBt/GRZIfzPTSUZK/Sa0l+5eKhRKGa5fed6gcG2vl7EgPdHDyDBxBzmk7ZhqUz9J+PtuCmyDSJ8fFYxQnSbZ8C6hey3YPuaaanQYWqLFsx98o5kPPI+S6+eykozIIyeFaCAyL2D4+YDoKleNyOqnHOcLY6GKMB7rB/IO8Axv8i0xToI6zaeycwFerXsDcFZrqvo67u1gTN2ZzGJqFac+IuT6pmwfSEvxZrYvFrRPyrMEZ2njipEXdmRTGqLoirdoWiLpPDq6p+X3xUVqHNRG2CcUd8CvqYdACtwWHjKigewCDVRVc37A6CF8qE6JJ+LNqXGK9qDuQ20VvBMXQjfLccCsw7DVOH7XXjOO8EVHDOHXZ7vqke9qYKPBLnaxKS3MOzjzCRSId9ZyixVDB8YBWeE2O/xJ1K9SDzb1xRy2+zy5Tg6P8T1Du2erMYXV9W0iIvmfd9fUyT1hwalk4fXP5MM7DY+7cfPxsj9FkBTG6nq+DOhoS1VFFDukXWITcERHa19neRcmj9KhAHHOr4TSNHbfdCQukC948o4DM8Gwq+O 3rOYDHmx o71FxupPSceRR5qD3XBjO352ymAagA+D2Qlgb8vhaShayGlJV1rSLt86jqLILyjBunqUUZXS7p94lzA0Pw1feZcUbW5GhE69h0AwB1ZsODV7kO9scntNzNq5Q99bfK40PWd393hoqHfcAviuFLDwBQj+a/MK2nM3BeoQT X-Bogosity: Ham, tests=bogofilter, spamicity=0.122475, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/1/15 22:02, Mike Rapoport 写道: > Hi, > > On Fri, Jan 13, 2023 at 04:26:58PM +0800, Peng Zhang wrote: >> We can use binary search to find the index to modify regions in >> memblock_add_range() and memblock_isolate_range(). Because the >> arrangement of regions is ordered. It may be faster when there are >> many regions. So implemented a binary search and a new macro to walk >> regions. > > Did you see a measurable speedup with this optimization? > I'm not in favor of micro-optimizations that complicate code. > Thank you for your reply. I haven't measured this patch yet, theoretically this small optimization might be difficult to observe. If you think this patch complicates the code, you can ignore this patch. These three patches are independent and they can be applied independently. The logic of the third patch is very simple. It will not complicate the code. It is tested by the default configuration of qemu. The total number of iterations of memblock_merge_regions() in the third patch is reduced from more than one thousand to more than one hundred, this is only in the case of a small number of regions. Can you consider the third patch? Sincerely yours, Peng.