From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78182C433F5 for ; Wed, 5 Jan 2022 20:27:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A913A6B0072; Wed, 5 Jan 2022 15:27:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A41016B0073; Wed, 5 Jan 2022 15:27:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908BC6B0074; Wed, 5 Jan 2022 15:27:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 7D97C6B0072 for ; Wed, 5 Jan 2022 15:27:16 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2AD0F181DB37D for ; Wed, 5 Jan 2022 20:27:16 +0000 (UTC) X-FDA: 78997368072.28.C37BFAE Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf11.hostedemail.com (Postfix) with ESMTP id C2B0240008 for ; Wed, 5 Jan 2022 20:27:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641414435; x=1672950435; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=FSFWIc4HSv9YdqR3Ma1IzBH4Anr1q7MqPqL/vrhT98M=; b=fGnKzv1eOvmsk5pPr+sLgH11kJTV0D7lhrfkYLvTXqaR2bSxoud7zDOu r0emgJt6bNNf69CuhHdpQ9uKIHtrw31DQwLAMtQHZ8suS1Y8q0VIyhoBw DVY/L2QaSJbTB0z02xQLxvGQHlu5bU937+k8BnrX0nizg4h5QhRqvanWH IQus22EXb45KTrdF9QNas7chN8jQUEJZlHOC02DRG7WI50G9YZIPfFiu3 aViDA6EnSN0jneeHoehRS0V2wWrZfnRKgOSiOfdOl2zyc9uTuAiI8Ssn3 pfw5AA5jyIihtVaDbJhksOdM7zWSdznwCL+iM4AOLSgLNW+vvzvrXaCMF A==; X-IronPort-AV: E=McAfee;i="6200,9189,10217"; a="223215889" X-IronPort-AV: E=Sophos;i="5.88,264,1635231600"; d="scan'208";a="223215889" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2022 12:27:12 -0800 X-IronPort-AV: E=Sophos;i="5.88,264,1635231600"; d="scan'208";a="760939957" Received: from njvora-mobl.amr.corp.intel.com (HELO [10.212.154.74]) ([10.212.154.74]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2022 12:27:10 -0800 Message-ID: Date: Wed, 5 Jan 2022 12:27:08 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH v8 13/40] x86/kernel: Make the bss.decrypted section shared in RMP table Content-Language: en-US To: Brijesh Singh , Venu Busireddy Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Borislav Petkov , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com References: <20211210154332.11526-1-brijesh.singh@amd.com> <20211210154332.11526-14-brijesh.singh@amd.com> <18eadf9d-8e31-0945-ccf4-2cb72b8e0dd4@amd.com> From: Dave Hansen In-Reply-To: <18eadf9d-8e31-0945-ccf4-2cb72b8e0dd4@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=fGnKzv1e; spf=none (imf11.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 192.55.52.151) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C2B0240008 X-Stat-Signature: h4wphqetquz3zupqmc1sfkd3yqwp41g1 X-HE-Tag: 1641414430-654874 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/5/22 11:52, Brijesh Singh wrote: >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for (; vaddr <= vaddr_end; vaddr +=3D PMD_SIZE) { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /= * >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 * When SEV-SNP is active then transition the page to shared in the RM= P >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 * table so that it is consistent with the page table attribute change= . >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 */ >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 e= arly_snp_set_memory_shared(__pa(vaddr), __pa(vaddr), PTRS_PER_PMD); >> >> Shouldn't the first argument be vaddr as below? >=20 > Nope, sme_postprocess_startup() is called while we are fixing the=20 > initial page table and running with identity mapping (so va =3D=3D pa). I'm not sure I've ever seen a line of code that wanted a comment so badly= .