From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81A4E77188 for ; Fri, 20 Dec 2024 17:45:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25E166B0088; Fri, 20 Dec 2024 12:45:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E6F46B0089; Fri, 20 Dec 2024 12:45:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AE8A6B008A; Fri, 20 Dec 2024 12:45:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DD43E6B0088 for ; Fri, 20 Dec 2024 12:45:13 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 95CEEC0C53 for ; Fri, 20 Dec 2024 17:45:13 +0000 (UTC) X-FDA: 82916062614.23.D2888B5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf27.hostedemail.com (Postfix) with ESMTP id 7DEC84000B for ; Fri, 20 Dec 2024 17:44:33 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734716673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gjjrUbEJ6B4V8do1nuqA6rng7w4zIx1gLNt5aGCzi/I=; b=AXNUOTGGK1Qdze64BEVJfJoIOAVgaoJIjq9XOL7X6FcPndB2YFKqOgtpEeu7VdTe5hHjXY 5aUg6jJuKdAlJAp/JTwYtj3M+KC/D8T2fL2lBwtY7GdNAmsSbIzEahXJB1WjyN7qWIycA8 MoMzjL0HdrfIKJNLUPbPyTNrjZsLCqw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734716673; a=rsa-sha256; cv=none; b=4QUqeycMxS/UAKPQQC6NuI0kkWwabAl0E/X/BsUQzgJvgvE1Ksx/6kU/U1xekpdSonL9/8 muL7oyeglHJ+DKDn6zHrqkMndfExWJes/in6kOgkWK5VqV5BfwYoLO/8HJM2lgyruC53uk V8+CSxWZlnNiFI+GXxG3k8TvIKIWNDc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf27.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6B5BB1480; Fri, 20 Dec 2024 09:45:38 -0800 (PST) Received: from [10.57.92.231] (unknown [10.57.92.231]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 122633F720; Fri, 20 Dec 2024 09:45:05 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 17:45:04 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 02/12] khugepaged: Generalize alloc_charge_folio() Content-Language: en-GB To: "Christoph Lameter (Ampere)" Cc: Matthew Wilcox , Dev Jain , akpm@linux-foundation.org, david@redhat.com, kirill.shutemov@linux.intel.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-3-dev.jain@arm.com> <5e716fd3-2393-8d41-bb68-9f589e4db290@gentwo.org> From: Ryan Roberts In-Reply-To: <5e716fd3-2393-8d41-bb68-9f589e4db290@gentwo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7DEC84000B X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: qyidwttdzh5zs489p5xpt7gytgxfk88y X-HE-Tag: 1734716673-970979 X-HE-Meta: U2FsdGVkX1+SVONQZ2HtVHlLyWg/Q9BhoFa1I/0Iqwro3oEWzp0+T4naG0aPLZcM9dRANgHK1ggmKX/B4sYRtZjauV55kTBbHOgymcpYTr+Wb9XOJo9rXRJzS4mYAVQ/ctw3v826iEdvjeFyMMqHLeL/QHvg42/ykXGS8VYsePY8os+EJ/sPolk9eoariingzmW303nA3JEXWosSPV/9ieaOs8ukZkMZSnzr/DRQl1TEUMfBM2PWsZYe3wSsSDLffXzRHFACt7Rvkv6mIxQ0/UkVHqymOqzTZJ5WVaF8PU+aG68ucBEWl4OFZzeNCUxhFosIfRWAH02DI++RO54lJSA4kNOuLhpJ/FJFzS/oacJs5w/aXTuJgBYUd/U/W/KAny3CkCNvJqJYNgXwyzz3PNeqCHTQEpqbSbn8VaYH+38fHXwrBgrHgOTb0IFK4RaJ8rTb468jRDs/xROyc8xr4yl9+b1lU7dJr7WSRWVAFjQfFTIwqpyrPUnpXBZ4v+bofUdNsCqty4k7u4WWyZRCe2hdL96xWEbNyZg+L4Rr8cRerppXgmfsZCp2zpMi+4m9uWj6LouRmjfk/WVJW5mTXxZU4vUOiIL8MT8vcl/Z4XpHLOAjcMJEzVR7UOxbwRnE3c/6j9ZK5tQGyvquSX3fnT/cuQ1Qq5nzl0k2ekvg6CjgyMG+QaZ5QpgcVWokbwm90dFz1NRTaOP4llfJ60inrVpG0oOu+xUiKvVR7NnRV9v3H+4WgH8iCeA7osS1KCRCCZSXM3m25A+zc8Fs4zr4Z5n6Go/ld6UqfnDVIsJfmL+lIiVNx8TObIIp0DswfvQIljYAN1PBU910iwFjFJQ3OxbhKimpUf2yNStpYLkbALl2gpLfZ0aK2gQvktYENdL47weVvSmF1h8cGlUbeKkBKwjSlFgQltXMonIz+kBKlNP9lKjeXTfAy8RAN/sSFa0cauMcEPTaNt+VJmYtFPy yt7ZKfb0 89FHUZ37oRFFR1hllXkv8M5ygEy6pWWtv8uIFHQZRrXfgu8/dW5rpfPgWQIjq379Sg6x7C3b87S+RPV2yN25XHpUh4UVXDuTMVnuScv27YwJK3VbdLF8sis8lXS+pd3De0i2yHyZNgfwsl6kkXkGHSrWpuUobSq3Cm+0Rat/deCOCPnCV6NCKQcR/kXziDKI477G4A8FjlpXlPfUIQT77eWibGUFHEgVbTkZQOA3qAsaVfF1WS7xNKzyJylzMTQcr9MYF5J7CcY0Nn2amDNajawHeu8+yTZIC0GM7FOtfkjsQu54p+h4wi3GH6BJ6gJj9w4qBRZiqqbAeHCF/9a0ilOrNp8s72w8HAYQg2giY0kPSchl5Z4btE7dvl7dYQf/Bn0iM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 20/12/2024 17:41, Christoph Lameter (Ampere) wrote: > On Tue, 17 Dec 2024, Ryan Roberts wrote: > >> We previously decided that all existing THP stats would continue to only count >> PMD-sized THP for fear of breaking userspace in subtle ways, and instead would >> introduce new mTHP stats that can count for each order. We already have >> MTHP_STAT_ANON_FAULT_ALLOC and MTHP_STAT_ANON_FAULT_FALLBACK (amongst others) so >> these new stats fit the pattern well, IMHO. > > Could we move all the stats somewhere into sysfs where we can get them by > page order? /proc/vmstat keeps getting new counters. This is exactly what has been done already for mthp stats. They live at: /sys/kernel/mm/transparent_hugepage/hugepages-kB/stats/. So there is a directory per size, and there is a file per stat.