From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDF8C4828F for ; Thu, 8 Feb 2024 22:04:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E6956B009A; Thu, 8 Feb 2024 17:04:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 596996B009B; Thu, 8 Feb 2024 17:04:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45E4C6B009C; Thu, 8 Feb 2024 17:04:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 35D476B009A for ; Thu, 8 Feb 2024 17:04:51 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04DB4C0FEE for ; Thu, 8 Feb 2024 22:04:50 +0000 (UTC) X-FDA: 81770017182.07.C7961C0 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) by imf14.hostedemail.com (Postfix) with ESMTP id 0BCF9100002 for ; Thu, 8 Feb 2024 22:04:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=QPi9w618; spf=pass (imf14.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707429889; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+ElTeIhKQdcYOTGIX0k2qIyL/DOZ88xRVFWlfyfhkYk=; b=Pop0m3YMUcAxIDRQoDYjuD82wHzEjTGaUOdQsWoGnztOfzBRLyWJeUL9RzryTMoFTlgydH PAHw5gbmFKe6JAFipAge7FkPByS8R7y9ZVIzAZ7BPLTJpcU2LrUDUvXAVEwToWpneJVjOA Yb1V+BjeyS2WWn1Vd8JwnTuv0bXmUbY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707429889; a=rsa-sha256; cv=none; b=Q2D8Za/g4+h9uuTuEuE4DjwuJILcffFtFIIhBdFPUW+Fy0h/rulQKmQKI06/8KVtY4WYz5 o7FjCpT9hakIz7aWy4CqWSJGTW+GQeXrGX7bxqnicHQR1bzN9PL9tVJBK2ww0O5F+WeJzs Z7vkFmL7O1U3918cWjN4uJJKzUVlQqM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=efficios.com header.s=smtpout1 header.b=QPi9w618; spf=pass (imf14.hostedemail.com: domain of mathieu.desnoyers@efficios.com designates 167.114.26.122 as permitted sender) smtp.mailfrom=mathieu.desnoyers@efficios.com; dmarc=pass (policy=none) header.from=efficios.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1707429887; bh=Lj0yj5k2Ucs4SxuNKFcA0jefNpL/MeJWdfUW/qhrm9Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QPi9w618PKwnA9XXOQgmCJB1PCRsMn9Uf67yi2RMSz+npuqM1XhKC7wv0qn/5qaPZ HtBBgHJW61pZKEUsgM3zLsLXEe86GqM9Phz9OBoAMCs4XewbLcgNcWisq0fpdud38S 4+Cak3UtLlm7WZZcn4+/e6iz1E4DwB1CN767MGyarGK4n5Em+teSI+EgIpfRi5kayu FZw7bi34H+EYdcnCWkmUKL9ZD5zDBU6c7Yy7VjUqHCA/Jl05m7ySivgFkCGTg3BslR 2YD+qB8C1BDraBeGGpeO0/Ly1umtbT7QEm6IpByZbYEiI7Av04b1Noi+TDQJ0soltb Y9mP8c1pyefEQ== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4TW9y72DKCzXtH; Thu, 8 Feb 2024 17:04:47 -0500 (EST) Message-ID: Date: Thu, 8 Feb 2024 17:04:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 01/12] nvdimm/pmem: Fix leak on dax_add_host() failure Content-Language: en-US To: Andrew Morton Cc: Dan Williams , Arnd Bergmann , Dave Chinner , linux-kernel@vger.kernel.org, Linus Torvalds , Vishal Verma , Dave Jiang , Matthew Wilcox , Russell King , linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-s390@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Mikulas Patocka References: <20240208184913.484340-1-mathieu.desnoyers@efficios.com> <20240208184913.484340-2-mathieu.desnoyers@efficios.com> <20240208132112.b5e82e1720e80da195ef0927@linux-foundation.org> From: Mathieu Desnoyers In-Reply-To: <20240208132112.b5e82e1720e80da195ef0927@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: cj9nqcr5mdmn7fuqefq7qh5qyyzm8mag X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0BCF9100002 X-Rspam-User: X-HE-Tag: 1707429888-68802 X-HE-Meta: U2FsdGVkX1/yZNP/A6nN9WD0Gv6V/7TlTNk6dlhERBMQW625LfmcIyG+5TxS7UEpwT1EyDab+oFDMFGEa2z+j5UukOL6h+0UNz/WmviA4uKxofwnIUQGYGJb5UDhs86OcaB9jq03oV0BYaJFz69qS4bwI/J1gn/9RemznBD6UBcX/PBNZ3WE9B5MkTfFxiyRhaMXV2WHDa9YwTAXz91tAEtuGciIkAmxJlqLWhTb883nqQ8IA2/rOmXPDdimWynSybshA5VVY7CaxaLGeQBhlmZTndKCDgRyH5Weriy/KlauIJMFrkQZ5mqFubIq1HozWVOGVQnXebaLNzQwT+MsnNavxQUws0NxZsMOwVh4viyv95CGLFu1W+O/Ud/LkC7n7vfe+Eygq3/Q37TdOJP4M9+XParMdomCS2revGj5LEH3cCokEDgwhSJK+EAFqUYV1oLiUUokWpozkl8DZTJ7njh0h7e9L5gyRVWP3nVTsEJbuTmzB+42ONyFBLfqk0kDGNXCzFz2A+e90WsfVLa0zBBhfLMAlGms7Gu/AOI8MvgXryVsXG6lEQPeRVgLmCMX0bwrTe2b9SCs2IwJB/G2+1kvZdtDOJS5gnuYcuYB4sQphet30l+3gz46CrqxAfJfjjg+c93t3sXqKShJXataff8nuKM6bwfniennTHz1tt3lIyOzKzv64rvIvaq1/WULLn3KCu+90ac+YZdqrU0Gx/zqwKhuFaJSMAmM94fnymqhUINmlZavcM2POXjWl3nkBuMh4PYCWYhtSWGHXBD6rMhUWm4i7jAhsISVVrDdQUtcQtI0O4leMIl/+LYA9Wcd3eCb2WWMbPR+Nbf62lpn6PdN/VKfUf8hj/mmI3Sd1wI9Z58aZrFlHKH7d7OJCsYp7uTN1glnOUyHh3kwmO0zmJZuhcymphb7FXu6n78Lr2kaDGTd5AheEqV/+ubxiQmusZiphZVFRAeAr4D3yGX xCzuoDmx LGJKlcPVrisDVRh3RZTnDwyNZT6FLA6O8LqwsJD05qa5Lwp5j9mWb2R3wvxEMcH3gB9FNUBHe6iZsjYCTGttsrnBvBgMrzV1jLisoFx/1JBoxp+h0Q5djCA5Z3JS1cCs0tk/ki5vqYFeRe+RwwOoijTUlRvSIJgQHqY0YHjChHGfaEMDWyIpCZafFCuGbYFpOsXd4EXandEnE2NqOfr+p6pQQ5oSis69zVk8fxab5+Tb5DU7/koYylIk6hnM6FbIxp65tdu+NTYYq0GX2NsrCfpvxNs1BvDUFXlRpFr1F7EaeabigNjkJIT8G6WfkphUrdIcKf+CiWKEVZxLlijrmA7T93Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-02-08 16:21, Andrew Morton wrote: > On Thu, 8 Feb 2024 13:49:02 -0500 Mathieu Desnoyers wrote: > >> Fix a leak on dax_add_host() error, where "goto out_cleanup_dax" is done >> before setting pmem->dax_dev, which therefore issues the two following >> calls on NULL pointers: >> >> out_cleanup_dax: >> kill_dax(pmem->dax_dev); >> put_dax(pmem->dax_dev); > > Seems inappropriate that this fix is within this patch series? > > otoh I assume dax_add_host() has never failed so it doesn't matter much. > > > The series seems useful but is at v4 without much sign of review > activity. I think I'll take silence as assent and shall slam it all > into -next and see who shouts at me. > Thanks Andrew for picking it up! Dan just reacted with feedback that will help reducing the patch series size by removing intermediate commits. I'll implement the requested changes and post a v5 in a few days. So far there are not behavior changes requested in Dan's feedback. Should I keep this patch 01/12 within the series for v5 or should I send it separately ? Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com