From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED212C001E0 for ; Wed, 26 Jul 2023 09:28:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 741ED6B0071; Wed, 26 Jul 2023 05:28:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A4268D0001; Wed, 26 Jul 2023 05:28:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51FA46B0075; Wed, 26 Jul 2023 05:28:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 41A5D6B0071 for ; Wed, 26 Jul 2023 05:28:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0AC74C014A for ; Wed, 26 Jul 2023 09:28:48 +0000 (UTC) X-FDA: 81053238336.07.CDC2C37 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf21.hostedemail.com (Postfix) with ESMTP id 170991C0017 for ; Wed, 26 Jul 2023 09:28:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=RgneqgkX; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690363726; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ET5z1iXVl3TCzfyIPhSPq9r+sES1n7GH6hJTCnF+vYo=; b=UtAHFUkvrPtIJNNmZUtfYmPLXXoF8Y8dd9s6f9oiZ7IqDLeJpYc8O3jQMMMybTpbVrhsGY oOhk4v3EZAwkv6NQdQakQatj7tZSNnSYgXrDEvM5C7wcbsTFHS47ehUS1zWdA5FytPCTNl gv1UwgiZ0WD0yMqzjlULkb07SAFAAWA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=RgneqgkX; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690363726; a=rsa-sha256; cv=none; b=cJuS97jTLQ6Gs9VVxQhopsdUFTGFgONpbBgnGczKUR8yv7JEGnQpOj7f1CE6van3Ahrp5v OWTdQ+1mPlhZGmP8XXR6zTNjwBMkaFLuwAy3Z9epi8h/Bj3TTuNniOYQofg3ZTOF0fxWbH eQ39w0vjZvnukhdF24JmAmPBH06OMgY= Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6748a616e17so1654062b3a.1 for ; Wed, 26 Jul 2023 02:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690363725; x=1690968525; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ET5z1iXVl3TCzfyIPhSPq9r+sES1n7GH6hJTCnF+vYo=; b=RgneqgkXKODRrFr78EJ2DiU2LP1auMSsEluGXDNHK2/ImK1m1wgxIc9rc0KyChzerd 9pp9E0d70JkoKPUeaRftr+jglcQl9qJ1NHO80UjvVHwRcDm/HyYkv/adcdLVyb0tT2RZ DBfPuhO0Xzb3EkxZ8Lnv+NpBNxlgzINPxdWjI2p4gXmhxr9F42wMDqq5WIk8CWvg0ei0 04D2fNryYi6h/fKlwXKsAJNXxbdFzcjkeSQHK+ZzWAzpfHtAdyeZZlzM27TnNlh1u/69 UWlC2QlusG6aR16W+ARLMoeEnjaKWlhVg7tepMtvkY5m/QLzYLh0WRDX9uQBe16cx9gs O9rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690363725; x=1690968525; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ET5z1iXVl3TCzfyIPhSPq9r+sES1n7GH6hJTCnF+vYo=; b=NS0muu2aJEYdlUNgCFJPm53Tsfj5EMNQ+B3I+i2d9ivHU4gVspzn1+98qqhi055jii neYrwS/gquygmUGJWD7VP4ebiMOMTJiBsZKWHX63dYcrFyi4LC3g5Vc30vl8kjISN2yg pv4TZOMKdk9TF8uF/dXMISog20Ub37+GWwumxgJWpVj9yidEjS7gE2YL0FyHIlkNUwT4 ECfJMpN59Wq82fTglewXe8s0DqfwS8QPY98c5WpJN0ToDRP+ArMvi+9YPrBUhXVNpK6Y xYfTbCw6Edija5mqaNAchW0XLvd8PloYOaeMSFQ5s+l/8zCbQKKZy6NKU7ATJv9xrnXo mWrw== X-Gm-Message-State: ABy/qLbnxu9hcPeLKQwO7wNeoZW/pn58Dh22oO05shwUWofK/y3MItXI er1X+7hMp6Uc+bdlLZ+aNdQQPriz2puGitqnfJE= X-Google-Smtp-Source: APBJJlFvSUUJYrPzKxRMgKGWHa7iMtrF7iaocGD/XAPkPO20BZ2/Wf52mLvF02dnCC8LpFHDclZgZw== X-Received: by 2002:a17:903:41c8:b0:1bb:83ec:832 with SMTP id u8-20020a17090341c800b001bb83ec0832mr2040388ple.2.1690363724990; Wed, 26 Jul 2023 02:28:44 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id bc2-20020a170902930200b001a95f632340sm12591323plb.46.2023.07.26.02.28.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 02:28:44 -0700 (PDT) Message-ID: Date: Wed, 26 Jul 2023 17:28:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 21/47] mm: workingset: dynamically allocate the mm-shadow shrinker Content-Language: en-US To: Muchun Song Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230724094354.90817-1-zhengqi.arch@bytedance.com> <20230724094354.90817-22-zhengqi.arch@bytedance.com> <08F2140B-0684-4FB0-8FB9-CEB88882F884@linux.dev> From: Qi Zheng In-Reply-To: <08F2140B-0684-4FB0-8FB9-CEB88882F884@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 170991C0017 X-Stat-Signature: u9ni4h8s63ifddtseegyboaccggs9qby X-HE-Tag: 1690363725-456564 X-HE-Meta: U2FsdGVkX18YWJ1ZtDYt4K7cTgHT76kSA4/PCQ3KcjMdyAEH+MVeCbE3OYUHe5jsfE9qeuPa1hn4BolddtbkmchCp6bfkUC1yyYVJWbZqkP17o0w6yTOWtMIOku0OJ7u6ckUR3L/aDlDaDuEvhgBB/ZqRzyv1ensLIHEAtHVrEpqzTwpBXegrKiBhy7c6yjNN/Rxl0NuQndewooy/E/RjiP5A9JfFTkNsJOZoPzvAJMhqQZBpcX/auwhxBhPpSvWOpB7vRXnb7ICRZThZ8kfoHBxs55UKd8kvvAVuxdm0wsd6qj8IyhNQzMzHBq97U5sJdnUWzPoS1Haemnk8rk/F+mlT2BkPoSVoWeXlaRAwLUl9BdRLWZxpaD6hJvc30+Ghbul9nRnUmhumF+/35x7KunqJFo5czye+PHVWpCSlIW+9y+44pQW7/dTY7fol97yoF8dVRcBtMkHWZRbaIMqeucJ3/U83t4vzuispqzGsPcuM2bdWz9AbKk8MZnz/mD8ELgdhl1IYkOVDCqh0UbPeUosHLEU1LqHVBzQea4DfVko6StskXwWLjzYMnCMoEL+SaZyKAvizvEZGjn/IvJQPA9zqCCwEb9mnd0T5Y5KXaE347mNgj5E8J3yNxwZoHESeGQGPbhTYwi3OKRxfp4Gdq+d6y/oCk1IjEwPRNYIXFMuVvodXU0NY5zveAcEQ+zHGpt8tTN++7o2tW8TlWNrZ7QYeL8Hc3OJerLbH5F9IbsvajU7goip2iPwOlfMu/FVab8p972H1n1YnlVBAJOgY022SGlIOOgBL0h0hGZnNLpN4bsqGpX+Jp52hASibTblRtOvEzCHMU23EHwAMaZ8B4rLWr4npPRlgFos6ojyQGkAL/4tgB+VbgBIiZwfthi/zZC/KBsHuchgPBLle0N+XUFdrK8rV2NoeMQjDOJB4gn1uuJIEB+/3Kjgdk8b7HVmG5YLT6WM9+KQdrhhisR aiHOH9ZJ i7x79IRuWGynoqPf7tI4zQGM8IhzGPgcbw1DpW30PmNQENtyYcAgX3igns/sDb0u/q1nNadQORRhA6Hszj4OSL5Ry/Rw/nn/E353FMzPLej4qGFdEVotzqFtmbVfGUVbNFj/nh0wslVud2zLhGrJ6YXjgJIK+OW0+4W4d6BDdmsSU+KRtWE1foQ+iGNKh3Se0cbX9G4nPxijLkdxldOVPZQ8X5BrKjjIfwnF2UMiCUzioMrJ+VFiLCmv8qsNsAPCt0npmWMJuAS8lVgRdZDe2eVDJEGxRiCunLyBHOOoTYtotm6Xk1TcT/T8dHNM1io4mVmlE9oKUyGrUdU6Sam/u3ccWD+R1h2VEvVgtn4U3Z8A1PLaRS371i6veWp7ojnng1e+g1ynRiEOygUw2X7bmcnTqDR5Wn1SDYjqGveeGV85Fgw4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/26 15:13, Muchun Song wrote: > > >> On Jul 24, 2023, at 17:43, Qi Zheng wrote: >> >> Use new APIs to dynamically allocate the mm-shadow shrinker. >> >> Signed-off-by: Qi Zheng >> --- >> mm/workingset.c | 26 ++++++++++++++------------ >> 1 file changed, 14 insertions(+), 12 deletions(-) >> >> diff --git a/mm/workingset.c b/mm/workingset.c >> index 4686ae363000..4bc85f739b13 100644 >> --- a/mm/workingset.c >> +++ b/mm/workingset.c >> @@ -762,12 +762,7 @@ static unsigned long scan_shadow_nodes(struct shrinker *shrinker, >> NULL); >> } >> >> -static struct shrinker workingset_shadow_shrinker = { >> - .count_objects = count_shadow_nodes, >> - .scan_objects = scan_shadow_nodes, >> - .seeks = 0, /* ->count reports only fully expendable nodes */ >> - .flags = SHRINKER_NUMA_AWARE | SHRINKER_MEMCG_AWARE, >> -}; >> +static struct shrinker *workingset_shadow_shrinker; > > > Same as patch #17. OK, will do.