From: Gregory Price <gourry@gourry.net>
To: Pedro Falcato <pfalcato@suse.de>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hughd@google.com,
david@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com,
vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, baolin.wang@linux.alibaba.com,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
stable@vger.kernel.org
Subject: Re: [PATCH] mm/shmem: use invalidate_lock to fix hole-punch race
Date: Fri, 27 Mar 2026 00:35:06 -0400 [thread overview]
Message-ID: <acYI-gqDOBbZ-bEn@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <bnukmnuxxuhdfeasjz33miemgr7w35c4aa6pqdmgupx7oxmeeb@gozgc3yxhcdd>
On Thu, Mar 26, 2026 at 07:16:05PM +0000, Pedro Falcato wrote:
> On Thu, Mar 26, 2026 at 01:37:17PM -0500, Gregory Price wrote:
>
> _If_ there is indeed breakage here regarding tree rotations, I would suggest:
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 5754d1c36462..7b4e39063d67 100644
fwiw this does not resolve the BUG() i'm observing.
I'm still trying to find a good reproducer that doesn't require
launching ~100s of VMs and ballooning them, but the condition here seems
extremely narrow.
~Gregory
next prev parent reply other threads:[~2026-03-27 4:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 16:26 Gregory Price
2026-03-26 17:07 ` Pedro Falcato
2026-03-26 18:37 ` Gregory Price
2026-03-26 19:16 ` Pedro Falcato
2026-03-26 19:48 ` Gregory Price
2026-03-27 4:35 ` Gregory Price [this message]
2026-03-26 19:21 ` Matthew Wilcox
2026-03-26 20:09 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acYI-gqDOBbZ-bEn@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=hughd@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox