From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7139BC433EF for ; Mon, 13 Jun 2022 01:48:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9582C8D0140; Sun, 12 Jun 2022 21:48:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 905AE8D013C; Sun, 12 Jun 2022 21:48:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CDA78D0140; Sun, 12 Jun 2022 21:48:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6DAB68D013C for ; Sun, 12 Jun 2022 21:48:33 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3F27F34916 for ; Mon, 13 Jun 2022 01:48:33 +0000 (UTC) X-FDA: 79571528106.17.0A6BBA3 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf01.hostedemail.com (Postfix) with ESMTP id 606F84009F for ; Mon, 13 Jun 2022 01:48:32 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LLvbT2MstzDqsL; Mon, 13 Jun 2022 09:48:05 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 13 Jun 2022 09:48:28 +0800 Subject: Re: [PATCH 1/7] mm/khugepaged: remove unneeded shmem_huge_enabled() check To: Andrew Morton CC: , , , , , , , , , , References: <20220611084731.55155-1-linmiaohe@huawei.com> <20220611084731.55155-2-linmiaohe@huawei.com> <20220611133336.b582edd4c2c2df15f5561d2b@linux-foundation.org> From: Miaohe Lin Message-ID: Date: Mon, 13 Jun 2022 09:48:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220611133336.b582edd4c2c2df15f5561d2b@linux-foundation.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655084912; a=rsa-sha256; cv=none; b=Br77+sDjL7zkSCdF5g8OOCBPAKdaICr9lz4Dn0xpqk855/p1TD/eiec5J5z9Uztm20aYQM 7ZMZwKY3qYXC3uRd/0YHTtpZbxr1W/bitXwHIMylRxFwNTZgU8pXGGbaccmqI9T/q315hv MTQunfQH2fxycbbgQKmmBhEnph83iBA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655084912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bXv04/LIecWZUh1kkoDsNJHxyt1LRZKb1eQWu17Ljqw=; b=mCbJPwOGhqCwhXfni+7GQW44o2gHBamtsbm0u1xHI6EsYzbQM2YOJaRRK6g2w9vBM09o4D rebjhjH6TWJhuG3GV00x5tDIXZLpoN6vd0BPpQwXT2hfQzMP3VCbre2ywxiLFmZWefHVvv +puQExa/ij5i8BGEuGXESXH0ihdeLw0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: ou5w8ea5uarx8f5b8apau4srb16zrjjp X-Rspamd-Queue-Id: 606F84009F X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1655084912-493911 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/12 4:33, Andrew Morton wrote: > On Sat, 11 Jun 2022 16:47:25 +0800 Miaohe Lin wrote: > >> If we reach here, hugepage_vma_check() has already made sure that hugepage >> is enabled for shmem. Remove this duplicated check. > > I updated this to > > If we reach here, hugepage_vma_check() has already made sure that hugepage > is enabled for shmem, via its call to hugepage_vma_check(). Remove this > duplicated check. Do you mean "khugepaged_scan_mm_slot() has already made sure that hugepage is enabled for shmem, via its call to hugepage_vma_check()"? Thanks! > > . >