linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: "Ryan Roberts" <ryan.roberts@arm.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Shuah Khan" <shuah@kernel.org>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Mark Brown" <broonie@kernel.org>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Florent Revest" <revest@chromium.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"SeongJae Park" <sj@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 2/9] selftests/mm: Give scripts execute permission
Date: Thu, 13 Jul 2023 16:39:33 +0200	[thread overview]
Message-ID: <ac816a32-cea9-363f-4490-19e6f5225c3d@redhat.com> (raw)
In-Reply-To: <20230713135440.3651409-3-ryan.roberts@arm.com>

On 13.07.23 15:54, Ryan Roberts wrote:
> When run under run_vmtests.sh, test scripts were failing to run with
> "permission denied" due to the scripts not being executable.
> 
> It is also annoying not to be able to directly invoke run_vmtests.sh,
> which is solved by giving also it the execute permission.
> 
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
>   tools/testing/selftests/mm/charge_reserved_hugetlb.sh  | 0
>   tools/testing/selftests/mm/check_config.sh             | 0
>   tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 0
>   tools/testing/selftests/mm/run_vmtests.sh              | 0
>   tools/testing/selftests/mm/test_hmm.sh                 | 0
>   tools/testing/selftests/mm/test_vmalloc.sh             | 0
>   tools/testing/selftests/mm/va_high_addr_switch.sh      | 0
>   tools/testing/selftests/mm/write_hugetlb_memory.sh     | 0
>   8 files changed, 0 insertions(+), 0 deletions(-)
>   mode change 100644 => 100755 tools/testing/selftests/mm/charge_reserved_hugetlb.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/check_config.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/hugetlb_reparenting_test.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/run_vmtests.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/test_hmm.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/test_vmalloc.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/va_high_addr_switch.sh
>   mode change 100644 => 100755 tools/testing/selftests/mm/write_hugetlb_memory.sh
> 
> diff --git a/tools/testing/selftests/mm/charge_reserved_hugetlb.sh b/tools/testing/selftests/mm/charge_reserved_hugetlb.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/check_config.sh b/tools/testing/selftests/mm/check_config.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/test_hmm.sh b/tools/testing/selftests/mm/test_hmm.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/test_vmalloc.sh b/tools/testing/selftests/mm/test_vmalloc.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/va_high_addr_switch.sh b/tools/testing/selftests/mm/va_high_addr_switch.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/mm/write_hugetlb_memory.sh b/tools/testing/selftests/mm/write_hugetlb_memory.sh
> old mode 100644
> new mode 100755

Sounds reasonable to me.

Probably due to:

commit baa489fabd01596d5426d6e112b34ba5fb59ab82
Author: SeongJae Park <sj@kernel.org>
Date:   Tue Jan 3 18:07:53 2023 +0000

     selftests/vm: rename selftests/vm to selftests/mm
     
     Rename selftets/vm to selftests/mm for being more consistent with the
     code, documentation, and tools directories, and won't be confused with
     virtual machines.


and indeed, it contains

diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
old mode 100755
new mode 100644
similarity index 100%
rename from tools/testing/selftests/vm/run_vmtests.sh
rename to tools/testing/selftests/mm/run_vmtests.sh


Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb



  reply	other threads:[~2023-07-13 14:39 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 13:54 [PATCH v1 0/9] selftests/mm fixes for arm64 Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 1/9] selftests: Line buffer test program's stdout Ryan Roberts
2023-07-13 14:16   ` Mark Brown
2023-07-13 14:32     ` Ryan Roberts
2023-07-13 14:45       ` Mark Brown
2023-07-17  8:36     ` Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 2/9] selftests/mm: Give scripts execute permission Ryan Roberts
2023-07-13 14:39   ` David Hildenbrand [this message]
2023-07-13 17:32     ` SeongJae Park
2023-07-14  9:44       ` Ryan Roberts
2023-07-14 16:00         ` SeongJae Park
2023-07-14 16:11           ` Mark Brown
2023-07-14 16:26         ` Andrew Morton
2023-07-14 16:28           ` Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 3/9] selftests/mm: Skip soft-dirty tests on arm64 Ryan Roberts
2023-07-13 13:56   ` David Hildenbrand
2023-07-13 14:03     ` Ryan Roberts
2023-07-13 14:09       ` David Hildenbrand
2023-07-13 14:12         ` David Hildenbrand
2023-07-13 14:16           ` Ryan Roberts
2023-07-13 14:14         ` Ryan Roberts
2023-07-13 14:29           ` David Hildenbrand
2023-07-15  0:04   ` John Hubbard
2023-07-17  8:23     ` Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 4/9] selftests/mm: Enable mrelease_test for arm64 Ryan Roberts
2023-07-13 14:32   ` David Hildenbrand
2023-07-13 13:54 ` [PATCH v1 5/9] selftests/mm: Fix thuge-gen test bugs Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 6/9] selftests/mm: va_high_addr_switch should skip unsupported arm64 configs Ryan Roberts
2023-07-13 14:41   ` David Hildenbrand
2023-07-13 13:54 ` [PATCH v1 7/9] selftests/mm: Make migration test robust to failure Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 8/9] selftests/mm: Optionally pass duration to transhuge-stress Ryan Roberts
2023-07-13 13:54 ` [PATCH v1 9/9] selftests/mm: Run all tests from run_vmtests.sh Ryan Roberts
2023-07-13 14:50   ` David Hildenbrand
2023-07-13 15:04     ` Ryan Roberts
2023-07-13 15:25       ` David Hildenbrand
2023-07-13 15:30         ` Ryan Roberts
2023-07-13 15:30       ` Mark Brown
2023-07-13 15:36         ` Ryan Roberts
2023-07-13 15:43           ` Mark Brown
2023-07-13 15:46             ` Ryan Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac816a32-cea9-363f-4490-19e6f5225c3d@redhat.com \
    --to=david@redhat.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=revest@chromium.org \
    --cc=ryan.roberts@arm.com \
    --cc=shuah@kernel.org \
    --cc=sj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox