From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10901C3DA4A for ; Thu, 8 Aug 2024 21:51:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 984BC6B0088; Thu, 8 Aug 2024 17:51:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9350C6B008A; Thu, 8 Aug 2024 17:51:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FDAE6B008C; Thu, 8 Aug 2024 17:51:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6194A6B0088 for ; Thu, 8 Aug 2024 17:51:13 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DEA8E401F1 for ; Thu, 8 Aug 2024 21:51:12 +0000 (UTC) X-FDA: 82430424384.21.424EDED Received: from cmx-mtlrgo002.bell.net (mta-mtl-005.bell.net [209.71.208.25]) by imf06.hostedemail.com (Postfix) with ESMTP id E1349180003 for ; Thu, 8 Aug 2024 21:51:09 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bell.net header.s=selector1 header.b=xi41Xjwc; spf=pass (imf06.hostedemail.com: domain of dave.anglin@bell.net designates 209.71.208.25 as permitted sender) smtp.mailfrom=dave.anglin@bell.net; dmarc=pass (policy=none) header.from=bell.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723153861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QbCuvy68bNg+jVzt6j9pL2SeLJl6b+IH/AG3RvaNcvM=; b=8ZbP/2XRUtn3sldpSCPvuJ/zd+CDIBiK5eXhMT1D2MatXFPWMVc9dTuWJ5cCWFO8LV4fln LAcz+bLAiufZyLfzKIfW5PxiiwUnG23txBH4ymPNaAHrdTA0oN9LsQPiHtaIVztr8IEeZ8 /6PdhDy9A0JWMr+D89UzN6JlRyUGlPk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bell.net header.s=selector1 header.b=xi41Xjwc; spf=pass (imf06.hostedemail.com: domain of dave.anglin@bell.net designates 209.71.208.25 as permitted sender) smtp.mailfrom=dave.anglin@bell.net; dmarc=pass (policy=none) header.from=bell.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723153861; a=rsa-sha256; cv=none; b=FIge02BhgTRfU8c6QhipItFrOaxK1xXJUv0pa69HPNvvaN+fl7048BXI47znfWQMsGKT/J u6ECIBsFW4o1R9TbMHu+JeydXRotYZL7Vt0aq2Ncr1Os1gGtBwFyYmt82yNeYUktquNDWw cVZPzKuLarLRdgCl9Ofy8SbMIaoczio= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bell.net; s=selector1; t=1723153870; bh=QbCuvy68bNg+jVzt6j9pL2SeLJl6b+IH/AG3RvaNcvM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Content-Type; b=xi41Xjwc9/ZFkmpV71hWJCk31d0M93BX7QUmgrpS355L3ICT69AoW+O39gmSnknFUhxfbxgaZBMwbnrhHDF6LZLxrRqm2u3dSxvKvTcnmbzMACKuPloXn4HqtpZBP9/wP9SX/j3suxJpmSF0tbeMEYM7JmrDrMvhFYxeCholyBOJzYvY4WBYN0nG9cx3Vuxio8VL+Au9WVDrfpncT1ZP8CyUDlyyH9j3EgtAxwk9z+zoTw46OiKOOE4HMwX3VDArQYTZ2GGJ6sxa26+wMGVeEjjKeJ/vy+C43O56j9KyL+JppppAP3weZp/JFXrC/6KOnbKqIwE2cMKlmfcYmrz9ug== X-RG-SOPHOS: Clean X-RG-VADE-SC: 0 X-RG-VADE: Clean X-Originating-IP: [76.71.115.75] X-RG-Env-Sender: dave.anglin@bell.net X-RG-Rigid: 6698E80E02163C9A X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgeeftddrleefgddtvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceugffnnfdpqfgfvfenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeflohhhnhcuffgrvhhiugcutehnghhlihhnuceouggrvhgvrdgrnhhglhhinhessggvlhhlrdhnvghtqeenucggtffrrghtthgvrhhnpeejleffffejhefggfeuheelgeefgeeuieegtdekffegudeuteffgeffjedukefgueenucfkphepjeeirdejuddrudduhedrjeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddvrdeglegnpdhinhgvthepjeeirdejuddrudduhedrjeehpdhmrghilhhfrhhomhepuggrvhgvrdgrnhhglhhinhessggvlhhlrdhnvghtpdhnsggprhgtphhtthhopedutddprhgtphhtthhopegurghvvgdrrghnghhlihhnsegsvghllhdrnhgvthdprhgtphhtthhopeguvghllhgvrhesghhmgidruggvpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqmhhmsehkvhgrtghkrdhorhhgpdhrtghpthhtoheplhhinhhugidqphgrrhhishgtsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugies rhhovggt khdquhhsrdhnvghtpdhrtghpthhtoheprhhitghhrghrugdrhhgvnhguvghrshhonheslhhinhgrrhhordhorhhgpdhrtghpthhtohepthhglhigsehlihhnuhhtrhhonhhigidruggv X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.2.49] (76.71.115.75) by cmx-mtlrgo002.bell.net (authenticated as dave.anglin@bell.net) id 6698E80E02163C9A; Thu, 8 Aug 2024 17:50:37 -0400 Message-ID: Date: Thu, 8 Aug 2024 17:50:37 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.10 000/809] 6.10.3-rc3 review To: Guenter Roeck , Linus Torvalds , Thomas Gleixner Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, Linux-MM , Helge Deller , linux-parisc@vger.kernel.org, Richard Henderson References: <20240731095022.970699670@linuxfoundation.org> <718b8afe-222f-4b3a-96d3-93af0e4ceff1@roeck-us.net> <53b2e1f2-4291-48e5-a668-7cf57d900ecd@suse.cz> <87le194kuq.ffs@tglx> <90e02d99-37a2-437e-ad42-44b80c4e94f6@suse.cz> <87frrh44mf.ffs@tglx> <76c643ee-17d6-463b-8ee1-4e30b0133671@roeck-us.net> <87plqjz6aa.ffs@tglx> <87a5hnyox6.ffs@tglx> <8734nezz0g.ffs@tglx> Content-Language: en-US From: John David Anglin Autocrypt: addr=dave.anglin@bell.net; keydata= xsFNBFJfN1MBEACxBrfJ+5RdCO+UQOUARQLSsnVewkvmNlJRgykqJkkI5BjO2hhScE+MHoTK MoAeKwoLfBwltwoohH5RKxDSAIWajTY5BtkJBT23y0hm37fN2JXHGS4PwwgHTSz63cu5N1MK n8DZ3xbXFmqKtyaWRwdA40dy11UfI4xzX/qWR3llW5lp6ERdsDDGHm5u/xwXdjrAilPDk/av d9WmA4s7TvM/DY3/GCJyNp0aJPcLShU2+1JgBxC6NO6oImVwW07Ico89ETcyaQtlXuGeXYTK UoKdEHQsRf669vwcV5XbmQ6qhur7QYTlOOIdDT+8zmBSlqBLLe09soATDciJnyyXDO1Nf/hZ gcI3lFX86i8Fm7lQvp2oM5tLsODZUTWVT1qAFkHCOJknVwqRZ8MfOvaTE7L9hzQ9QKgIKrSE FRgf+gs1t1vQMRHkIxVWb730C0TGiMGNn2oRUV5O5QEdb/tnH0Te1l+hX540adKZ8/CWzzW9 vcx+qD9IWLRyZMsM9JnmAIvYv06+YIcdpbRYOngWPd2BqvktzIs9mC4n9oU6WmUhBIaGOGnt t/49bTRtJznqm/lgqxtE2NliJN79dbZJuJWe5HkjVa7mP4xtsG59Rh2hat9ByUfROOfoZ0dS sVHF/N6NLWcf44trK9HZdT/wUeftEWtMV9WqxIwsA4cgSHFR2QARAQABzTdKb2huIERhdmlk IEFuZ2xpbiAoRGViaWFuIFBvcnRzKSA8ZGF2ZS5hbmdsaW5AYmVsbC5uZXQ+wsF3BBMBCAAh BQJSXzdTAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJEF2/za5fGU3xs/4P/15sNizR ukZLNYoeGAd6keRtNcEcVGEpRgzc/WYlXCRTEjRknMvmCu9z13z8qB9Y9N4JrPdp+NQj5HEs ODPI+1w1Mjj9R2VZ1v7suFwhjxMTUQUjCsgna1H+zW/UFsrL5ERX2G3aUKlVdYmSWapeGeFL xSMPzawPEDsbWzBzYLSHUOZexMAxoJYWnpN9JceEcGvK1SU2AaGkhomFoPfEf7Ql1u3Pgzie ClWEr2QHl+Ku1xW0qx5OLKHxntaQiu30wKHBcsF0Zx2uVGYoINJl/syazfZyKTdbmJnEYyNa Bdbn7B8jIkVCShLOWJ8AQGX/XiOoL/oE9pSZ60+MBO9qd18TGYByj0X2PvH+OyQGul5zYM7Q 7lT97PEzh8xnib49zJVVrKDdJds/rxFwkcHdeppRkxJH0+4T0GnU2IZsEkvpRQNJAEDmEE8n uRfssr7RudZQQwaBugUGaoouVyFxzCxdpSYL6zWHA51VojvJYEBQDuFNlUCqet9LtNlLKx2z CAKmUPTaDwPcS3uOywOW7WZrAGva1kz9lzxZ+GAwgh38HAFqQT8DQvW8jnBBG4m4q7lbaum3 znERv7kcfKWoWS7fzxLNTIitrbpYA3E7Zl9D2pDV3v55ZQcO/M35K9teRo6glrtFDU/HXM+r ABbh8u9UnADbPmJr9nb7J0tZUSS/zsFNBFJfN1MBEADBzhVn4XyGkPAaFbLPcMUfwcIgvvPF UsLi9Q53H/F00cf7BkMY40gLEXvsvdUjAFyfas6z89gzVoTUx3HXkJTIDTiPuUc1TOdUpGYP hlftgU+UqW5O8MMvKM8gx5qn64DU0UFcS+7/CQrKOJmzktr/72g98nVznf5VGysa44cgYeoA v1HuEoqGO9taA3Io1KcGrzr9cAZtlpwj/tcUJlc6H5mqPHn2EdWYmJeGvNnFtxd0qJDmxp5e YVe4HFNjUwsb3oJekIUopDksAP41RRV0FM/2XaPatkNlTZR2krIVq2YNr0dMU8MbMPxGHnI9 b0GUI+T/EZYeFsbx3eRqjv1rnNg2A6kPRQpn8dN3BKhTR5CA7E/cs+4kTmV76aHpW8m/NmTc t7KNrkMKfi+luhU2P/sKh7Xqfbcs7txOWB2V4/sbco00PPxWr20JCA5hYidaKGyQxuXdPUlQ Qja4WJFnAtBhh3Oajgwhbvd6S79tz1acjNXZ89b8IN7yDm9sQ+4LhWoUQhB5EEUUUVQTrzYS yTGN1YTTO5IUU5UJHb5WGMnSPLLArASctOE01/FYnnOGeU+GFIeQp91p+Jhd07hUr6KWYeJY OgEmu+K8SyjfggCWdo8aGy0H3Yr0YzaHeK2HrfC3eZcUuo+yDW3tnrNwM1rd1i3F3+zJK18q GnBxEQARAQABwsFfBBgBCAAJBQJSXzdTAhsMAAoJEF2/za5fGU3xNDQP/ikzh1NK/UBrWtpN yXLbype4k5/zyQd9FIBxAOYEOogfKdkp+Yc66qNf36gO6vsokxsDXU9me1n8tFoB/DCdzKbQ /RjKQRMNNR4fT2Q9XV6GZYSL/P2A1wzDW06tEI+u+1dV40ciQULQ3ZH4idBW3LdN+nloQf/C qoYkOf4WoLyhSzW7xdNPZqiJCAdcz9djN79FOz8US+waBCJrL6q5dFSvvsYj6PoPJkCgXhiJ hI91/ERMuK9oA1oaBxCvuObBPiFlBDNXZCwmUk6qzLDjfZ3wdiZCxc5g7d2e2taBZw/MsKFc k+m6bN5+Hi1lkmZEP0L4MD6zcPuOjHmYYzX4XfQ61lQ8c4ztXp5cKkrvaMuN/bD57HJ6Y73Q Y+wVxs9x7srl4iRnbulCeiSOAqHmwBAoWaolthqe7EYL4d2+CjPCcfIuK7ezsEm8c3o3EqC4 /UpL1nTi0rknRTGc0VmPef+IqQUj33GGj5JRzVJZPnYyCx8sCb35Lhs6X8ggpsafUkuKrH76 XV2KRzaE359RgbM3pNEViXp3NclPYmeu+XI8Ls/y6tSq5e/o/egktdyJj+xvAj9ZS18b10Jp e67qK8wZC/+N7LGON05VcLrdZ+FXuEEojJWbabF6rJGN5X/UlH5OowVFEMhD9s31tciAvBwy T70V9SSrl2hiw38vRzsl In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: uwp8iuczotft4syz9tfy7utjwa7embmb X-Rspamd-Queue-Id: E1349180003 X-Rspamd-Server: rspam11 X-HE-Tag: 1723153869-378048 X-HE-Meta: U2FsdGVkX196FuxqQ9Y2sUm9F6tWempwtLgofZQn0pZrbd423dw7AtS6Wybv8rnlyDxOqsvoRTW6HNEOhQBW+D5ySwE948Ut2B1Ebi8bwe/EFm5JMmB3a3R2KuHlE+EkLwTY6S3iYlLC+8LelgP/Y01VANLDXdBYm3stBbsMNRGpXmNL563i/jJiHF78j9PzzG1pRfcfovsZuuqyk/Yvej9+X4FTDm+wYp6FQ6YdDpTcwSzFMAcOqUrSDvsk4Kp7I8WJ13Lmf1bDSM21d0o3Ril1xiHBCnKdpLXHKkzxlbzec//AGBWTfZLphEtn863CpqoTA47tXnAYc5rR1hoFxFFFNRvfcJstCkV2/CcI5uISDGGzzEhorh73cdKdokYByTjX9HiCtpBdMvKs7riX5hq3dUx20nUZMCbL8zPfh3bi4O7OlqU1D0sLWglT2flfGh6ybUKeSaNvWDsFkVlV8DuU1ONJT2q2rlPJTTH4TTivFfXiZRRGUrHIC4sfhJfEQWJtR6r36lVJnOH9Rvd2Ha/XoFInOh06pkCag4dAJXa1TLEOvv2ZwZzw/n0xMMgbzRguWb+wmI4lLc/JRQnYVOUDYhiCTU8i4f6GkhI935vQaV6AquaAepWIyEvVorz9m9YjcouIVDZ5w8dbZ+cTut4U0wi9B11aPZplO4Co/zFqeRrJMgqORVD4/NNmo4zqqNidieFq3sMKDEx/xD/Bz8ti4WLadXvs8V4ZHssIevEzwVAb+J3EdPv5JiHdHIaSIGb5K98KBB/TIf3vE89EVm8ml6ywOUURK4rhFWyvZ4FReGaAsUAyxtXq2dzopm/gOB+/sMHpfSJ6Vage8nYYGFdx6klCqqZ/64YfVOKa7WvmY7/gEgF2sgFvHrzXSQisDEXguA78g10ZeXfjhPNKY4sGUJrC+yW/pV3gSxcOyGeJLU/DUX8ShHoLUBdm8kd6GckLnUpqDkxkb7uI3xV e1ypmQT7 RCgJeP8AMM6XLtid1WUCK0bhHSjiLMQhXn58CUY6NfHW0cbCl/BgLIJXpEh6+YKbKZUJCAifViaXdfNDhlw4XryuVEi2pLQ+nY4OMx/sTXLH8JHhl4LqK6MF8Xl4EOAbksELQlqKlP7cZ6ox1JoCc0XmKacyw6+BYsQxFDVCuq2epmy1/Ln6Px+VSN46D9Y/pVsr7k8MX9IEjaqd/slx8iQlqUd3E7BC8z1rz0kE2IauZu9U0iVy8EL8sRPlOVsZ/pehw9Rk7c1OyE4W9qGLzfKsqBwyCGckPHzIPZFPkIXve8AwfzhHy7atcKtXT+Umwh05M4zhLRo6SAPJOOwOGe6ori+Jcebi1HQeE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024-08-08 4:52 p.m., Guenter Roeck wrote: > On 8/8/24 11:19, Linus Torvalds wrote: >> On Thu, 8 Aug 2024 at 10:48, Thomas Gleixner wrote: >>> >>> Here is the disassembly from my latest crashing debug kernel which >>> shifts it up a couple of pages. Add 0x10 or sub 0x20 to make it work. >> >> Looks like I was off by an instruction, it's the 28th divide-step (not >> 29) that does the page crosser: >> >>>      4121dffc:   0b 21 04 41     ds r1,r25,r1 >>>      4121e000:   0b bd 07 1d     add,c ret1,ret1,ret1 I think this macro might clobber the C/B bits on a ITLB missing:         /* This is for ILP32 PA2.0 only.  The TLB insertion needs          * to extend into I/O space if the address is 0xfXXXXXXX          * so we extend the f's into the top word of the pte in          * this case */         .macro          f_extend        pte,tmp         extrd,s         \pte,42,4,\tmp         addi,<>         1,\tmp,%r0         extrd,s         \pte,63,25,\pte         .endm The addi instruction affects the C/B bits.  However, it is only used for 32-bit PA 2.0 kernels. A second tmp register would be needed to change the addi to an add logical. The mode likely problem is the shladd instruction in the following macro in entry.S:         .macro          L2_ptep pmd,pte,index,va,fault #if CONFIG_PGTABLE_LEVELS == 3         extru_safe      \va,31-ASM_PMD_SHIFT,ASM_BITS_PER_PMD,\index #else         extru_safe \va,31-ASM_PGDIR_SHIFT,ASM_BITS_PER_PGD,\index #endif         dep             %r0,31,PAGE_SHIFT,\pmd  /* clear offset */ #if CONFIG_PGTABLE_LEVELS < 3         copy            %r0,\pte #endif         ldw,s           \index(\pmd),\pmd         bb,>=,n         \pmd,_PxD_PRESENT_BIT,\fault         dep             %r0,31,PxD_FLAG_SHIFT,\pmd /* clear flags */         SHLREG          \pmd,PxD_VALUE_SHIFT,\pmd         extru_safe      \va,31-PAGE_SHIFT,ASM_BITS_PER_PTE,\index         dep             %r0,31,PAGE_SHIFT,\pmd  /* clear offset */         shladd          \index,BITS_PER_PTE_ENTRY,\pmd,\pmd /* pmd is now pte */         .endm I believe the shladd instruction should be changed to shladd,l (shift left and add logical). Dave -- John David Anglin dave.anglin@bell.net